Maybe it's just me, but after choosing a pop-up javascript date with the mouse, it's very counter-intuitive to then move to the keyboard to enter a time (and having to use the arrow keys to move within the time field is incredibly confusing).

Perhaps you could use Jason Huck's timepicker - it works in much the same was as the calendar/date picker, and so I think is much more intuitive. There is a demo of it here ('Timepicker Plugin by Jason Huck') but ignore the weird ajax stuff going on.

CommentFileSizeAuthor
#131 233047-date-timepicker-alternative-updated.patch5.75 KBgooddesignusa
#127 233047-127-typo-followup.patch1.5 KBDavid_Rothstein
#110 233047-110.wvega-timepicker.patch11.79 KBDavid_Rothstein
#110 interdiff-94-110.txt2.1 KBDavid_Rothstein
#94 233047-94.wvega-timepicker.patch11.29 KBDavid_Rothstein
#83 skitched-20110726-063503.jpg62.44 KBKarenS
#81 Chrome javascript console error.JPG40.71 KBarlinsandbulte
#74 timepicker folder screenshot.png81.34 KBarlinsandbulte
#74 Create event node screenshot.png58.5 KBarlinsandbulte
#74 Main frame source.txt14.73 KBarlinsandbulte
#74 overlay source.txt24.06 KBarlinsandbulte
#69 233047-69.wvega-timepicker.patch11.25 KBksenzee
#68 233047-68.wvega-timepicker.patch10.68 KBksenzee
#54 233047-date-timepicker-alternative.patch6.21 KBmrfelton
#53 233047-date-timepicker-alternative.patch10.79 KBmrfelton
#51 date_popup.time_dropdown.patch5.23 KBmcarbone
#47 date_timedropdown.png39 KBmcarbone
#45 date_popup.time_dropdown.patch5.21 KBmcarbone
#43 date-233047.patch5.19 KBrealityloop
#40 date_popup.timedropdown.js_.txt3.37 KBmcarbone
#40 date_popup.time_dropdown.patch1.37 KBmcarbone
#35 date_popup.timedropdown.js_.txt3.32 KBmcarbone
#35 date_popup.time_dropdown.patch1.37 KBmcarbone
#31 date_time_cck.png44.28 KBendless_wander
#31 default_date_popup.jpg17.42 KBendless_wander
#29 date_popup.png29.98 KBendless_wander
#26 jquery date dropdown.png3.74 KBintent
#22 date_popup.time_dropdown.patch1.37 KBmcarbone
#22 date_popup.timedropdown.js_.txt3.26 KBmcarbone
#20 date_popup.time_dropdown.patch1.37 KBmcarbone
#20 date_popup.timedropdown.js_.txt3.24 KBmcarbone
#14 date_popup.time_dropdown.patch1.37 KBmcarbone
#14 date_popup.timedropdown.js_.txt3.22 KBmcarbone
#12 date_popup_timepickr.patch2.44 KBjcolbyk
#2 date-disable-time-picker.patch11.24 KBgagarine
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gagarine’s picture

Category: feature » bug

I confirm. This time picker really isn't intuitive. I's a bug, i tested this picker with ~10 users and they never used it correctly.

For now I suggest to simply disable JS for the time when the pop-up calendar are enabled.

The problem with the current time picker:
- no feedback if the user enters a "false" value
- you need to use "tab" to edit two values of the same field.
- you don't to need write the ":" (but the user thinks he needs to, so he writes it...)

Solution:
- never block key!
- user needs to write the ":" separator, don't jump it. (if you create two fields the user needs to press "tab" and tab to pass from the first field to the second. A lot of users don't know the "tab" key and use the mouse but all users know the ":")
- JS complete time like this: 9:30 to 09:30
- JS highlight the edited number and when a key is pressed go to the next.

gagarine’s picture

A patch to disable JS for time but keep the calendar pop-up for date.

intent’s picture

The patch worked as expected, but I'm in general agreement with the OP that the timepicker should be formatted as hour, minute, and am/pm select lists so that the user need only use a mouse to select each component of the date/time.

Mixologic’s picture

http://haineault.com/media/examples/jquery-utils/demo/ui-timepickr.html

This timepicker looks *really* good .. the spinner button time picker, which much more intuitive than the current implementation is still somewhat difficult to use. That being said the one Im linking to is probably not that useful if you need minute granularity as opposed to 15, 10 or 5 minute granularity.

Edit-- The timepicker I linked to above is much more robust now:

http://haineault.com/media/jquery/ui-timepickr/page/

patrickharris’s picture

That's a very nice timepicker Ryan - better than the one I initially suggested.

trackleft’s picture

How can I put this on my site? Does anyone know of a way? The current timepicker is so hard to use.

mrthumpz’s picture

subscribe

intent’s picture

I installed this patch and it appeared to install without issue, but the timepicker is still displaying. Do I need to change the widget type or some such setting to see a change?

Thanks.

intent’s picture

Ok, I discovered that the patch didn't actually take, modified the code manually, and now see that the timepicker has been disabled.

While I see that this is doing exactly as it was intended to do, I'm disappointed in the result. I was hoping that disabling the js time picker would cause a revert to the time select functionality with drop down menus. While I think a js time picker like some linked to in this thread are kinda cool, what I would really like to see is a separation between the date and time interfaces where I could use js for the date selection and the old standby drop down lists for the time selection. Or at the very least, I think this would be a useful option for those who might not want/need a fancy schmancy js time picker.

Just my .02

light-blue’s picture

I needed a good timepicker ASAP, so based on input here, below is what it took to make this work. Sorry to the beginners if this doesn't make sense... Note, this doesn't work in IE and I couldn't figure out why...

//put this in your or somebody else's module (paths are based on latest tarball, as of today)

	//timepicker
	drupal_add_css(drupal_get_path('module','yourmodule').'/jquery-timepickr/dist/themes/default/ui.core.css');
	drupal_add_css(drupal_get_path('module','yourmodule').'/jquery-timepickr/src/css/ui.dropslide.css');
	drupal_add_css(drupal_get_path('module','yourmodule').'/jquery-timepickr/src/css/ui.timepickr.css');
	
	drupal_add_js(drupal_get_path('module','yourmodule').'/jquery-timepickr/page/jquery.ui.all.js');
  drupal_add_js(drupal_get_path('module','yourmodule').'/jquery-timepickr/page/jquery.utils.js');
  drupal_add_js(drupal_get_path('module','yourmodule').'/jquery-timepickr/page/jquery.strings.js');
  
	drupal_add_css(drupal_get_path('module','yourmodule').'/jquery-timepickr/dist/jquery.timepickr.css');
  drupal_add_js(drupal_get_path('module','yourmodule').'/jquery-timepickr/dist/ui.timepickr.js');

//in javascript somewhere
var periods = ["AM","PM"];
$('.jquery-timeentry-1').timepickr({
format12: "{h:02.d}:{m:02.d}{suffix:s}",
convention: 12,
prefix: periods,
suffix: periods
});
});

KarenS’s picture

Title: Time picker javascript is counter-intuitive » Alternatives to jQuery timepicker
Category: bug » feature

I committed a change today that will allow you to turn off the jQuery timepicker and still use the jQuery calendar. It's a site-wide default. It will revert to a plain text box for the picker, not a drop-down selector.

It would take more work to get the drop-down selector working. If someone wants to make a patch to do that, you are welcome to provide it, but I don't have time to do it.

jcolbyk’s picture

Issue tags: +date_popup
FileSize
2.44 KB

I've spent a productive evening integrating Mr. Haineault's timepickr jquery widget into date_popup in date-6.x-2.2.tar.gz (thanks to light-blue for a starting place).

Instructions for use:

Download jquery.timepickr-0.6.6-standalone.zip from http://code.google.com/p/jquery-utils/downloads/list

unpack jquery.timepickr-0.6.6-standalone.zip and you will find a new directory called 'standalone' with a subdirectory called ui-timepickr. Move ui-timepickr into modules/date/date_popup.

Then apply the attached patch, by copying to modules, then:

patch -p0 < date_popup_timepickr.patch

Any forms that you've specified date_popup to be used will now use timepickr.

Known issues:

timepickr only pops up in firefox 3 (haven't tested 3.5) and does not seem to popup in safari 4 (haven't tested 3). (note, the standalone version/demo of timepickr seems to work without a hitch on safari 3 and 4, so, this is probably related to the next issue)

It requires 2 focus click events on the time input before it starts to function, i.e. click or tab into the time field, and timepickr doesn't show up. Click outside of the time field (to take away focus from it), then click in the time field again, and now it shows up. I've no idea why yet.

The theme of the date picker becomes _very_ different and I'm not sure why yet, probably some namespace collisions within the various .css and .js files from jquery-utils?

Any advice would be appreciated to help me over these (probably) newbie issues.

intent’s picture

KarenS - time is a valuable commodity and I, and I'm sure many others, appreciate all that you have given to the Date module.

I almost certainly don't possess the skills necessary to get a drop down timepicker option working, but when I get a chance I'm going to look into it some more and see if I can come up with anything. If I do I will, of course, post what I find here.

Interestingly, I also stumbled upon another jquery timepicker plugin which might also work for my needs - http://www.protocoder.com/javascript/jquery-simple-clock-plugin-for-time...

I'll be taking a look at this as well, but thought I'd post it here in case someone much smarter than I knows how to integrate it into the Date module, maybe as another timepicker option in KarenS' Timepicker selection menu.

mcarbone’s picture

Version: 7.x-1.x-dev » 6.x-2.4
Status: Active » Needs review
FileSize
3.22 KB
1.37 KB

Here is a stab at a dropdown timepicker, implemented in jQuery and presented as an alternative timepicker on the Date Popup settings page. It seems to be working fairly well, but it could probably use some more testing. (Make sure to remove the .txt extension from the js file, and put it in the date_popup directory.)

nickbits’s picture

Have just applied this to my system and it appears to work perfectly. Perhaps we could get this committed to the CVS?

Well done,
Nick

intent’s picture

Wow ... just wow.

That is exactly what I need. mcarbone, you are a drupal God, thank you for developing this. I'll be testing it on my test site this weekend and assuming everything goes fine, I will likely install it on my production site next week.

Wow.

gagarine’s picture

Status: Needs review » Reviewed & tested by the community

Someone can provide a link with this patch working? Or at least a screen capture?

mcarbone’s picture

Status: Reviewed & tested by the community » Needs review

Hmm, that doesn't sound like an RTBC comment.

gagarine’s picture

Ouuuups sorry
first I wan't to just add "RTBC" because two peoples look at the patch but I change my mind when I write my comment.

mcarbone’s picture

Made a slight tweak to the js file to support the Date Repeat Except fieldset.

intent’s picture

Status: Needs review » Needs work

Ok, so I've played around a little and run into a couple of issues.

1. The date/time revert to my default (Now) when I continue to the preview page. If it's a setting that I have wrong I cannot figure out which one it might be.
2. I'm using the Confirm module and when I use the "return to previous page" link provided by the module (rather than the browser back button), the javascript doesn't load. If I use the browser back button, however, it does load.

mcarbone’s picture

Status: Needs work » Needs review
FileSize
3.26 KB
1.37 KB

Small fix. Try it now.

intent’s picture

Your change fixed the back button issue for me.

Also, I found the time selects properly if I set the default to "Blank" instead of "Now". This time issue was happening no matter which js option I tried, so it wasn't specific to your patch mcarbone.

I'll conduct some more testing, but so far this looks to be working.

intent’s picture

Discovered one more not-so-minor problem. The hour and minute fields aren't displaying correctly in IE7. I haven't had a chance to test in IE8, but all other browsers I've tested display just fine.

Also, in case this is useful to anyone else, I changed my default time setting from "Now" to "Blank", then back to "Now" and it resolved the issue I was experiencing whereby the time was defaulting to the current date/time on the preview page no matter what date/time was selected.

mcarbone’s picture

Just tested again in IE7 and it's working for me. Can you post a snapshot and any errors IE might be throwing?

intent’s picture

FileSize
3.74 KB

No errors are being thrown. This is what I'm seeing on IE7 / Windows XP.

I also noticed that if I change the screen size from 100% to 125% the drop down displays correctly, even if I then revert back to 100%. Not sure if this indicates some sort of load problem or what.

mcarbone’s picture

Hmm, it looks like a rendering/CSS issue of some sort. I suspect that if you looked at the generated HTML with Firebug it would be OK. Are you testing this on a fresh install with an out-of-the-box theme? It could also be something specific to your set up. I'd appreciate any tips in terms of making this appear more consistent if it's not, since all it is just a sequence of input tags.

willemt’s picture

works great mcarbon!! Thanks a lot.

endless_wander’s picture

FileSize
29.98 KB

mcarbon's drop-down menu looks great, but on my install, two drop-downs display where only one should be... (see attached screenshot)

I'm using the patch and .js from #22

Any suggestions?

mcarbone’s picture

Status: Needs review » Needs work

Hmm, that's not good. What date options are you using? What does the form look like there if you are using the default timepicker? In other words, how can I reproduce this on a fresh install?

endless_wander’s picture

FileSize
17.42 KB
44.28 KB

Thanks for responding, mcarbone. It's much appreciated.

The Date & Time field is added through CCK and the settings for the field are in the attached screenshot "date_time_cck.png"

At first, I thought maybe I had left the option for having both a "From" and a "To" time, but after triple-checking, the "To" option is disabled.

If I choose the default timepicker, I only get one field (see attached default_date_popup.jpg).

I'm using Calendar, if that's relevant. Please let me know if I can provide any more info.

mcarbone’s picture

Well darn, I copied over your configuration and still can't reproduce it. Let's try a few more questions: what browser are you using? Can you use Firebug to pull what the HTML looks like of the dropdowns after the jQuery runs?

robby.smith’s picture

subscribing

endless_wander’s picture

#32

Sure thing. The double-dropdown occurs in Firefox, Safari and Internet Explorer.

Here's the code:

</div><div class="date-clear"><div class="container-inline-date date-clear-block"><div class="form-item" id="edit-field-datetime-rrule-UNTIL-datetime-wrapper">
 <label for="edit-field-datetime-rrule-UNTIL-datetime">Until: </label>
 <div class="form-item" id="edit-field-datetime-rrule-UNTIL-datetime-datepicker-popup-0-wrapper">
 <input type="text" maxlength="30" name="field_datetime[rrule][UNTIL][datetime][date]" id="edit-field-datetime-rrule-UNTIL-datetime-datepicker-popup-0" size="20" value="" class="form-text" />

 <div class="description"> Format: Apr 21 2010</div>
</div>
<div class="form-item" id="edit-field-datetime-rrule-UNTIL-datetime-timeEntry-popup-1-wrapper">
 <input type="text" maxlength="10" name="field_datetime[rrule][UNTIL][datetime][time]" id="edit-field-datetime-rrule-UNTIL-datetime-timeEntry-popup-1" size="10" value="" class="form-text" />
 <div class="description">Format: 11:26PM</div>
</div>

I'll PM you a user login if you'd like to check it out. The function will be available for all authenticated users.

mcarbone’s picture

Status: Needs work » Needs review
FileSize
1.37 KB
3.32 KB

Thanks for the access, clavigne, it helped me debug the issue. Turns out that you have something triggering behaviors a second time, and I wasn't accounting for that. Try this one.

endless_wander’s picture

Worked like a charm!

mcarbone = genius

Edit: The genius title still applies, I think. Only I just discovered that while this patch fixed the double-drop-down problem, it's now taken away the datepicker calendar.

mcarbone’s picture

Looks like javascript is now crapping out for you mid-way (this is why it's also not applying the dropdown in the Repeat fieldset -- and likely the dropdown values won't even work when you submit). I'll try to debug this when I have a chance, but again it's not happening on my install.

endless_wander’s picture

I loaded the date_popup.js from #22 and now both the date-picker and the drop-down timepicker work. Their values save when the node is saved and it looks like everything is working.

EDIT: It was actually another field on the page that was causing the problem. I was using a CCK field from the OpenLayers module. When that field is present, the double drop-down problem occurs. When that field is removed, the date and time fields work properly.

mcarbone’s picture

Does the more recent patch work w/o the OpenLayers field?

mcarbone’s picture

OK, this should do the trick. I was doing a lame job with checking if a field had been processed or not, but that's fixed now.

rc2020’s picture

subscribing

rc2020’s picture

This is a really, really great feature. Thanks Mcarbone.

Also, I suggest making a modification to the .js file on line 79, putting a css ID on the 'at' text, so it can be positioned above the elements if necessary.

 var dropdowns = '<div id="datedroplabel">at</div> ' + hours + mins + secs + ampm;

Is this on track of getting committed?

realityloop’s picture

FileSize
5.19 KB

Full patch, including js file creation, for mcarbones #40 code with #42 added but as a span as div caused line break.

cafuego’s picture

Status: Needs review » Needs work

That seems to work as advertised. I'd maybe suggest moving date_popup.timedropdown.js into the lib subdirectory.

mcarbone’s picture

Status: Needs work » Needs review
FileSize
5.21 KB

Here you go. Not sure this is ideal, since it's not really a library, but the maintainer can make the call between this patch and the one in #43.

Melissamcewen’s picture

I get " date_format() expects parameter 1 to be DateTime, string given in /Applications/MAMP/htdocs/cuarts/sites/all/modules/date/date_api.module on line 71" for #45"

Also, is it possible to get a screenshot of the new functionality?

mcarbone’s picture

Version: 6.x-2.4 » 6.x-2.x-dev
FileSize
39 KB

I think that's an error from the dev tarball, not from the patch itself. (maybe this one? #518816: warning: date_format() expects parameter 1 to be DateTime) I still get that error even without the patch. This patch also works with the latest official release, so you can try it with that as well.

Attached is a screenshot of it on 6.x-2.4.

Coxen’s picture

Subscribe

klonos’s picture

subscribing...

ethnovode’s picture

Hello,
Nice patch ! I made a very small modification to make the string "at" up for translation as explained here :
http://drupal.org/node/323109

I changed line 80 in date_popup.timedropdown.js :
var dropdowns = '<span id="datedroplabel">at</span> ' + hours + mins + secs + ampm;
to
var dropdowns = '<span id="datedroplabel">' + Drupal.t('at') + '</span> ' + hours + mins + secs + ampm;

mcarbone’s picture

Good idea.

mrfelton’s picture

Status: Needs review » Needs work

Awesome!

2 things though

I have a FAPI element defined like this:

  $form['packages']['depart_date'] = array(
    '#type'=> 'date_popup',
    '#title' => t('Depart'),
    '#date_format' => 'Y-m-d H',
    '#date_text_parts' => array('year'),
    '#date_increment' => 60,
    '#date_year_range' => '0:+2',
    '#default_value' => 'now',
    '#size' => 10,
  );

1) If I set my date format to 'Y-m-d H', I still get a drop down for minutes, even though I'm not interested in minutes.
2) it would be cool though if you could actually set this per widget/FAPI form item rather than a global setting ;)

mrfelton’s picture

Status: Needs work » Needs review
FileSize
10.79 KB

This version allows me to have just hours, used with the following:

  $form['packages']['depart_date'] = array(
    '#type'=> 'date_popup',
    '#title' => t('Depart'),
    '#date_format' => 'Y-m-d h',
    '#granularity' => array('hour'),
    '#date_increment' => 30,
    '#date_year_range' => '0:+2',
    '#default_value' => 'now',
    '#size' => 10,
  );
mrfelton’s picture

Ignore my last patch, it was screwed up. God dammed CVS!! This is what I meant:

gooddesignusa’s picture

Thanks for the patch this works much better. I'm going to end up using this instead of the normal one since it had some issues on a laptop.
see:http://drupal.org/node/891210

heatasmallhouse’s picture

I'm building a system for a non-profit to be able to post happenings, events, etc and see new and upcoming posts.

NOBODY understood how to use the default time-input method. I've seen people defend it as more efficient, but it simply is not in this day in age where most time entry is done with drop downs (including Outlook, which is a lot of people's reference point).

The drop down feature simply must be included in the next update.

In the meantime, THANK YOU THANK YOU THANK YOU MCARBONE!!!!

gooddesignusa’s picture

One thing that should be inserted somewhere is the ability to set an all day event. Setting both times to 12:00 AM does it. Not all clients will know this though so maybe a checkbox or just have some text under the drop down?

arlinsandbulte’s picture

I like the looks of this timepicker a lot!
http://wvega.com/225/jquery-timepicker/

rorymadden’s picture

Is anyone able to make a patch for this for drupal 7? I had a look at trying to update the current patches but there are a few changes to how the timepicker js is called in the d7 date module. Its above my head unfortunately.

gooddesignusa’s picture

Any chance on getting a re-roll this for the latest version 6.x-2.7. I tried the patch from comment #54 and this is the output:
Hunk #2 succeeded at 328 (offset 28 lines).
Hunk #3 succeeded at 626 (offset 28 lines).
Hunk #4 FAILED at 656.
1 out of 4 hunks FAILED -- saving rejects to file ./date_popup/date_popup.module.rej

inside that file:

***************
*** 648,651 ****
    $form['#suffix'] = t('<p>The Date Popup calendar includes some css for IE6 that breaks css validation. Since IE 6 is now superceded by IE 7 and IE 8, the special css for IE 6 has been removed from the regular css used by the Date Popup. If you find you need that css after all, you can add it back in your theme. Look at the way the Garland theme adds special IE-only css in in its page.tpl.php file. The css you need is:</p>') .'<blockquote><PRE>'. $css .'</PRE></blockquote>';
  
    return system_settings_form($form);
- }--- 656,659 ----
    $form['#suffix'] = t('<p>The Date Popup calendar includes some css for IE6 that breaks css validation. Since IE 6 is now superceded by IE 7 and IE 8, the special css for IE 6 has been removed from the regular css used by the Date Popup. If you find you need that css after all, you can add it back in your theme. Look at the way the Garland theme adds special IE-only css in in its page.tpl.php file. The css you need is:</p>') .'<blockquote><PRE>'. $css .'</PRE></blockquote>';
  
    return system_settings_form($form);
+ }

It does seem to still work though. I wish this was just accepted into the latest version because the one that comes with it has some issues.

deminy’s picture

Don't understand why the maintainer doesn't want to put the patch into CVS. Every single time when I need to upgrade module Date, I have to patch it manually since version 2.4 or even earlier.

bomarmonk’s picture

I'm all for the most robust patch being committed to the development version and finding its way into an official release; this really seems to improve the usability/ UI of the date module.

gagarine’s picture

#58 is what I was secretly dreaming when I post in #1. Please take a look at http://wvega.com/225/jquery-timepicker/ for a demo and the code is here https://github.com/wvega/timepicker

This plugin is just nice, light and clean. The license is a MIT license so we can use it on drupal.org by licensing the code in GPL.

Someone is against of using this code? But if a patch is ready it should be committed and this can be an other feature request.

gooddesignusa’s picture

I just discovered a bug. Line 21:

        if (datePopup.settings.showSeconds) {
          def_mins = current.substr(3, 2);
        }

should be

        if (datePopup.settings.showMinutes) {
          def_mins = current.substr(3, 2);
        }
developer-x’s picture

Subscribe

developer-x’s picture

I've submitted a new project, datetweaks. This module includes the following functionality

  1. Adds in Baron Schwartz's date-time javascript functionality
  2. Maintains the date's duration - so when the start date changes, the end date also changes
  3. Adds in Willington Vega's dropdown time picker. By default, this timepicker replaces the standard timepicker
  4. Adds an "All Day" button which toggles the time field. When checked, the start and end time is set to 00:00

So this provides a google-like timepicker dropdown using the query package suggested by arlinsandbulte in comment #58.

If anyone gives it a try - I'd love to get some feedback.

arlinsandbulte’s picture

WOW! This looks awesome, dev-x!
I can't wait to give it a spin on my own site!
The demo site at http://www.okeel.com/node/add/event looks amazing!

ksenzee’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev
FileSize
10.68 KB

Here's a patch for the D7 version that gives admins the option of using the wvega timepicker. It has to be downloaded separately into sites/all/libraries/wvega-timepicker. There are download instructions on the date popup config form. It also plays nicely with libraries module if that's installed.

ksenzee’s picture

On second thought, we ought to default to the wvega timepicker if it's available on the system. Revised patch attached.

arlinsandbulte’s picture

Status: Needs review » Needs work

Thanks ksenzee, but I am getting this javascript error when I try to use the dropdown time picker:
Error: $(this).timepicker is not a function
Source File: http://example.dev/sites/all/modules/date/date_popup/date_popup.js?lopt01
Line: 43

Other than that, installation went well:
Applied patch & visited /admin/config/content/date_popup
Timepicker was set to 'use default jQuery timepicker' and there were instructions on how to enable the dropdown wvega timepicker.
Followed directions (created /sites/all/libraries/wvega-timepicker directory & copied jquery.timepicker.css and jquery.timepicker.js into there)
Reloaded /admin/config/content/date_popup and 'use dropdown timepicker' was set.
Visited my event content type, but timepicker did not work. Noticed above js error.

ksenzee’s picture

Status: Needs work » Needs review

Hm. It looks like jquery.timepicker.js isn't getting added to the page for some reason. Do you have JS aggregation on? Maybe try clearing Drupal cache, or a browser shift-reload?

ksenzee’s picture

Status: Needs review » Needs work

Didn't mean to change status.

KarenS’s picture

Status: Needs work » Needs review

The css and js files need to be renamed. In the current download they are named jquery.timepicker-1.1.0.css and jquery.timepicker-1.1.0.js. So the explanation probably needs to include that fact.

After renaming them, I think they are working correctly.

arlinsandbulte’s picture

OK, tried a clean install of ONLY D7.4 & latest -dev of Date. And css & javascript optimizations are NOT enabled.
Still no luck...same results.

I did not need to rename the downloaded files (see screenshot of my folder).
Also attached is the source of my page.

I also tried installing the Libraries module, but still no luck. Is that optional? What benefit is the libraries module?

ksenzee’s picture

What browser are you using? It looks like the timepicker is getting added to the page correctly, so I'm baffled as to why $.timepicker wouldn't be available. The libraries module integration is definitely optional. It lets people put the wvega-timepicker library into sites/<sitename>/libraries and the libraries module will pick it up there.

arlinsandbulte’s picture

I have tried both FireFox & Chrome.
I am using the quickstart virtual machine dev environment on my Win 7 laptop.

The default jquery timepicker works fine if that option is selected.

Indeed this is very strange.

arlinsandbulte’s picture

Here is a screencast video of EXACTLY how I try to set up the dropdown timepicker.
http://vimeo.com/26827075
Sorry, no audio as audio input is not working on my virtual environment.

It starts creating a fresh D7 install.
I install Date module and create a new content type.
I verify the default jquery timepicker works.
Then, I follow the instructions to get the code for the dropdown timepicker.

KarenS’s picture

Status: Needs review » Needs work

Arlin, I watched your video, didn't see you save the option to use the drop-down picker. It defaults to that value if you have the library installed, but nothing sets the variable unless you submit that form. Does it work if you go back and submit that form?

If that is what happened we need to think about how to handle this. It's confusing to see that value selected in the option list when it has not yet been actually set.

KarenS’s picture

If I'm right, it would have worked right if you had never selected a timepicker, but since you selected one previously, the variable was already set to that value, and you didn't submit the form so it didn't get reset.

arlinsandbulte’s picture

Karen,
You are right that I never clicked save in the video.
But I have tried that other times, and I just tried it now with still the same results.

And, even if you were right, if I never saved the timepicker option, the default jquery picker should work instead, which it does not.

I am going to try this on a windows aquia DAMP install and see if the results are different.

arlinsandbulte’s picture

I hate to say it, but same error when I try this on a windows Aquia DAMP environment.
Tested under windows in IE9, FF4, & Chrome.

Attached is a Chrome javascript console error output.

I have tried just about everything I can think of (clearing caches, saving the config page, switching back and forth between default & dropdown, etc.).

ksenzee’s picture

It's confusing to see that value selected in the option list when it has not yet been actually set.

The dropdown list is using whatever the current default is, like any system_settings_form variable should. If the library is available on the system, the form defaults to that (and the system uses it). If the library is not available on the system, the form defaults to the other timepicker (and the system uses it). So I don't think the form is the source of the problems here. Not that I've figured out what is the source of the problems here. :(

KarenS’s picture

FileSize
62.44 KB

My display is not quite right, this is using FF 5.0.1 on a Mac Air running 10.6.8.

KarenS’s picture

My point on the variable is that he already had set the variable and if he didn't submit the administration page the value wouldn't get changed.

In IRC we sorted out what Arlin's problem was (he had the wrong files), so we need some clarifications in the description of what to do. I am also going to contact the author of the library to see if he would be willing to dual-license it as GPL, because if he will, we can just include the code in our module.

The last item that came up in IRC is that this timepicker won't constrain the time like the other one does. If you pick a 15 minute increment, that is what shows up in the drop down but you can still type in another value. I need to make sure that won't break any other code in the Date module because I currently have some code that assumes you are actually limited to the chosen increment and you would never have any values in that field that don't match the chosen increment.

arlinsandbulte’s picture

OK, I got my issues figured out. I was not downloading the wvega-timepicker files properly (stupid mistake & I should have known better). So ksenzee's patch in #69 works. Thanks for the IRC troubleshooting help, ksenzee!

However, KarenS noted that the time value should obey the allowed minute intervals (1, 5, 10, 15, or 30 min) of the date field. After testing this, I don't think this concern should hold back this patch.

Current Code:
Using the 'default query timepicker' setting, the user cannot enter a time value that violates the minute interval setting.
Using the 'Manual time entry, no jQuery timepicker' setting, the user CAN enter a time that violates the minute interval, but that time is automatically changed to the nearest interval when saved.

Patch from #69:
Using the new 'Dropdown timepicker' setting, the dropdown list values are limited according to the minute interval setting, but the user can enter any value they wish into the text box. If the user enters a time that violates the minute interval setting, that time is automatically changed to the nearest interval when saved.

Thus, I don't think there is any problem with how the new dropdown timepicker allows 'invalid' minutes. It is just as good or bad as using the manual time entry mode.
The patch in #69 is RTBC for me, but we may want to further clarify the download instructions so people do not have the same issues I had above.

A follow-up issue might be made to NOT automatically change time values to the nearest minute interval when saved, but IMO, that should be a separate issue (and as Karen noted, might have some further reaching consequences in the code).

Thanks.

KarenS’s picture

OK, now I see what you mean about always using the vega timepicker if available. I wonder about that, that means the only way to set any other value is to remove the vega code? We had an option to turn the timepicker off completely if it wasn't behaving right, so we've now lost any way to use the older timepicker or turn jquery off. If they have to download and install the vega code to get this working I suppose we can assume they want to use it. If we do get permission to include the code in the module we need to go back to giving the user a choice (we can still 'default' to the vega code (which is what I thought you were doing all along until I read the patch more closely).

KarenS’s picture

I sent an email to Vega to see if he would be willing to dual-license the code. If he responds that he is, we can add the code in. For now we probably just need slightly adjusted instructions about how to install it manually.

The screenshot I provided is a little unusable, maybe ksenzee can figure out how to tweak the css or js so that fits in better.

So if we fix the description and the dropdown display issue in #83, we probably can call this ready to commit. Arlin, since you had some trouble with this, do you have any suggestions for new language for the description of how to install?

KarenS’s picture

After committing #1227208: minor text changes I can no longer get this patch to apply, so it needs a reroll.

arlinsandbulte’s picture

I could work on this more later today.

One question: is there are better location to point the download link? Preferably some sort of permalink to download the correct zip archive. Then, the instructions could detail how to extract the archive to the right libraries folder.

KarenS’s picture

There is a download link on the git hub page. That's what I used.

arlinsandbulte’s picture

The download issues are probably all moot now.
Looks like wvega just released under the GPLv2....YAY!
https://github.com/wvega/timepicker/blob/master/GPL-LICENSE.txt

KarenS’s picture

He just responded to my email and said he was happy to dual license. So now we can roll the code into this patch instead of messing with instructions about how to do it.

ksenzee’s picture

Awesome. I'll reroll.

Re #86, you should be able to turn the timepicker off via the config form, the same way you could before.

David_Rothstein’s picture

Rerolled the patch so it applies against the latest 7.x-2.x code. This does not yet address any of the other feedback above, though.

John Bickar’s picture

Thank you all so much for the work on this! It has been a major roadblock to a project that I've been working on.

One thing to note is that you need to rename the timepicker .js and .css files from:

sites/all/libraries/wvega-timepicker/jquery.timepicker-1.1.2.css
sites/all/libraries/wvega-timepicker/jquery.timepicker-1.1.2.js

to

sites/all/libraries/wvega-timepicker/jquery.timepicker.css
sites/all/libraries/wvega-timepicker/jquery.timepicker.js

(This had me stumped for a while.)

There is a an issue in the Date Tweaks module queue to port it to D7 (http://drupal.org/node/1099846); I pointed it here because I believe there's some overlap in desired functionality.

David_Rothstein’s picture

Yeah, trying to test this patch out I ran into a similar issue. There are different downloads available and all of them are messy.

If you go to https://github.com/wvega/timepicker/downloads and download the latest "package" (e.g. jquery-timepicker-1.1.2.zip ) you run into the issue @cubbtech noted above with the JS and CSS files having the wrong names, plus the fact that the zip file doesn't contain a subdirectory in it (just the files themselves at the top level) so you need to create the wvega-timepicker directory on your own, which is annoying.

Conversely, if you download the latest "tag" (e.g. 1.1.2.zip) from the same page, the files are named correctly and the zip file extracts into a subdirectory, but the subdirectory has an odd name (wvega-timepicker-c7fa3b8) plus there are no minified JS and CSS files like the other one has (and which would be nice, although not critical, for us to use rather than the un-minified ones).

So basically, neither download is ideal, and we probably need more work on both the instructions and the code to pick a particular download and optimize the code for it.

ksenzee’s picture

As Karen noted in #92, we don't need better instructions - we just need to include a version of the code in the date module. The maintainer agreed to GPL it.

David_Rothstein’s picture

Oh, also, regarding the other suggestion of rolling the wvega library code into the patch, I don't think we can do that since it would appear to violate the 3rd party library policy at http://drupal.org/node/422996.

Unless we have a good reason to ask for an exception to that (and perhaps usability is one!) I think we can't include the code in the Date module directly, so we'll have to work on improving the download instructions instead.

Alternatively, perhaps the wvega maintainer would be willing to change the way the downloads are structured? Ideally it would be best to have the package zip file extract in a subdirectory named wvega-timepicker and to have a constant filename for the minified files (such as jquery.timepicker.min.js).

KarenS’s picture

I believe we can include it "They are absolutely and always forbidden, unless if they are licensed under GPL or GPL v2+ or they have a broader license and can be re-licensed under the GPL. "

He changed the license so we could include it.

David_Rothstein’s picture

That means it's not automatically forbidden, but not that it's automatically allowed either :)

The policy says you still need to ask for an exception and have a good reason: "Any of the above exceptions needs approval by drupal.org administrators. Upfront: 90% of all exception requests are moot. Only ask for an exception if it is really required."

Do you think we should file an issue asking for an exception?

KarenS’s picture

"Any of the above exceptions needs approval by drupal.org administrators." goes with bullet point #3. My read on this is that #2 is OK (GPLv2 code), #3 are exceptions that need permissions.

Who can we ask? I have other GPL code already included here and it is in lots of other modules that I know of. My understanding of the policy has always been that GPL is OK, everything else is problematic.

KarenS’s picture

I went back and read the linked article and that article sounds more like we cannot include GPL code at all. That documentation page is very confusing.

It is definitely a UI WTF to ask people to find files and download them and then rename then and then move them to the right place in the codebase.

Based on that I should remove the old timepicker code, which was the same story (dual licensed under MIT and GPL and the author was happy to have us include it in the code).

David_Rothstein’s picture

Yeah, I agree it's really confusing...

I brought this up for discussion in #drupal-contribute and unfortunately there was unanimous agreement with what I said above (GPL is a necessary, but not sufficient, requirement for being able to include the 3rd party library on drupal.org). There are a number of reasons for that policy: security + not wanting to distribute out-of-date versions, etc.

We can definitely create an issue asking for an exception if we think we have a good reason, though.

John Bickar’s picture

I don't want to muddy the waters too much here, but there is ample precedent for requiring site admins to download third-party JS libraries separately (WYSIWYG, TinyMCE, etc.).

IMO that would not be a huge hurdle.

David_Rothstein’s picture

In the meantime, I did some cross-browser testing of this patch, in particular to look into the issue from #83.

I don't have a Mac, only Linux and Windows - and on those I could not reproduce anything quite as bad as that screenshot, but even on Linux/Windows there are definitely some browsers where the padding looks all messed up.

This actually seems to be due to CSS added by the wvega library itself:

.ui-timepicker-standard .ui-menu-item a {
    padding: 0.2em 0.4em;
}

The 0.4em left/right padding causes the issue. If I remove it, the timepicker looks as good as or better than it did before in all browsers I tested, so I'm not sure why it was there in the first place.

We could override this in Date module pretty easily but perhaps it should be fixed upstream if it's a legitimate bug in the library too (that would avoid the need to maintain a special CSS file just for this override).

ericduran’s picture

So I'm confused as to why this cannot be included in date.

The code is re-license as Dual license with GPL and MIT.

This is perfectly fine to include in date module as long as we add a hook_library for it. That way other module could take advantage of this js.

But besides that I don't see why this can't be added in.

There's a lot of module that have dual license and/or GPL code in it. Its also not policy to not include the library is juts nice to not do.

But honestly this should be in the date module. If not whats the point of hook_library?

arlinsandbulte’s picture

Ugh...3rd party library issue is confusing...
If we are strongly discouraged to include any 3rd party library code in our modules, what is the purpose of the GPL code only policy?

Also, Drupal core itself includes the jquery & jquery ui libraries, which is GPL, I think.
Also, some projects use GPL icons: http://www.lullabot.com/articles/free-gpl-icons-lullacons-pack-1

If we need to cut out the library code, I am OK with that.
But the user experience would be SO MUCH BETTER if the GPL library code is included and 'just works.'

developer-x’s picture

Does drush offer this sort of capability? Perhaps a registry of sorts could be developed that instructs drush how to pull down and install 3rd party libraries?

KarenS’s picture

Drush make can do that -- grab external libraries and install them wherever you want them. But I'm not worried about people who have Drush and Drush Make installed. They can figure it out themselves. It's the others.

David_Rothstein’s picture

Status: Needs work » Needs review
FileSize
2.1 KB
11.79 KB

Wow, I really didn't mean to open a can of worms like that... I did not realize that the Date module already includes other GPL libraries, or that the policy is not well-known. In any case, there are pros and cons to having that policy, but I guess to change it would be a much bigger drupal.org issue. I'm not sure what we should do here. Perhaps Date module's libraries are grandfathered in? :)

In the meantime, I'm working on getting the rest of the patch in good shape. The attached version fixes a few small issues:

  • I found a way to fix the display issue from #83 without changing the library or overriding its CSS: We can just make the textfield large enough to accommodate the biggest items we expect in the dropdown. Trying the attached patch out with the largest time elements possible (i.e., setting a granularity of seconds and using AM/PM in the format) it looked pretty good to me on all Windows/Linux browsers I tested (not amazing in IE7, but still good enough). Not sure what it will look like on a Mac.
  • Fixed an issue where the dropdown was displaying ":0" rather than ":00" for date fields with a granularity of seconds.
  • Fixed an issue where the help text was referring to an option that doesn't appear in the human-facing text.

***

Playing around with this, though, there is one major issue we haven't dealt with yet (besides the download instructions): performance and the size of the dropdown.

If you create a date field with the default configuration (granularity of minutes and increment of 1 minute), that results in a dropdown with 1,440 elements in it, which is ridiculously large and a bit difficult to use. Furthermore, on some browsers, such as Firefox 3.6 and IE 9, this results in very poor performance; I am seeing a delay of 5-10 seconds between clicking on the field and the timepicker widget popping up. (For other browsers like Firefox 5 and Chrome it is better, though.) I did a little bit of performance testing of the wvega library to see if there was a single place that slowed it down, but there wasn't; the delay is simply due to the code processing and shuffling around 1,440 list elements.

Furthermore, that's with minute granularity. If you created a date field with seconds granularity, then in theory you should be able to configure the seconds via this dropdown UI also; currently the patch doesn't do that, but it's easy to fix if we wanted to (and it's arguably a bug). At that point, though, you would have 86,400 elements in the dropdown, which is beyond ridiculous.

So in short, this widget doesn't work nicely unless your date field is configured to use 5 or 15 minute increments or thereabouts. We could say that's a site configuration decision and ignore it, but given how poor the user experience is with the default date field, I'm not sure that's a good idea.

One option (the mild one): When creating a new date field, if you've chosen the popup widget and are using the wvega timepicker, set the default increment choice on the field UI admin screen to 15 minutes (rather than 1 minute).

Another option (the stronger one): Regardless of what increment is chosen when configuring the field, still limit the increment inside the wvega dropdown to e.g. 5 or 15 minutes; that is the most common use case for someone using a timepicker widget anyway. (And they can still type in something different if they want to.) The good thing about this is that it makes it impossible to configure the module in a broken way, but the bad thing is that it might confuse people who are trying to configure it differently. But as mentioned above we already have some of that confusion with the lack of seconds increments in the dropdown, and there's no realistic way we're going to resolve that one so the question is more about where the line should be drawn.

klonos’s picture

Thanx for all your hard work David! I'll give this a spin on next chance and report back.

Now, as far as datepickers go, I am sure we all have one favorite or two. We all seem to agree though that for timepicking we have not found one that covers our needs 100% for the 100% of our use cases (personally, not even 90%, not even close). I too think that second/minute granularity is ridiculous - those who need it should simply let people type it.-

Since we are brainstorming here, I'd like to point out the way things are handled in iOS (iPhone/iPad and the likes). Personally, I'm not that thrilled about selecting dates in that way, but they surely nailed it when it comes to timepicking. What I like the most about its "spinning-wheel" timepickers is the minimal space they take and the fact that they found a classy way to -successfully may I add- replace functionality that would otherwise need reeeally looong drop-downs. After all, was designed to fit the small screens of a portable device. Another plus of this concept is that instead of scrolling all the way up/down to locate the desired hour/minute/second, you can instead keep scrolling to the end and it loops back to the start. This is very useful for example if you need to select 23:55 and the default is set to 00:00 - instead of scrolling forward all the way to it, you simply scroll one step back ;)

So, I googled around for any iPhone-like timepickers out there and I found this jQuery implementation that seems pretty neat:

http://opensource.binofo.com/en/opensource/spinthewheel/

Noyz’s picture

Bit of history on this..

1. The original design proposal for date was this: https://skitch.com/jeff.noyes/fpmte/adobe-fireworks-cs5
2. At one point in time or another, someone thought my approach was unconventional - which I agreed with. However, I wasn't taking the 'time' suggestion literarily. I mostly looked at the request as "it's unconventional to use one text field to popup a calendar selection with time selections included - and also hard to do" - so I agreed to it. I think it was my agreement that started us down this road (sorry). Here is the thread: http://drupal.org/node/1108348#comment-4552336 In my own mind, I read this suggestion as this...https://skitch.com/jeff.noyes/fpmwh/adobe-fireworks-cs5

3. I believe https://skitch.com/jeff.noyes/fpmwh/adobe-fireworks-cs5 is the solution we should be shooting for. While the iphone selector is cool, it's for the iphone. The jquery counterpart is not friendly at all, nor is it accessible. People understand combo boxes. Comboboxes (select lists) may not be fancy, but people understand them, and using them in this case avoids the usability and performance issues David speaks of.

4. Last, I also think the time interval should be defaulted to 15 minutes. If you are one to create an event down to the 1 minute intervale - you are in the vast minority.

KarenS’s picture

Well the Vega timepicker does not look like https://skitch.com/jeff.noyes/fpmwh/adobe-fireworks-cs5.It does use the same concept (dropdown lists for the time), but it is a single dropdown for the whole time element instead of individual dropdowns for hour, minute, and ampm. Are you suggesting we should get rid of the Vega timepicker and do something different? The Vega dropdown looks pretty similar to what Google calendar uses, which we keep going back to as a model.

I am fine with limiting the dropdown (any dropdown) to something less than 1 minute increments. I originally thought we might go with 5 minute increments, but that is still a mighty long list. Using 15 minute increments is probably going to be plenty most of the time, so long as it can be overridden in the UI.

arlinsandbulte’s picture

FWIW, Here are my thoughts:

  • Noyz's dropdown design (pop-up datepicker + hour/min/sec/am-pm dropdown select list) might be a viable default alternative if no jquery timepicker is installed or enabled. This option may be do-able in standard code without opening that whole GPL can of worms. But, there is no code right now... this requires someone to step up and do the coding.
  • The wvega timepicker is, arguably, the most friendly timepicker. Code is very close to RTBC.
  • The current jquery timepicker is OK, but has some issues. Code is already in Date, but perhaps should be moved to a 3rd party library download to follow d.o policy.
  • IMO, the Google calendar ui is a very good one. It follows established practices and is easy and intuitive to use. Date would do well to mimic Google calendars functionality.

Knowing what we know now, here is my proposal:
1.) Commit ksenzee's / David_Rothstein's patch from #110 (after a bit more testing & tweaking perhaps). It may not be perfect, but it certainly is a great improvement. (Remember, the enemy of the good is the perfect.)
2.) Consider moving the current timepicker to a 3rd party library to comply with policy (this step is debatable).
3.) Develop Noyz's design idea and make that the default timepicker if one of the other options is not available.
4.) Pursue this issue: #388762: Alternative timepickers: Make timepicker pluggable.

Timetable for the above:
I think we could do item 1 above very soon or immediately.
The rest can be followed up later (e.g. lower priority).

David_Rothstein’s picture

Yeah, I think that makes sense. The problem discovered above are not a reason to get rid of the wvega timepicker entirely (it's still very useful in certain cases). And @Noyz's design idea can be a separate issue because it applies when you're not using a JavaScript-based timepicker at all.

I therefore created two spinoff issues now:
#1240628: Change the default value of the increment dropdown to 15 minutes (at least for the popup widget)
#1240636: Alternative timepickers: Use select combo boxes

The first we sort of need for this patch (to avoid the performance problems), but I split it off because it may make sense to switch to a 15 minute default interval more generally.

Otherwise, I think the only thing left to do here is to rewrite the download instructions so that they work? (Adding the wvega timepicker to the code directly and dealing with the GPL issues can be proposed in a followup issue also, because yeah, that one is not going to get resolved quickly..)

frankgelinas’s picture

Hi, if you are still looking for alternatives, i'd like to suggest the jQuery timepicker plugin I wrote.
http://fgelinas.com/code/timepicker
I've wrote it to have a look and feel siilar to the datepicker's and have received many nice feedback for it.
Also the licence is the same as jQuery : Dual licensed under the MIT or GPL Version 2 licenses.

KarenS’s picture

Hi @frankgelinas. I think that looks nice but we are settling on something simpler. I think The Vega timepicker suits the bill, a very simple dropdown that more or less mimics Google Calendar functionality.

There is another issue about making the timepicker pluggable where we might in the future provide for ways to use other timepickers. You can add your timepicker to that list if you like. I have no immediate plans to do that, it's a possible future enhancement.

klonos’s picture

I agree too with David in #115, but since this issue here started as a place to brainstorm and suggest new alternatives, I suggest we either leave it as is (serving that original purpose) and move implementation of the wvega elsewhere (in its own issue) or we change its title to "Alternative timepickers: wvega timepicker" and make it specific. I do lean towards the first though, so that people like Frank in #116 can have a place to suggest their alternatives (here). If someone actually starts implementing an alternative, they can start a new "Alternative timepickers: [name_of_timepicker_goes_here]" issue and post code there. At the same time they announce it by linking to their specific solution/issue here. If you agree, then we need to move the code available for wvega to a new issue. What do you think?

...I wouldn't suggest all the above normally (because I want to see something get implemented ASAP), but I really liked Frank's alternative ;)

@frankgelinas: hey Frank, why don't you start a new "Alternative timepickers: Frank Gelina's timepicker" issue and we can take it there? ...unless you come up with a fancy name for your timepicker of course ("FG timepicker" or "EfGee timepicker" for example). Then change the issue title accordingly ;)

KarenS’s picture

Title: Alternatives to jQuery timepicker » Switch to using Vega timepicker

This issue has all the discussion, and patches. for the Vega timepicker. I don't want to lose it, so I'm not going to create a new issue for that.

If you want to create a new 'Alternatives' discussion feel free, but note that unless the issue about plugable timepickers gets implemented nothing will probably be done with them.

arlinsandbulte’s picture

Issue tags: +alternative timepicker

tagging....

klonos’s picture

Issue tags: -alternative timepicker

Fair enough Karen: #1240874: Alternative timepickers: Frank Gelinas's timepicker

Anyone that has previously suggested an alternative timepicker should create a separate issue for it and update the issue summary in #1240930: Alternatives to jQuery timepicker [meta/list]

klonos’s picture

...sorry for the tag removal. In the meantime I created a similar tag for the issues in #121.

KarenS’s picture

I have to change the instructions. If you go to the github page and just copy the file there to your folder, it won't work. You have to download and unzip, then pick up the enclosed files and rename them.

I can't figure out what is different copying the files, but it won't work.

KarenS’s picture

Status: Needs review » Fixed

OK, I tweaked the instructions and committed this. Thanks everyone! I think all the remaining issues have followup issues so I'm marking this fixed. Let me know if I left something undone.

arlinsandbulte’s picture

Great work Karen!
And ksenzee
And David_Rothstein

klonos’s picture

Thanx Karen and everyone else that help with this one.

David_Rothstein’s picture

Status: Fixed » Needs review
FileSize
1.5 KB

Just fixing a quick typo that was introduced in the committed version of the patch.

arlinsandbulte’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

Should this be re-opened to add a note in the README.txt and/or INSTALL.txt to a) inform the developer of the option to use the WVega timepicker, b) explain where to store it?

gooddesignusa’s picture

I know this issue was changed to 7.x but in case anyone still wants to use the normal drop down select box that mrfelton provided in comment #54 for D6. I re-rolled the patch for 6.x-2.x-dev (2011-Aug-18). I also included the fix from comment #64.

KarenS’s picture

@DamienMcKenna, The note has already been added to the Date Popup README.txt.

@gooddesignusa, this is a closed D7 issue, no one is going to find a D6 patch here. If someone wants to propose a patch for D6 it would be better to create a new issue (no promises about doing anything with it, just saying that is where it belongs). This issue is way too long already to reopen.

billysteffens’s picture

I am a bit of a newbie at patching... I would love to use the jquery.timepickr (http://haineault.com/) version of time picker. I am using a date field with pop up... Does anyone have a patch that will work and directions? I am on Drupal 6.24.

I see that this is a D7 issue... Thorough reading necessary
Thank you,

Billy