Several pages in the project module are blank, as per bug 27344. I have discovered these and created patches for the DRUPAL-4-6 branch of the project module (attached).

CommentFileSizeAuthor
#8 patch-29061_0.txt3.06 KBrgladwell
#6 patch-29050_0.txt2.62 KBrgladwell
#2 patch-29061.txt1.29 KBrgladwell
patch_9.txt1.58 KBrgladwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nelliza’s picture

nelliza CreditAttribution: nelliza commented
Status: Needs review » Needs work

Applied your patch, however some pages are still blank

When trying to delete any status option (admin/settings/project/status/delete/$num = 1,2) I got blank page.

Other than that status optionsseem to be configurable ok.

rgladwell’s picture

rgladwell CreditAttribution: rgladwell commented
FileSize
patch-29061.txt1.29 KB

Ammended to not blank status deletion page (see attached). I suggest you commit the patch and raise seperate bugs for ech blank page found in future.

rgladwell’s picture

rgladwell CreditAttribution: rgladwell commented
Status: Needs work » Needs review

Please review the new patch.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

patches are much more likely to be reviewed if produced against HEAD ...also, this module is not very well maintained so it might take some time. If you are really just fixing bugs, and not adding new functioanlity, you may commit directly after waiting here for some feedback.

rgladwell’s picture

rgladwell CreditAttribution: rgladwell commented

I would happily commit the patches for these bugs but I do not have a committer login. I have applied but have yet to hear back. Please advise what I should do about getting committer access.

rgladwell’s picture

rgladwell CreditAttribution: rgladwell commented
FileSize
patch-29050_0.txt2.62 KB

Updated code style as per IRC chat:

killes_	+ if(!$projects) { <== should have a space before (
killes_	+ } else { <== we write }\nelse {
killes_ + $output = $output." - no releases found."; <== we'd use single quotes, but also the text must be translatable.
rgladwell’s picture

rgladwell CreditAttribution: rgladwell commented

Please ignore the last follow-up: it is for another patch.

rgladwell’s picture

rgladwell CreditAttribution: rgladwell commented
FileSize
patch-29061_0.txt3.06 KB

Updated patch: fixes blank page for release edit screen.

moggy’s picture

moggy CreditAttribution: moggy commented
Status: Needs review » Closed (fixed)

the latest 4.6 download seems to be working fine.