D6 port of Openresort

same question here

regards

What are your plans (time schedule) to port this to D6 & D7 please ?
Do you need assistance with specific language translations,
general documentation and testing on various platforms?
I might be able to help.

+1

+1 Also willing to help.

Subscribing, very much interested in a D6 port.
My site www.trekking-world.com uses Openresort module a lot, I can't port it to D6 without having openresort on D6!
Thanks for considering upgrading openresort to D6!

Greetings,
Martijn

Also interested in this becoming available for D6!

+1 Subscribing

At the moment I don't have the time to support this module. If someone is willing to step forward as a co-maintainer I will be more than willing to give them cvs access.

subscribing

Hi Marc,

It would be great if you only could bring the D5 functionality to D6 please.
I am not asking for extra functionality, just the same functionality in D6 please.

Thanks a lot in advance for considering this!

Greetings,
Martijn
www.trekking-world.com

Hi,

I am in need of Openresort on D6. It is the bottleneck in getting my site to D6.
Other D6 features are so much improved like Views2 and the new Panels 3 that I would very much like to convert my site www.trekking-world.com to D6.

Anyone taking up the task bringing the great Openresort module to D6?
I would very much like to help, but I am not a phpprogrammer. I did work on nodeforum (www.drupal.org/project/nodeforum) and somebody chipped in to get that to D6.

I am willing to pay a small amount also to get this done. Anyone else also is willing to pay?
May be marc will reconsider than bringing this to D6.
Anyone please?

Greetings,
Martijn

Hi,

Isn't any programmer out there who sees the benefits of this great module, and is willing to port it to D6 please?
Thanks a lot for considering this!

Greetings,
Martijn

Hello all,

I am using open resort as a booking script. After much consideration I decided to go with the latest version that is available for download at www.openresort.org. The problem is that it is bundled together with drupal version 5.3 and there seems to be no way to upgrade to any later versions of drupal 5. I tried to upgrade on a test site that I had cloned from my original installation but when I tried to disable some of the open resort modules like unit it completely breaks the site. So in short I am stuck with version 5.3 unless I can find a way to upgrade without breaking the site. Does anyone have any suggestions for me? I would love to upgrade this to version 5.16 but have no idea how to do it. I have tried many times to request support through the openresort.org forum and even through email and have never received a reply. It's a shame that a module with so much potential seems to be totally unsupported. Maybe we can all chip in $100.00 each to try and persuade the developer to continue to support this module. I would be willing to chip in if anyone else is.

The issue is not one of money, it is one of time. As I have said previously I will happily take on a co-maintainer to assist. The main challenge is not in the open resort code itself but in the area of ecommerce support, both options ecommerce 4 or ubercart will require significant rewrites of the cart engine. Both the version of code here and on the open resort site are the same btw.

I'm in! I find OpenResort an excellent module, and I need such a module for a website... So I will be happy to help on this port in exchange of my name in credits for this part (for my portfolio...).
I'm quite busy this month so I'm only 20% available, but since the 25 of april I shall be more available.

cfab thanks for your offer can you send me sample code that you have written for Drupal. I had a look at your d.o profile and noticed that you have committed no patches etc. So i want to see what you can do before we set the wheels in motion to get cvs access. My email is marcingy@gmail.com.

Hi,
And Marc, are you satisfied and moving on with Cfab to build the D6 version of openresort?
For me this module is crucial before migrating my www.trekking-world.com site to D6..
Thanks for the effort in advance!
Greetings,
Martijn

He has no prior drupal experience and given the complexity of the module I'm not currently willing to give him commit access. He however is more than welcome to provide patches to upgrade items to d6.

I'm currently in the process of cleaning up the D5 version for a project I'll launch May 1st 2009. I'll post patches here once I get it stable enough, it'll be easier to port to D6 afterwards i'm sure.

Caktux

Thanks for this and once you have the patches available I'll commit the code. And will then likely be willing to provide cvs access to you.

Marc

It would be so great having openresort on D6. I'll test for you when it is so far. Happy Eastern!
Greetings,
Martijn

Hi,

I'm a total newb and I've been trying to install this module for a while now. It looks as if it would help me with a small site I want to set up.

Does this module rely on a particular version of Drupal? You mention Drupal 5.3 above but the latest version of D5 is 5.17, yes?

Will OpenResort install in D5.17? (I can't do it :-)

Please let me know before I tear all my hair out :-)

TIA !

Simon

Right now my company is considering using openresort with drupal 5 for a new project.

We really need good multilanguage and ecommerce support.
So although I think we would not pay for a complete development effort to port this to drupal 6, its quite likely we would sponsor it.

Hi,
If you are considering a new project. I think going to Drupal 6 would be very advisable instead of Drupal 5! When D7 is out D5 will be only maintenance-updated and some modules already cancelled their support for Drupal 5, see for example: http://drupal.org/node/235105#comment-1658048, and D6 has so much more to offer already.

If in the process you would port openresort to D6 would be absolutely great!
Greetings, Martijn

Hello,

OpenResort would be perfect for a project we are working on if we could get it to work with multilanguage support. We are interested in funding development if the price is reasonable. Could you give us a quote for a port to Drupal 6 and multilanguage support?

Thanks in advance,

Evan

Don't mark it as assigned unless you are going to provide a patch, plus the issue is postponed until such a patch is provided. If you want to discuss sponsorship please contact people off line rather than on this thread.

Hi Marc,
It would be great if a D6 patch would be committed. So Evan, email Marc and try to get this moving!
Greetings, Martijn
www.trekking-world.com

Evan don't email me have no time to work on this see comment #15. The only way this module will get updated at the moment is if some one else steps up and provides a patch. And once again as I said before I'm happy to take patches from anyone and review them and then hopefully give the contributor of those patches co-maintainer status.

subscribe

subscribe.

The D6 port should be ready for beta testing pretty soon. We're moving this to the Reservations module for different reasons, but marcingy and I will be working on getting a few important features back in (since I've stripped out a little too many things...) before doing the first commits / dev releases. You're all welcome to join in the development / testing of this new module :)

I will be more than happy to do testing or any other help. Please let me know. Thanks for initiating.

please don't post replies to #32 in this thread.

subscribing.

Hi, I think it is better to subscribe on issues on: http://www.drupal.org/project/reservations right?
greetings, Martijn

I would be willing to chip and pay a developer to port this module to d6.

I'm starting to build with D6 a complex site (news, how-to articles, forums, banners, classified ads with many sections and a few kinds of ads, bussines directory with different visual options, chat, multi-vendor shopping cart and more).
Some of the tasks will be implemented with external tools because of D6 lacks or too basic features (until I discover the way to do it inside D6).
OpenResort in a D6 embodiment would be a more than blessed tool for me and the Drupal community.
I am not a programmer and cannot help in this way, but if the need of some translation shows up (documentation, user interface, etc) to Spanish or Hebrew don't hesitate in asking me to do it.
SUSCRIBE.

Hi,
I made a paid issue of this..http://drupal.org/node/632894. Nobody responded. Trying myself.

Greetings, Martijn

Hi,
Because of the fact I have a living site www.trekking-world.com on D5 with hundreds of Openresort business nodes and because I like the business ammenities functionality a lot and I waited for a year for somebody to step in, and that I want to upgrade this site to D6, I am trying to port Openresort as is, to D6.

I am a amateurprogrammer, but I have finally eclipse working, and with the help of the community we could succeed in this!

I have some rudimentair working..but walking to walls of starting D6 programming.
If you want the rudimair code, just contact me. If you want to help port the module, please help me with the following problems:

Problem 1

function business_menu() {

	$items = array ();
        $items['admin/settings/business/ammenities/%/edit'] = array(
		'page callback' => 'business_ammenities_admin_edit',
		'page arguments' => array (arg(4)),
                'access arguments' => array('edit own businesses'),
		'type' => MENU_DEFAULT_LOCAL_TASK
	);
	return $items;
}

--------------
function business_ammenities_admin_edit($aid = null) {
	if ($aid) {
		$edit = db_fetch_array(db_query("SELECT * FROM {business_ammenities} WHERE aid = %d", $aid));
		return drupal_get_form('business_ammenities_form', $edit);
	} else {
		return drupal_get_form('business_ammenities_form');
	}
}

Problem 1: I am not able to get the arg(4), which is the ammenities number for example admin/settings/business/ammenities/22/edit to be transported to the business_ammenities_admin_edit function. So the if ($aid) fires up.
What do I do wrong please? It doesn;t see the $aid right now...

Please reply to this issue with a solution, thanks!

Thanks a lot for your assistance
Greetings, Martijn

Problem 2
I can get Short description to show on node teaser, and Long Description on full node display. I can edit them, but not place them in the database.

When pressing Submit the node becomes empty again...

I have to get into FAPI drupal more..

Hi Marc,

Reservations have brought the booking.module online, I think all ecommerce hooks are in this, right? At least I have openresort for 80% working now on D6 without installing drupal ecommerce.
Problems I have now are problems of porting of functionality to D6, see: http://drupal.org/node/290622#comment-2430096 and http://drupal.org/node/290622#comment-2430344. Probably for a senior programmer not big thinks.

Can I send you the D5 ported code with lots of changes, but still openresort flavour, so you can look at it and start the 6.dev tarball on openresort? I am willing to co-maintain until somebody steps forward, I am smart learner, but amateurprogrammer.

Greetings, Martijn

Problem 3 Theming the additional information of the node.

Somehow the theme_node_business function is not triggered..

greetings, Martijn

Problem 3 solved

I have my node theming working, with no change necessary, except to define the theme-output forms in:

function business_theme() {
  return array(
    'node_business' => array(
      'file' => 'business.module',
      'arguments' => array(
        'node' => NULL,
        'teaser' => 0,
        'page' => 0,
      ),
    ),
   'business_view' => array(
      'file' => 'business.module',
      'arguments' => array(
        'node' => NULL,
        'teaser' => 0,
        'page' => 0,
      ),
    ),       
    'business_collection' => array(
      'file' => 'business.module',
      'arguments' => array(
        'vid' => null,
        'tid' => null,
      ),
    ),
  );
}

Problem 1 and 2 still there..
Greetings,
Martijn

Analysing problem 1
Problem 1 not solved: http://drupal.org/node/290622#comment-2430096

Problem is: I am not able to get the arg(4), which is the ammenities number for example:
admin/settings/business/ammenities/22/edit
to be transported to the business_ammenities_admin_edit function. So the if ($aid) fires up.
What do I do wrong please? It doesn;t see the $aid right now...
Please reply to this issue with a solution, thanks!

Analysing leads to http://drupal.org/node/250645#comment-1009048 may be it is the order of things what's wrong in the initial code for D6.
And setting &$form_state?: http://drupal.org/node/250645#comment-1009048

Nicely writeup using % in menu items: http://drupal.org/node/146172#comment-947636

Agggghh..now database saving of node is not working anymore..will look into that tomorrow.

Thinking of using like: http://drupal.be/forum/registration-form-veranderen-met-hookformalter (in dutch)

function business_form_alter ($form, &$formstate)
  $form['#submit'][] = 'business_form_validate';

['#submit'][] to not reject other modules, see: http://drupal.org/node/302504
The name of business_form_alter is theoretical. First I have to look in the code tonight, see: http://drupal.org/node/368257#comment-1235956 and http://drupal.org/node/290462

To get the business node form arising, I had to add

module_load_include('inc', 'node', 'node.pages');

As explained here: http://drupal.org/node/464906 and http://thedrupalblog.com/programmatically-create-any-node-type-using-dru..., but now after Submit a empty form arises..
Without the module_load_include I got the error:

call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'node_form' was given in /htdocs/includes/form.inc in line 358.

But I do not know where to exactly place this, and what the further consequences are?
EDIT: It has to be called on top of function as first line.

Hello, Martijn!
Well, I don't want to sound rude, but have you seen this: http://drupal.org/project/uc_hotel

Maybe it will be a better solution, especially on the long term.

Warm regards from sunny México!
:-)
Pepe

UC_Booking rocks. But maybe open resort can do something different. Not sure but I would like to know.

Analysing problem 2
If I am getting it fixed...now struggling with Submit/Save button and getting values to save correct...

I think problem 2 and database INSERT have same root of problem.

This looks like a page with valuable information: http://kristiannissen.wordpress.com/2009/10/26/drupal-6-and-hook_form_fo...

I think it has to do with correctly naming the functions according to FAPI drupal 6 standards, see for example also problems on: http://drupal.org/node/135384#comment-270742
The naming must be correct (see http://drupal.org/node/637500#comment-2288592 and http://drupal.org/node/573566#comment-2026632):
- function modulename_form_ formid_alter () { .. } or
- function modulename_form_formname_node_alter () { .. } (then formname_node is the form id for the node page)
- function modulename_form () { .. }

and business node/add/business in hook_menu_alter like:

function business_menu_alter(&$callbacks) {
  $callbacks['node/add/business']['page callback'] = 'business_add';
  $callbacks['node/add/business']['access arguments'] = array('create businesses');
}

And will try adding drupal_render($form); as explained on http://www.ubercart.org/forum/development/3949/after_theme_form_tapir_dr...

Solved problem 2, I think
I solved problem to of saving by adding the following function:

function business_form_alter($form,  &$formstate) {
  $form['#submit'][] = 'business_validate';
}

Is it correct to call nodetype_validate on the Submit?

Solved problem 1, I think
I solved problem 1 by using arg in the target function:

function business_ammenities_admin_edit($aid = null) {
    if (arg(4)) {
        $aid = arg(4);
        $edit = db_fetch_array(db_query("SELECT * FROM {business_ammenities} WHERE aid = %d", $aid));
        return drupal_get_form('business_ammenities_form', $edit);
    } else {
        return drupal_get_form('business_ammenities_form');
    }
}

Problem 4
I am trying to solve the form_state way in Drupal 6.
The old function is:

function business_ammenities_form_validate(&$form_state, $form ) {
    $count = 0;
    while ($akey = key($form_state['values']['ammenities'])) {
        if ($form_state['values']['ammenities'][$akey] == true) {
            $count++;
        }
        next($form_state['values']['ammenities']);
    }
    if ($count == 0) {
        form_set_error('ammenities', t('Please select a business type for this ammenity'));
    }
}

Anyone knows how I can change this for drupal 6? These pages are a little bit helpfull but not a correct example to move from:
http://pingvision.com/blog/ben-jeavons/2009/multi-step-forms-drupal-6-us... , http://drupal.org/node/144132, http://www.pre-emptive.net/doco/form-field-validation-drupal-6

Solved Problem 4
Hi, starting becoming real programmer..this thread becomes a complete talk to myself..anyway. I dived into $form_state stuff, and it is very powerfull, but difficult.
This altered function worked for me. I needed to change 'values' to '#post'. And this info became visible through the print_r command. Now I have to alter through code

$form_state['values']['field']

to:

$form_state['#post']['field']

function business_ammenities_form_validate(&$form_state, $form ) {
    $count = 0;
    //This function is sometimes called from the edit form without ammenities
    if (!empty($form_state['#post']['ammenities'])) {
     //drupal_set_message('<pre>'. print_r(&$form_state, TRUE) .'</pre>');   
      while ($akey = key($form_state['#post']['ammenities'])) {
          if ($form_state['#post']['ammenities'][$akey] == true) {
              $count++;
          }
          next($form_state['#post']['ammenities']);
      }
      
   }
   if ($count == 0) {
   form_set_error('ammenities', t('Please select a business type for this ammenity'));
   }
}   

This is a nice flowchart to see what happens with forms/validate etc..:http://www.flickr.com/photos/thecancerus/2394730671/sizes/o/

Problem 5

Problem 5 is a problem of redirecting. I am not able to get the ammenities redirected to the list page. This is current code:

function business_ammenities_form_submit(&$form_state, $form ) {
    switch (business_ammenities_form_save($form_state)) {
        case SAVED_NEW :
            drupal_set_message(t('Ammenity added'));
            break;
        case SAVED_UPDATED :
            drupal_set_message(t('Ammenity updated'));
            break;
        case SAVED_DELETED :
            drupal_set_message(t('Ammenity deleted'));
            break;
    }
    $form_state['redirect'] = 'admin/settings/business/ammenities';
}

But on none of the cases the redirect gots fired up :(

Hi, Problem 5 is minor problem. I think I solved my needed functionality now for 99%.
Business nodetypes and ammenities.
Greetings, Martijn

Kudos on learning some advanced drupal programming.
But I would seriously consider trying an ubercart based solution instead as openresort is pretty much drifting away from relevance.
It might be worth it to see what openresort features are missing from uc_hotel and begin building into that.
I have one working openresort for d5, and getting that to work for an English site was a major undertaking.

Hi,

For me on D6, I have the module working for ammenities and business nodetypes of my choice.
I set it to active again Marc, to get it working further by the community, ok? When finished we will make a patch then. Then a D6 branch can be made.

I post here my D6 openresort module until now. There are 2 basic modules changed:
- business.module and skiresort.module. You also need the reservations module enabled, because in this module the ecommerce hooks are inserted on D6. I did not test these hooks, because for my functionality from openresort I didn't needed them.

If you want also to develop on the module, I can give you more details. I do not have time anymore to develop myself, other projects are needing my time now.

These I have 99% working on D6.

Please reply with improvements please.
Greetings,
Martijn

@Summit you now have csv commit access. I won't be reviewing this patch nor will I be committing any patches for D6 as I no longer use the module at all but you are more than welcome to start building out a release for d6 :)

Hi Marc, Thanks! Will do when community works on and reviews the D6 port.
Greetings, Martijn

Project is dead