Simplenews ignores paragraphes on some installations

Found the problem!

I've got a meeting right now and don't have time to explain things thoroughly or roll a patch. Suffice it to say that check_markup() is being called twice because node_prepare() is being called twice and deleting the line

        $node = node_prepare($node);

from simplenews_mail() solves the problem.

Okay, that meeting was shorter than expected. Here's the entirely unexciting patch, rolled against the latest dev release.

I think calling node_prepare is fully valid. Plain text email should have this called.

It's being called twice, though. First by node_build_content(), and then again directly.

Agree, the problem is clear. But it is only called twice when simplenews and mimemail work together. When simplenews is used without mime mail is still needs node_prepare(). The next question is where is the right place to solve this. I am still not sure why mime mail needs to filter the email content.

I don't see anything which is causing either node_build_content() or node_prepare() to only be called when Mime Mail is installed, though. This bug is totally independent of Mime Mail's presence.

It seems everything works fine if I send HTML. When sending PLAIN, linebreaks are not present, so everything seems to be one big paragraph...

I have Simplenews 6.x-1.x-dev version from 2008-Sep-02 with above patch #3 and simplenews-mimemail.patch (issue Restore Mime Mail support in D6 / #3) applied

Mimemail itself is the mimemail-6.x-0.9.tar_.gz version (issue Upgrade Mime Mail to Drupal 6 / #102), with a mimemail-no-alter.patch (issue Upgrade Mime Mail to Drupal 6 / #125) applied.

I have the impression there is a quite big confusion with versions and patches applied to them - so we have many times more or less different code installed, but discuss about the same... It would be nice to have both Simplenews as well as Mime Mail (at least alpha-x) versions available, to be able to refer to some particular version when describing some issue (as above)...

My latest patch for Simplenews should fix the problem with line endings being clobbered in plain text versions of messages being sent with Mime Mail. thomas, if this is happening without Mime Mail, sorry, but I'm not going to be the one to fix it.

I finally had the time to test this and now I understand the fault. In simplenews_mail() check_markup() is first called by node_build_content() and next by node_prepare(). But that's what Garret said all the time ;)
Patch committed. Thanks!