Restore Mime Mail support in D6

This patch fully bypasses simplenews_mail() which is not good. Newsletter title and unsubscribe messages will be removed and outgoing messages not cached.

The mime mail version you mention in the original text does not call drupal_mail().
Read the code of drupal_mail() to see how it works. It is substantially different from D5.
An other important thing you overlooked is that your patch does not use the Simplenews mail spooler and the patch does not work properly with cron.

I've tested the above #3 patch (simplenews-mimemail_1.patch), applied to the September 2nd dev version. It seems to work good (tested just sending a test message, not more up to now...) - message seems to be properly formatted (HTML), while there is no need to have mimemail option to process all messages selected anymore (as before, without that patch).

subscribe

a little help here ... how do you apply the patch ... I found simplenews.module ... but how do I replace and what?

@Garret: sorry, I misread the patch. Your approach is the right one.
Some minor remarks:
* Should non-HTML newsletters go through mimemail or not? Perhaps for the sake of SMTP compatibility.
* Don't use the 'Test newsletter sent via Mime Mial ...' message but use the 'Test newsletter sent to ...' message instead. We don't want to bother the average user with the techy 'via Mime Mial' info.

Thanks for the work, and sorry for the confusion.

@madaerodog: see http://drupal.org/patch for all information on patching.

Hello

I have two major problems with this Mimemail version.
Firstable, I send two newsletters and one of its don't working correctly but the other is perfect.
And my second bug is a problem about spam. When I received a mail sent by simplenews. Thundirbird reconize it as a spam and I don't know how I can fix it.

Thanks in advance

Thanks for your answer. Now it's working perfectly. But mimemail send 2 mail one in HTML and one in plain text. So everybody receveid 2 mails. How can I do to resolve this problem?

I've been able to get the patch in the preceding comment working correctly for HTML mails in the test send scenario. However, for the bulk send scenario the sent emails have a subject prefix of "[Unassigned newsletter]". On debugging simplenews_mail() I found around line 1449 code of the form $tid = $node->simplenews['tid'] but in this case $node->simplenews had value false i.e. was not initialised. Basically, it can't determine the taxonomy (which is correct in the database AFAICS). Any clues to what's going on?

There's a minor change required round about line 1618 when simplenews_debug is enabled. There's a call to watchdog() where it's calling the t() function for the error message argument. This is not correct and results in a PHP error when the log entry is viewed in the View Recent Entries log report. There is another call to watchdog() seven lines later which has the correct code. In summary:

change:

watchdog('simplenews', t('Outgoing email via Mime Mail. Message type: %type<br />Subject: %subject<br />Recipient: %to', array('%type' => 'node', '%to' => $message['to'], '%subject' => $message['subject'])), WATCHDOG_DEBUG);

to

watchdog('simplenews', 'Outgoing email via Mime Mail. Message type: %type<br />Subject: %subject<br />Recipient: %to', array('%type' => 'node', '%to' => $message['to'], '%subject' => $message['subject']), WATCHDOG_DEBUG);

Garrett, I didn't change anything on the user interface other than select a different radio button for the send option. The newsletter category was assigned and appeared fine on the screen, and as I say it worked correctly when in test send mode, it just didn't work properly in live send mode.

FWIW, I also had to select the 'html' option in the send panel both times, as this doesn't seem to be a persistent setting (is this deliberate to always revert to 'plain').

Garrett, have faith ;) I follow your patches closely and will commit when I have the time to go through then in detail. However you making things more complicated now by mixing this issue with #308721. There are several differences between #14 and #19 patch, please keep your patches clean. What is the purpose of $node->is_mail = TRUE;?

If you want to keep these issues separate (as I would recommend) than please do not mix them as you did in #19.

I have considered creating a hook call (e.g. hook_simplenews_mail_alter() ) in simplenews_mail() enabling other modules to alter the content of the outgoing email. Perhaps that could be of help to you. Or perhaps you can use the hook_mail_alter() to do the same.

Having updated the HEAD + #19, things are looking good so many thanks to all involved.

One relatively minor point for consideration: in theme_simplenews_newsletter_body() at around line 2174 in patched simplenews.module, we find the line:

$output = '<h2>'. $title ."</h2>\n";

My html emails have a special graphics banner header, and having the title text stuck on the front interferes with it so I've had to comment this line out. I don't really think the title should be added, the user should have full control of the content via the Edit form in my view.

An acceptable workaround if you insist on adding the title is that the h2 tag should have a class="newsletter-title" or suchlike (not a tag as this could not necessarily be unique if two newsletter teasers were displayed on the same page). Given a distinct class specifier, I should be able to hide it with CSS display:none.

Another option would be to allow the body effectively to be a template, and say substitute the $title where some magic string like {title} appeared in the body text.

This is not about restoring mime mail support. Please create a different issue.
Regarding your subject, please read the handbook on theming.

@Garret: I started working off #14.
Can you explain why you use the code below in calling mimemail().

$plain ? $message['body'] : simplenews_html_to_text($message['body']),

When the newsletter format is 'plain' simplenews_mail() already takes care of formatting the body as plain text. Why do it again here?

Attached patch is committed to HEAD. It will be rolled back onto 6.x when the related code of mime mail is stable enough. I want to keep ordinary users from running into compatibility problems between the two modules. With your help I will keep Simplenews HEAD compatible with Mime Mail HEAD. Thanks so far!

I found one small mistake in patch 26. The 7th argument given when calling mimemail (arround line 1380) contains html, it should be plaintext or empty. If empty mimemail generates the plaintext itself from the html body given as 4th arg.

This results in having html tags in the plain text part of the email.

I've not much experience in making patches , so if someone else can correct this..

I racked my brain to understand why i was not able to send plaintext mail and finally i found this closed issue.
In the current 6.x release the mistake pointed out in #26 can be considered a bug because it prevents html tags to be cleaned in the plaintext format.
I did not tested if HEAD works also without it, so i attached only the fix for 6.x

Thanks.
Committed to 6.x-1.x-dev and HEAD

After further inspection i have to say that #25 is right but #26 does not work because of a mimemail bug: #319562: Multi-part message in MIME format wrong plain text format (don't know why it was closed).
So with #26 the bug happens only when the simplenews html format option is selected.

sorry, wrong assumption: mimemail needs the plaintext content as parameter for multipart mail.
Forget my previous comment.