Closed (fixed)
Project:
Simplenews
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Sep 2008 at 22:58 UTC
Updated:
22 Jan 2010 at 08:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
niklp commentedI'm not absolutely certain, but I think the point of "_actions" module extensions is to make triggers available TO the actions bit. So, really, all this extension module does is provide the triggers. You have to write the actions yourself (although I would hope that you can add advanced ones manually also, but not sure).
Comment #2
sutharsan commentedNikLP is right in his explanation. Simplenews provides you with actions and triggers. You have to add actions to the triggers yourselves. That's part of the flexibility actions and triggers provide.
Comment #3
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #4
duntuk commentedi just checked this out with the latest build of simplenews, and can confirm the there are no available actions, or ways of making trigers for the newsletter module.
e.g.
There should be a way to notify the admin that a user has subscribed to the newsletter--the email should be able to show the subscriber's email (and other user info if available) .... <-- there's currently no way i see of doing this.
Comment #5
sutharsan commentedYou need to write code for actions to act upon simplenews triggers.
Comment #6
sutharsan commentedNo activity. Closing the issue.
Comment #7
nicorac commented@Sutharsan: Sorry, but I can't get the point...
Using 6.x-1.0-rc6.
If I open page admin/build/trigger/simplenews, I see two boxes:
- Trigger: After a user has been subscribed
- Trigger: After a user has been unsubscribed
both of them show:
No available actions for this trigger.
Aren't these supposed to contain a dropdown list with, at least, system actions like "send an email"?
If I'm wrong, could you please explain what you mean in #5 ?
Thanks
Claudio
Comment #8
donquixote commentedsubscribing.
A typical action one would like to fire is notification emails for the list manager.
1) Subscription notification? - redundant because of
2) Notify Admin of Subscribe/Unsubscribe (for a short time the title was "Port to Drupal 5")
Comment #9
joachim commentedWe need to tell core actions that they may apply to simplenews triggers:
Add the above code to the module and user actions become available.
I've just tested this by blocking a user when they unsubscribe.
I expect other system actions can be enabled here too -- not sure which ones are relevant.
Comment #10
pcorbett commentedThis should totally be committed. It's kinda silly to include actions support, but then not be able to use it :)
Is there a reason why this is restricted to $action['type'] == 'user' ?? I commented out the IF statement and am successfully using the "Redirect URL" action once a user has subscribed to a newsletter (trigger).
Comment #11
joachim commentedNot every single action type will be relevant, because it might not have a user to operate on.
So $action['type'] could be 'user' OR some other things... I don't know enough about actions to say.
Comment #12
Anonymous (not verified) commentedI actually achieved this using the Trigger Unlock module - http://drupal.org/project/triggerunlock
You can then set up an action (i.e. Send email...) and the Trigger Unlock module allows you to assign any Action to any Trigger. So on Home » Administer » Site building » Triggers, instead of "No available actions for this trigger." you will be able to assign any action to the 'Subscribe' or 'Unsubscribe' Trigger.
Comment #13
Joel MMCC commentedHow about supporting the Rules module, which is a much more powerful replacement for the Triggers Module? At present, I cannot install Simplenews_actions without enabling Trigger, even though I have Rules enabled and it’s an upwardly API-compatible drop-in replacement for Trigger, and both cannot be enabled at the same time without causing problems.
Should this be a separate Issue?
Comment #14
joachim commented@Joel MMCC: I'm not a maintainer, but I would say yes, file a new issue for Rules support.
Comment #15
sutharsan commentedPlease supply a patch for Rules support (and I am the maintainer ;) )
Comment #16
sutharsan commentedI've committed #9 code by joachim. I've also added pcorbett's suggestion and included the 'system' type actions. It will be available in the next to 6.x-2.x-dev release.
Comment #17
sutharsan commentedFor the record...