There is no easy way that I have found to notify admins of users subscribing or unsubscribing. It seems that this could be fairly easily undertaken as an action (i.e. provide 'Email Admin' action on subscribe/unsubscribe triggers) or as an option in the simplenews configuration. However it is implemented, I think this is an important aspect that is needed in this module.

CommentFileSizeAuthor
#36 simplenews_action_send_email.patch2.22 KBcallison
#36 simplenews_send_email.patch.patch1.01 KBcallison
#27 simplenews_action_send_email.patch898 bytescallison
#26 simplenews_send-email-on-(un)subscription.patch623 bytescallison
#20 simplenews-notify_admin-of-subscribe-unsubscribe_1.patch8.87 KBcallison
#16 simplenews-notify_admin-of-subscribe-unsubscribe.patch8.73 KBcallison
#14 simplenews-notify_admin-of-subscribe-unsubscribe.patch7.27 KBcallison
#13 simplenews-notify_admin-of-subscribe-unsubscribe.patch6.67 KBthepanz
#11 simplenews_send_email_action.patch3.16 KBcallison
#10 simplenews_edited.zip20.79 KBthepanz
#7 simplenews_action_send_email_action.patch3.4 KBcallison
#6 simplenews_send_email_action.patch2.84 KBcallison
#6 simplenews_action_send_email_action.patch2.76 KBcallison

Comments

sutharsan’s picture

sutharsan commented

What is there at Simplenews triggers is a very basic implementation. I can't remember to what extend it has been tested.
What you describe is very usefull functionality and is exactly where actions and triggers are for. It probably needs some code to get it working. Patches are welcome.

callison’s picture

callison commented

I'm working on a patch for this, but I'm having just a little bit of trouble.

I've got a new action defined and I added a case in the simplenews_mail() function to handle mailing to the recipient admin. My trouble, though, is figuring out how I get the tid of the newsletter that was just subscribed/unsubscribed to/from.

I know that the account data is passed into the action function I created, and there is an array $context['account']->tids, but the index of that array is the tid itself, which I don't know. So, how do I get the tid to reference the $context['account']->tids in the first place?

Here is the action function I wrote:

function simplenews_send_email_action($object, $context) {
  $account = $context['account'];

  //This will get the first tid from $account->tids but that assumes the user is only subscribed to one newsletter
  //Also, this will only work if the user is unsubscribing - I don't know where to get the tid (of the current newsletter) when the user first subscribes
  // The account array has a list of tids the user is subscribes to but which one is the 'current' one?
  foreach( $account->tids as $tid ) {
    if( !isset( $my_tid ) ) {
      $my_tid = $tid;
    }
  }


  $params['from'] = _simplenews_set_from();
  $params['context']['account'] = $account;
  $params['newsletter'] = taxonomy_get_term( $my_tid );

  drupal_mail('simplenews', 'action_send_email', $context['recipient'], $account->language, $params, $params['from']['address']);
}

And here is the case in simplenews_mail():

    case 'action_send_email':
      $account = $context['account'];
      $newsletter = $params['newsletter'];
      $message['headers']['From'] = $params['from']['formatted'];

      if (!simplenews_user_is_subscribed($account->mail, $params['newsletter']->tid)) {
        $subject = 'User subcribed to ' . $newsletter->name . ' newsletter';
        $body = $account->mail . ' just subscribed to ' . $newsletter->name;
      }
      else {
        $subject = 'User unsubscribed from ' . $newsletter->name . ' newsletter';
        $body = $account->mail . ' just unsubscribed from ' . $newsletter->name;
      }
      $message['subject'] = $subject;
      $message['body'] = $body;
      break;

I fee like there is an easy way to do this, but I sure can't figure it out. Any help would be appreciated. Many thanks.

sutharsan’s picture

sutharsan commented

The tid sould come in into the action via the context or object, depending on which trigger you use. I guess the object if you use the subscription trigger.

Note: If you are planning to make a patch, make sure you follow drupal coding standards.

callison’s picture

callison commented

Actually, I don't think the tid of the newsletter being subscribed to (or unsubscribed from) is passed in through either of those variables. If a user is already subscribed to any newsletter at the time of the subscription, an array of all the tids the user is subscribed to is passed in through $object but not the current one. Does that make sense?

I'm wondering if we could add a variable to the $context array in the simplenews_call_actions function. The current function looks like this:

function simplenews_call_actions($op, $subscription) {
  // Only call actions when the simplenews_action module is enabled.
  if (!module_exists('simplenews_action')) {
    return;
  }
  $aids = _trigger_get_hook_aids('simplenews', $op);
  $context = array(
    'hook' => 'simplenews',
    'op' => $op,
    'account' => $subscription,
  );
  foreach ($aids as $aid => $action_info) {
    actions_do($aid, $subscription, $context);
  }
}

Could we change it like this to include the $tid

function simplenews_call_actions($op, $subscription, $tid) {
  // Only call actions when the simplenews_action module is enabled.
  if (!module_exists('simplenews_action')) {
    return;
  }
  $aids = _trigger_get_hook_aids('simplenews', $op);
  $context = array(
    'hook' => 'simplenews',
    'op' => $op,
    'account' => $subscription,
    'tid' => $tid,
  );
  foreach ($aids as $aid => $action_info) {
    actions_do($aid, $subscription, $context);
  }
}
sutharsan’s picture

sutharsan commented

It has been some time since I worked on simplenews_actions module. Feel free to write the required code and post a patch here.

callison’s picture

callison commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new simplenews_action_send_email_action.patch2.76 KB
new simplenews_send_email_action.patch2.84 KB

I have attached two patches, one for simplenews.module and one for simplenews_action.module.

Here are the changes I made to simplenews.module:

  • Added 3rd parameter $tid to simplenews_call_actions() function and calls
  • Added 'tid' variable to return array $context in simplenews_call_actions()
  • Added case 'action_send_email' in simplenews_mail() function

Here are the changes I made to simplenews.module:

  • Created a configurable action
callison’s picture

callison commented
StatusFileSize
new simplenews_action_send_email_action.patch3.4 KB

I updated simplenews_action.module so that you can choose which newsletters you want to be notified about.

thepanz’s picture

thepanz commented

I edited your simplenews.module patch adding some t() calls and some text adjustments. For latest 6.x-1.x-dev.
How can we merge our edits?

Regards

callison’s picture

callison commented

Thanks for your review. How about you just upload your revised patch or send me the changes and I'll do it.

thepanz’s picture

thepanz commented
StatusFileSize
new simplenews_edited.zip20.79 KB

I'm behind a Firewall now, I attach my simplenews module. you can view my edits using a diff SW.
Regards

callison’s picture

callison commented
StatusFileSize
new simplenews_send_email_action.patch3.16 KB

Thanks. I have made the changes and posted the updated patch.

thepanz’s picture

thepanz commented

Maybe you should also add a t() call in 

      //Anonymous users need a name
     if (!$user->uid) {
        $user->name = 'Anonymous User'; // should be t('Anonymous User');  or I'm wrong?
thepanz’s picture

thepanz commented
StatusFileSize
new simplenews-notify_admin-of-subscribe-unsubscribe.patch6.67 KB

I re-rolled to 6.x-1.x-dev CVS version and edited (again) your patches:
- Changed Action name (more clear)
- Added t() to "Anonymous User"

All the edits are working fine and notify eMails are sent Ok.

Regards

callison’s picture

callison commented
StatusFileSize
new simplenews-notify_admin-of-subscribe-unsubscribe.patch7.27 KB

Looks good. Thanks for your changes.

I added a feature to allow entering a username as a recipient (with autocomplete).

I also fixed the logic for determing if this is a subscription or UNsubscription. The original if statement used simplenews_user_subscribed() which failed if the user used the "Subscribe/Unsubscribe" button on the simplenews block. I changed it to look at the $_POST['op'] variable which, I believe, is very consistent.

Lastly, I made the multiple newsletter select (in the action configuration form) a required field.

Thanks for your help!

sutharsan’s picture

sutharsan commented

Thanks for the code so far!

The content of the email should be more flexible. Themable at least, or perhaps better like 'Send e-mail' trigger does it with a webform. The latter should than have a way of inserting the newsletter name, tid, etc. into it.

Can the (un)subscribe action be modified so 'Send e-mail' and other actions can use it?

The patch contains code style errors. Please use Coder Module to check.

callison’s picture

callison commented
StatusFileSize
new simplenews-notify_admin-of-subscribe-unsubscribe.patch8.73 KB

This is fun! I've never submitted code to Drupal before.

I updated the action configuration to include a Message Settings fieldset where there is a subject, message, and checkbox (to include link for user's account page).

I allowed for a %status ('Subscribe' or 'Unsubscribe') variable within the subject and/or body fields. This allows people to use the same subject and message for both subscriptions and unsubscriptions. For example, the subject could be [%newsletter] %status Notification which makes the subject [Newsletter Name] Subcribe Notification. Also, the message could contain Someone has %statusd which becomes Someone has Subscribed. After playing around (making separate subscribe/unsubscribe message settings, etc.) this seemed to be the best way to proceed. Any thoughts would be appreciated.

These changes checked out fine in the Coder Module. I did, however, notice some style errors (and even a potential SQL security issue) in simplenews.module not related to these changes.

Sutharsan, I wasn't sure what you meant by modifying the action so 'Send e-mail' can use it? Would you please describe how that could be done and what the purpose would be. Thanks.

thepanz’s picture

thepanz commented

Hi Callison, well done! You know.. OpenSource projects can be fun if you contribute (.. and if the community is responsive) ;)

I'm wondering if a multiple-receivers feature should be implemented.. and if receivers can/must be registered user (selection with auto-complete field?)

Another question is: is the sent message translatable? I can't find any Drupal suggestion about user-input translation..

Regards

callison’s picture

callison commented
Assigned: Unassigned » callison

Thanks!

As far as multiple receivers go, this should probably not be a feature of this patch because users can add as many actions as they want defining who to send notifications to. However, that said, it could be really useful to be able to, for example, notify all moderators when someone subscribes (and enable that with one action). I'm up for suggestions on if and how this could be implemented. I already have the auto-complete functionality for a single recipient. I would have to think about how to best implement that with multiple recipients. Again...suggestions.

I don't know about translatability (is that a word?). Doesn't drupal_mail() automatically translate the message into the recipient's default language?

I appreciate your help and suggestions. Thanks.

sutharsan’s picture

sutharsan commented

I suggested to investigate the possibility of using the 'send email' because I'd rather see smart use of existing tools than introducing new ones. Currently the 'send email' action can not be triggered by (un)subscription because this trigger is defined to only trigger 'simplenews' actions. Either the trigger definition must be altered or the action definition must be extended (if possible). Next step would be to get the (un)subscription and newsletter status/tid/name into the email.

Code style errors: spaces after/before opening/closing parenthesis and escaped quotes in t-string.

$user = user_load( $account->uid );
...
t('Include a link to this user\'s account page if they are registered at this site'),

The body of the email should at least be themable or better editable by the action admin as the drupal core action 'send email' does.

I would discourage the option to send the email to multiple recipients. This notification email is usefull if you have a small or medium size list. A large list has zillions of (un)subscriptions; individual notifications would drive me mad. This notification is i.m.o. only an intermediate solution to a better subscription management system with proper listings of (un)subscribers on date, name, address, source, etc.

callison’s picture

callison commented
StatusFileSize
new simplenews-notify_admin-of-subscribe-unsubscribe_1.patch8.87 KB

@sutharsan: Isn't the only way to edit a trigger definition in system.module itself (i.e. add 'simplenews' => array('subscribe', 'unsubscribe'), to the trigger definition) or is there a way to extend that in simplenews_action.module? I'm kind of new to this, so I don't understand what you mean by extending the action definition in a way that will be triggered by a system trigger ('send e-mail'). If you get a chance, please expound on this a little more.

In the meantime, I re-rolled the patch fixing the code style errors you mentioned. If I'm understanding you correctly, the body of the email already is editable by the action admin (including the all of the token variables I mentioned above - plus an additional %to_from token in this re-rolled patch). Thanks.

sutharsan’s picture

sutharsan commented
Status: Needs review » Needs work

The (un)subscribe trigger definition (simplenews_hook_info) defines what kind of actions can be triggered. Currently only 'simplenews' actions can be triggered. Perhaps this can be extended with 'user' actions.

The body of the email is currently only editable by using the localization. This is not sufficient. All drupal output must be themable. Also consider editable output as the 'send email' action uses.

George_Smith’s picture

George_Smith commented

I tried to apply this patch to the latest release (1.0-rc4), and I get this text after the "Hunk #5 succeeded" line:
patching file simplenews_action.module
patch unexpectedly ends in middle of line
Hunk #2 succeeded at 304 with fuzz 1.

Does that mean that the patch applied successfully, or not? Sorry, this is my first time applying a patch, and I would have trouble believing that "unexpectedly ends" means that it was a success.

Thanks for the help. I'd really like to get the Notify Admin feature working!

quinti’s picture

quinti commented
Title: Notify Admin of Subscribe/Unsubscribe » Port to drupal 5x

How i can port these patches to drupal 5x, or, well

waht's more simple?, update dru 5x to 6, or port this patch to 5?

thank's

donquixote’s picture

donquixote commented
Title: Port to drupal 5x » Notify Admin of Subscribe/Unsubscribe

With the title changed, people will have a hard time finding the valuable discussions in this thread.
I therefore restore the old title.

CMatters’s picture

CMatters commented

subscribe

callison’s picture

callison commented
StatusFileSize
new simplenews_send-email-on-(un)subscription.patch623 bytes

I am posting a patch to system.module that will allow the send e-mail action to be used for Simplenews triggers. Following is a quick step-by-step guide to creating your actions and triggers for alerting admins on (un)subscriptions:

Naturally, this assumes you already have simplenews and simplenews_actions modules installed and working and that you have applied this patch to system.module

  1. On the Actions page, click the drop-down list at the bottom to see the advanced actions and choose 'Send e-mail'
  2. Set up your message (I would advise doing 2 of these - one for subscriptions and one for unsubscriptions) (Also, you can define as many of these actions as you like to notify more than one person)
  3. Now, on the Triggers page, you simply click the Simplenews tab and choose the appropriate actions that you just created for the subscribe and unsubscribe triggers

Hopefully this makes sense. This is good because it's so simple, but I think it could be better if you could choose the newsletter that you want to be notified of, include more variables specific to simplenews in the message, etc. I'll work on it some more - any ideas, comments, and suggestions are very welcome.

callison’s picture

callison commented
StatusFileSize
new simplenews_action_send_email.patch898 bytes

I should have known better than to hack the system module. There's a hook for altering the action. So...I have now used that and applied it to simplenews_action.module. Much better! The above guidelines still work, just don't apply that patch, use THIS ONE.

This could still be better by adding tokens, etc. so I'm looking into it and will post more later.

Jackinloadup’s picture

Jackinloadup commented

subscribe

edsko’s picture

edsko commented

subscribe

Anonymous’s picture

Anonymous (not verified) commented

I actually achieved this using the Trigger Unlock module - http://drupal.org/project/triggerunlock

You can then set up an action (i.e. Send email...) and the Trigger Unlock module allows you to assign any Action to any Trigger. So on Home » Administer » Site building » Triggers, instead of "No available actions for this trigger." you will be able to assign any action to the 'Subscribe' or 'Unsubscribe' Trigger.

portulaca’s picture

portulaca
she/her
commented

Thank you for the tip, I also tried Triggerunlock and it works.

I used Tokenized email option, of all I tested only Global tokens work (FYI).

aschiwi’s picture

aschiwi commented

Well with triggerunlock you can assign any action to any trigger but there are only two actions - "A user has been subscribed" and "A user has been unsubscribed". Almost sufficient if you only have one newsletter. Also there are no tokens for the email address that signed up (anonymous user), so I don't know who subscribed or unsubscribed and I don't know what he or she subscribed to.

I would really prefer the patch, which by the way I could not get to work. What I tried was to patch simplenews.module with the patch in http://drupal.org/node/345579#comment-1164859. I patched both 6.x-1.x-dev and 6.x-1.0, both with pretty much the same result:

 patch < simplenews-notify_admin-of-subscribe-unsubscribe_1_0.patch

(Stripping trailing CRs from patch.)
patching file simplenews.module
Hunk #1 succeeded at 1020 (offset 12 lines).
Hunk #2 succeeded at 1069 (offset 12 lines).
patch: **** malformed patch at line 68:    // Debug message to check for outgoing emails messages.

Was I supposed to do something else?

callison’s picture

callison commented

@aschiwi: The patch is offset by a bit (12 lines apparently). You can manually make the changes yourself - you'd have to go in and find the line number and then offset 12 lines and add the code, but I wouldn't recommend it because it is really a much better way to use the actions method. I'm working now on getting tokenization integrated into my previous patch to allow tokens for describing who subscribed or unsubscribed and what he or she subscribed to. Please bear with me (or give me advice on integrated tokens). I'll try to have a new patch in here soon.

sutharsan’s picture

sutharsan commented

Callison, Simplenews 2.x-dev and HEAD are integrated with Token. So feel free to use this code as example and tokenize the patch. I'll be happy to review and add it to Simplenews.

What happened to the #20 patch, is it replaced by #27? I'm confused.

callison’s picture

callison commented

@Sutharsan: I wasn't exactly sure what you meant in #21 so I kind of changed direction. I then thought why replicate existing functionality so I tried to use the existing 'Send Email' action and just incorporate that into Simplenews. So, that's what the patch in #27 does. Now I'm almost done adding some tokens.

callison’s picture

callison commented
Status: Needs work » Needs review
StatusFileSize
new simplenews_send_email.patch.patch1.01 KB
new simplenews_action_send_email.patch2.22 KB

OK, here's an updated patch from #27.

This patch allows the send_email action to be used as a Simplenews trigger. On the send_email configuration page (after creating the advanced send_email action), there is now token replacement for the simplenews variables defined in simplenews_token_list. I have tested this some, but more testing would be appreciated.

Note: In order to include the newsletter's name as a token variable, I had to make a patch for simplenews.module also - make sure to apply both patches.

aschiwi’s picture

aschiwi commented

@callison: Thank you for your quick work on those patches. Are they for Simplenews 2.x-dev?

callison’s picture

callison commented

@aschiwi: They're for HEAD - I'm not sure the version number.

krabbe’s picture

krabbe commented
Title: Notify Admin of Subscribe/Unsubscribe » Patch doesn't work for me

I tried the patches, but the simplenews_send_email-patch didn't work.
This is what terminal said:

patching file simplenews.module
Hunk #1 FAILED at 1045.
Hunk #2 succeeded at 1070 with fuzz 2 (offset -28 lines).
1 out of 2 hunks FAILED -- saving rejects to file simplenews.module.rej

The newsletter-action-patch seemed to work, but I can't test it because of the failure of the other patch.

donquixote’s picture

donquixote commented
Title: Patch doesn't work for me » Notify Admin of Subscribe/Unsubscribe

changing back the title

(it seems the issue title field is easily mistaken for a comment title field - I did the same thing when my account was younger..)

callison’s picture

callison commented

@krabbe: Are you using the HEAD version of simplenews?

krabbe’s picture

krabbe commented

@callison: Yes, I do...

@donquixote: Sorry 4 that. Indeed I thought it's a comment-title.

callison’s picture

callison commented

@krabbe - I just patched a clean version of HEAD with no problems. Can anyone else confirm the problem that krabbe is having?

krabbe’s picture

krabbe commented

OK, I started from the beginning again, got the HEAD-version, applied the patches without error and can see the simplenews-tokens now...
Don't know why, must have had the wrong HEAD version.

Thanks a lot.

krabbe’s picture

krabbe commented

But now the newsletter-variables don't expand in the confirmation-Mail to the subscriber.

This is what I got in the mail:

Wir haben von !mailto eine Registrierungsanfrage für den !newsletter_name
der !site - Webseite - !uri - bekommen. Um diese Anfrage zu bestätigen
benutze bitte den untenstehenden Link.
___

We have received a request for subscription of !mailto to the
!newsletter_name on !site website at !uri. To confirm this subscription
please use the link below.
___

!confirm_subscribe_url

I'm not sure if I should use the patch from http://drupal.org/node/365507#comment-2021982 ??

krabbe’s picture

krabbe commented

I changed to Simplenews 6.x-2.x-dev (2009-Dez-10) and I've got the newsletter-variables back working.

And I can create a new action "Send tokenized email" with simplenews-token like [simplenews-receiver-mail].
But when I go to built > trigger > simplenews they do not show up.

Should I open a new issue for that?

sutharsan’s picture

sutharsan commented

If tokens in 2.x are not expanded, you should create a new issue. But make sure you can reproduce this error on a unpatched 2.x version.

sutharsan’s picture

sutharsan commented

I don't like the way the newsletter name is fed into the $subscription object in the simplenews.module patch. I'd rather see this moved to simplenews_action_mail_alter() or a fundamental approach by adding the newsletter name to the $subscription object which is returned by simplenews_get_subscription().

Patches do apply to HEAD without errors.

krabbe’s picture

krabbe commented

@Sutharsan - I created a new issue here, but you found it allready. The version I use is still unpatched...

krabbe’s picture

krabbe commented

I patched the 2.x-dev and the simplenews-actions work only for user, not for guests.

And the simplenews-tokens show up in the action "Send tokenized email", but the action to choose on triggers > simplenews is only the "Send email".

callison’s picture

callison commented
Status: Needs review » Needs work

@sutharsan - I agree completely but I couldn't find a way to do it. Since I used the send email action, the simplenews info is not passed in via context or anything else. I looked at every variable I was being passed and couldn't find a way at all to get the name. Please let me know (in a little more detail if possible) how I could go about getting the name in the send email context. Thanks.

In the meantime, I'll work on getting the fundamental approach working via simplenews_get_subscription().

linksync’s picture

linksync commented

subscribing

mkmk’s picture

mkmk commented

I am very interested in seeing this feature becoming part of simplenews.

eloiguell’s picture

eloiguell commented

I have customized simplenews.module to blocking forever unsubscribed emails for legal reasons. New topic: http://drupal.org/node/695734

sutharsan’s picture

sutharsan commented

Eloiguell, please stay on topic.

eloiguell’s picture

eloiguell commented

Sorry Sutharsan. I had move it to a new topic.

eric_a’s picture

eric_a commented

I just arrived here and will spend some more time with this issue.

For my own needs I'm going to try an unsubscribe approach different from the patch. It is a simple way, meeting points made in #48 by Satharsan (http://drupal.org/node/345579#comment-2362580) and it does not need any API change at all.

If the action would fetch the current subscription object (which is not being cached) by doing something like simplenews_get_subscription($object) it could compare the two subscription objects and figure out which newsletter is involved in the unsubscribe trigger.

Of course this does not help actions dealing with subscribing...

I'll report back.

EDIT: Hmm, the only reason this idea could work for unsubscribe and not for subscribe is because in the former case the initial subscription object is passed to actions and in the second case the updated subscription object. Inconsistency? Bug?

aschiwi’s picture

aschiwi commented

I have a working rules integration. I can't post a patch yet but am willing to give everyone the module who wants it. Feel free to contact me.

eric_a’s picture

eric_a commented

@callison and Sutharsan: what happened to the idea of passing $tid as extra context? It was there in the patch from #20 and then it was gone.
Passing this data in $context is a much better idea than stuffing it in the object which contains all subscriptions.

Passing the newsletter is essential for notifying about somebody subscribing/unsubscribing. Making existing actions from system (or any other module) available to the simplenews trigger is another isue. I think it would be good to focus some more in this issue. Perhaps split it up in two.

muschpusch’s picture

muschpusch commented

subscribe

mkmk’s picture

mkmk commented

subscribe

I don't know if me saying "subscribe" will actually subscribe me to this thread... there's no indication of this anywhere.

j0nathan’s picture

j0nathan commented

subscribing

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

[off-topic] @mkmk: all those people saying 'subscribe' do so because any comment will make the issue appear on their personal tracker page. Yours is at http://drupal.org/user/359099/track. See? Now I'm subscribed too :-)

kruser’s picture

kruser commented

subscribe:
The patch in #36 works, but the only token that doesn't render in the email is Email address of the newsletter receiver - [simplenews-receiver-mail]

modctek’s picture

modctek commented

[simplenews-subscriptions-url] also does not render. I've not tested any of the other Simplenews-specific tokens yet aside from this one and the one mentioned above.

sfyn’s picture

sfyn commented

sub

wwwoliondorcom’s picture

wwwoliondorcom commented

Hi,

Is it now possible to get these notifications ?

Thanks a lot.

MakeOnlineShop’s picture

MakeOnlineShop commented

Hello

Can i know why this function has not yet been added to Simplenews after years ?

I wonder if few people are interested by this ?

Cheers.

callison’s picture

callison commented
Assigned: callison » Unassigned
modctek’s picture

modctek commented

I imagine on a high-traffic site, this could flood an inbox without some form of digest mode.

simonp-1’s picture

simonp-1 commented
Version: 7.x-1.x-dev » 6.x-2.x-dev

Just wondering where work is at on this and if it is going to be possible to make use of this functionality without having to patch modules in the near future?

As far as I understand from reading and trying out the current version of modules, integrating changes to Simplenews subscriber lists with any contact data held externally is extremely cumbersome. It seems like it currently works if the subscriber is logged in, but for an organization of any size (with maybe multiple newsletters) this scenario seems unlikely.

Please could anybody correct me if I've got this wrong, and thanks for any update on the status of this issue...

simon georges’s picture

simon georges commented

@simonp, there is no work directly into this, but :
- there currently is an issue about Rules Integration (#620498: Integration with Rules module)
- maybe it's possible to use Simplenews Actions to achieve that in the meantine
- since a few commits, a hook is fired when user subscribes / unsubscribes (#1069570: Define hooks on subscribe/unsubscribe user), so it should be possible to use it, at least in 6.x-2.x.

klim_’s picture

klim_ commented

subscribe #64:
token [simplenews-receiver-mail] dont render in email, is it because there is confirmation mail to accept subscription?

simon georges’s picture

simon georges commented

Regarding the missing token: #720444: Send tokenized e-mail - token fields not populated.

calbasi’s picture

calbasi
Primary language Catalan
Location Catalonia
commented
Version: 6.x-2.x-dev » 7.x-1.0-beta2
Issue tags: +simplenews notification

I'm changing version to the last d7 version...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.0-beta2 » 6.x-2.x-dev

This should easily be possible in 7.x using the provides rules integration module. Maybe someone can provide default rules for this or write a documentation page about how to do it?

Setting back to 6.x-2.x as that's where the technical limitations are, 7.x-1.x is just configuration thing.

reptilex’s picture

reptilex commented

Ok I figured it out. Will share it here so that the next guy doesn't need to do trial and error, at least not in D7.

For this to work you have to have:

  • Rules Module enabled
  • and Rules UI enabled (this comes with rules)
  • and simplenews rules enabled (this comes with simplenews)

After that for my case I added a new role for the people I wanted to be notified, but you can just choose the administrator role.

  1. Go to [[yoursite]]/admin/config/workflow/rules and add a new rule. Call it what you like but choose "A user has been subscribed " from the simplenews events and set that for "React on event". And save it
  2. Add an action for this rule, choose "send mail for all users in a role". And choose the role you want to be notified
  3. Under subject add something like: New Subscription from <?php echo $mail; ?> for simplenews category <?php echo $tid; ?>
  4. Under message add something like: A new subscriber with the email <?php echo $mail; ?> for the simplenews category <?php echo $tid; ?> has been added for your site <?php echo $site; ?>. Be happy.
  5. save

Next time someone subscribes you will get an email. Now go and do the same for unsubscribe. Remember to use the event "A user has been unsubscribed" and use the proper wording in the email fields. This should do the trick.

B Leg’s picture

B Leg commented

reptilex: What version of simplenews are you using? I don't have simplenews rules and the admin/config/workflow/rules path doesn't exist either. Are you running D7?

alexander.nachev’s picture

alexander.nachev commented

Solution in comment #77 by reptilex works perfect for D7. Thanks for it.

reptilex’s picture

reptilex commented

Yeah B Leg. I'm running D7. And you are welcome alexander.nache. ;)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

@reptilex: Would be great if you could add a How-To to the documentation so that others can find it more easily. Go to the project page, click on view documentation and then add a child page.

You could also provide a patch with a disabled default rule.

rmcom’s picture

rmcom commented

subscribe #64:
token [simplenews-receiver-mail] does not render in notification email

reptilex’s picture

reptilex commented

@Berdir good idea, I added the howto (at http://drupal.org/node/1835500) feel free to review it, right now I don't have the time to write the code, but I would be glad to test it and correct it if someone else does.

Marko B’s picture

Marko B commented

Why use "send mail for all users in a role" why not just send an simple email to someone and that is it?