An easier way to add images to posts (a complete rewrite of img_assist)

Benshell and I plan to merge many of these changes into the current img_assist module for the upcoming 4.7 release. We both agreed that there's no benefit in yet another inline image mod.

The concept of co-developers (i.e., other user's with CVS commit blessings) has worked very well for me, with TinyMCE being my first attempt. I hope to do more of this, especially with the ecommerce package. (Sorry for getting slightly off-topic)

Please use my contact to get in touch.

Anyone else want to pony up a bounty to have this backported to 4.6? Unless, Ben and Matt, you can let me know if this is not possible?

hello Benjamin,
Your rewrite of img_assist is exactly what I want. Thanx a lot !
Unfortunatly, it doesn't work. When I push add an image (the camera of the first version of img-assist is no more here. Normal ?), a pop-up opens but in it, there is the message page not found.
I think that I did not install well.... But don't know how to fix the problem.

Thank you very much for your help !

Lisadol

OK, I've downloaded your new version and unzipped the file. I'm a little confused regarding the contents. Obviously the unzipped drupalimage folder goes in the plugin folder of tinymce. No problem there.

Now, here is what I have.

tinymce.module replaces the same in the /modules/tinymce folder.

img_assist.module,
image_assist.js
image_assist.css all go in the /modules/image_assist folder

Where do the following go:
tinymce.js - someplace in the tinymce folder, but where?
textarea.js - beats me on this one. Where does it go?

Additonally, in the install.txt file, for 4.6 you reference the following:

"There is section in this function (starting around line 282
of tinymce.module) that says:

switch ($theme_name) {
case 'advanced':
$init['extended_valid_elements'] = 'a[href|target|name|title|onclick],img[class|src|border=0|alt|title|width|height|align|name]';
$init['theme_advanced_buttons3_add_before'] = 'tablecontrols,separator';
$init['plugins'] = 'drupalimage,table,emotions,fullscreen';
$init['theme_advanced_buttons3_add'] = 'drupalimage,emotions,separator,fullscreen';
break;"

But, in the tinymce.module file included in your zip file, these lines are included:

"// Add some extra features when using the advanced theme.
switch ($theme_name) {
case 'custom':
$init['extended_valid_elements'] = 'a[href|target|name|title|onclick],img[class|src|border=0|alt|title|hspace|vspace|width|height|align|onmouseover|onmouseout|name]';
$init['plugins'] = 'drupalimage,emotions';
//$init['theme_custom_buttons1_add_before'] = 'drupalimage,emotions,separator,';
//$init['theme_custom_buttons1_add'] = 'drupalimage,emotions,separator';
break;"

Are the changes in the install.txt file to be made here? I am bit confused and that confusion has made both image_assist and tinymce inop for me.

Thanks in advance for the help.

Where is the direct link to download the modified version of img_assist?

-zach
------------------------
harkey design

Could someone explain why Image.module and img_assist.module are seperate any benefits of doing it so? - from user/usage point of view.

also looking into the cvs. (4.7) that image.module is not one of the default, again is there any benefit of it?

-imho- image handling is not optional for most websites or cms's but essential part of it.

i would extent the necessity to a media.module, sections handling -image, video and sound combined to be step ahead from all other CMS' or CMF's or whatever you define in an opensource 'product'

Thanks benshell! Finally a image inertion module that actually works! You are my god.

Kindest Regards,

gtoddv

I just submitted a feature request (I hope I did it in the right spot) that says:

As ejort mentions here, I'd love to have a checkbox that gave the option to "Delete original image" (the one that you're uploading) so I/Drupal user can just use the resized/resampled image.

Another commenter suggested, "Just resize before upload." which I know how to do, but most of my clients (Drupal users) don't know how to do and they're going to upload their 2 MB images from their digital cameras and wonder later why (1) their servers are full, (2) the images load slowly, (3) you get the idea.

Thanks,

- Bradley

From what I see here this module is being developed for 4.6? Is that correct?

Will it be possible to use this in 4.7 when it arrives?

wellsy
like someone else here said "always use a test site"
permit me to add "backup your database regularly"
orchidsonline.com.au

Benshell, I really appreciate the work you are doing. As a designer, not a programmer, I am kinda at the whim of your efforts.

Adding a way to get images into posts easily is probably the biggest drawback of Drupal for me at this time. Sure I can use some code to get the images I have to show in posts, but that is a real pain.

What I would like is to have an image float left and to have text wrap around it nicely. I would also like all images to be 20% as wide as the column I am working with, and when you click on them, a full size picture of the image opens in its own window.

for a live example of what I am looking for, look here: http://main.greasyfur.com

Obviously I have to tweak this code for every picture. It also has the disadvantage of having the browser redraw the picture smaller, rather than GD.

I loaded your version of image assist, I was able to get the window with the thumbs to come up, but when I click "insert" nothing happens. Have I done something wrong or stupid? I also had big problems with the original image_assist, which I could not get to do what I wanted at all.

I am using drupal 4.6 on a server hosted by hostgator.

Just a couple of requests.

1. Can the drop-down box be the list of image galleries instead of my images (and if configured taxonomy terms)?

2. Can we have a text box for configuring the padding for the text wrap?

Thanks again for some great work. This is the type of stuff that will really make drupal appeal to the greatest number of folks.

gtoddv

First of all, great work. I am so into this. My users are already thanking weeping in joy.

After some testing, the main item that keeps coming up is the upload form. The fact that it uses the main stylesheet but not the actual page template causes most of my layouts to get munged up. Also, the pop up window is just too small (and not resizable) to accomodate the entire image node creation form.

Tell me what you think of this idea: Instead of presenting the full create image node form in a small popup window, what if it presented a greatly simplified on the fly form that only had the absolute minimum:

1. Title
2. Description
3. Image upload button

If the user wants to specify Authoring information, Options, User comments, path aliases, Input Formats, Attachments, Menu OTF, etc. he can use the normal 'create image' option on the website, and don't forget he can always go back and make changes to the other fields later anyway. But otherwise the streamlined form should just use the defaults without presenting them.

For the image galleries I suggest a default img_assist gallery that all images are posted to at first (they can always be moved later). Maybe the user could even specify it in the img_assist settings?

-zach
------------------------
harkey design

Have it working fine on one site, but on another site operating off the same code base I'm getting errors relating to not finding "node_revisions" table - I think this has to do with the fact that I was using the old version of img_assist on this site, but had not used it at all on the site that works. But neither site has a "node_revisions" table. Looking at the image_assist.module source, this appears to be related to legacy code, but I'm not quite sure what to do about it. Would really like to be using this, the integration with TinyMCE is so much better. Any suggestions would be greatly appreciated.

Also, is there a newer version of your module available for download?

Thanks,
T

As far as I see it, the ability to easily choose/upload images on the fly is the single most important feature lacking from Drupal (It's almost a dealbreaker).

I've been testing this version extensively and here are my thoughts, and notes from watching over the shoulders of 12 brand new users (a design class I teach) one at a time as they attempted to place an image (followed by a list of possible improvements). Note: I am not using Tiny HTML Area, but I am using Markdown.

Overall. I like the ability to generate a new sized image on the fly, but not if it comes at the expense of the defaults. My users are constantly breaking my layouts. The best thing about the image module is that the admin/theme designer can determine an appropriate thumbnail and preview size (exactly, to the pixel) for the layout/theme/node, but the user doesn't have to think about it. They just upload whatever sized original they want and the preview size fits perfectly. (I tell them as a rule, don't upload anything larger than 1000px wide or it'll take forever to upload, and that does the trick.)

The problem with the current implementation is that in most situations, the user is going to want to use the default sizes, and this makes it very hard because they have to manually enter it in every time. Which means they have to go look in their notes and see that it needs to be, for example, 465px wide for a perfect fit.

The problem is they don't do this. They either just leave the default values of 200 x whatever, (which are hard coded into the module so even if I change these values in the code so that it defaults to my preferred size, all my sites (30 or so in a multisite setup) inherit the same value and they all have different size constraints. Even if they do take the time to enter the appropriate value that I specified for the thumbnail for instance, instead of using the existing thumbnail, it creates a duplicate.

I have spent many hours considering the best way to handle these things and here is an detailed list. I realize some of these aren't exactly quick fixes and I'm trying to determine the best way to move forward myself, but nonetheless here's the list:

1. The add image window should not create its own thumbnail if it can use the default thumbnail image module has already created (since it is mandatory anyway).
2. Size should offer (either by dropdown or radio group) all of the image sizes that have been specified in the Image settings first, with the last choice being 'other'. If 'other' is selected, it could activate a previously disabled fieldset where the user can specify the width and height. (It's my opinion that the only time img_assist should generate an image is if this is selected. Otherwize it should use the existing versions. It's a unecessary to have so many derivatives of the same image. Some of my images have like 7 sizes.)
3. The pre-selected default should be 'thumbnail' (or pref in img_assist settings). The 'other' fields should not be pre-filled in with any default values - like they are now with 200 x 200 - because there is no way to edit or specify these values.
4. 'Align' should offer at least left, right and center(no-float), and these should be implemented through css classes (e.g. .image-left, etc.) located in the img_assist.css instead of the current method of inline styles. This would allow theme designers to specify additional styles for inline images (e.g. margins and padding on the floats, etc.)
5. An alternative route would be to rename 'Align' to 'Layout' and let the user choose from a list of classes that are defined in the stylesheet.
6. All Popup windows should(must) be resizeable (frames too).
7. Do we have to use frames at all? I would love to get the whole thing in one page, and use fixed positioning for the header and a scrolling div for the thumbs or something. You've already reduced one frame it seems.
8. Bonus feature: Provide the option for the image to be a link, and even provide options for the target. For example (very rough):

   When clicked, the image should:
   [x] Do nothing (not a link)
   [ ] Go to the image's standard node view (preview size)
   [ ] Open original in popup window
   [ ] Go to [http://___________________________]

I still haven't addressed the taxonomy/gallery situation, but I wanted to get these ideas out there. If it would be helpful, I am willing to comp up some static UI screenshots to fully flush out the flow. I would also love to help in any other way I can. I'm kind of confused about how this version is being developed. Is it officially been absorbed into the existing img_assist module? Is it in the CVS somewhere? If I make some modifications to the code, is there a place where I submit a patch?

-zach
------------------------
harkey design

This looks very nice. Well done!

An idea that you may want to look into i would love to see done, instead of popping up a new window which the user has to juggle, why not try putting it on the same page using a collapsible fieldset with an IFrame in it. Its not a too distant jump from what you already have now ...

I think we really need an upload status indicator. It isn't uncommon for an image to take a full minute to upload and during this time there is no feedback to the user, who is likely to think the upload failed or their browser froze.

It doesn't have to be an accurate progress bar, just some kind of message that says, 'image uploading, please wait.' and maybe a small looping animation. It would also be cool if we could disable the submit button (gray it out).

I really think this is an important usability feature.

Now that I think about it, is this something that should be implemented in img_assist, or probably image/upload module, or maybe even Drupal core?

-zach
------------------------
harkey design

Here's a one-line-patch to make the link-attribute work. It links to the image node if |link=1| or any other value. Using only |link| doesn't work. You might also use the $attributes['link'] as a url easily, that is, treat this attribute as an url-string not a boolean value. I.e: |link=http://some.url/|

--- img_assist.orig/img_assist.module   2005-11-04 18:33:04.000000000 +0100
+++ img_assist/img_assist.module        2005-11-24 20:14:00.000000000 +0100
@@ -632,7 +632,7 @@
        
        $output  = "<div class=\"inline\" style=\"float: {$attributes['align']}\">";
        if ($attributes['link']) {
-               $output .= l($link, $img_tag);
+               $output .= l($img_tag, "node/" . $node->nid, array(), NULL, NULL, FALSE, TRUE);
        } else {
                $output .= $img_tag;
        }

Unfortunately, I am *also* encountering this problem - I can't get the drupal image camera to work, and if I enable the add image text link and then click on the text link to insert an image, I get a window from which I can choose my image, but when I click "insert" nothing happens.
Any tips on how to get the drupalimage plugin working?
Or how to get the text link working?

I am using drupal 4.6 hosted on a Windows Brinkster account (which I cannot recommend), not using clean urls.

Michal Ehrman
Boutique - Online Fashion Magazine
http://www.boutique.co.il

how difficult would it be to make it also compatible with images uploaded to a menalto G2 gallery ?

also, i found a rounding error: i uploaded image.jpg using this new img_assist module, changed nothing to the suggested view size (200x155) and got the following results:

original size = 1642 x 1276
img_assist preview size = 200 x 155
img_assist view size = 199 x 155

it would also be great to have a single file for the preview generated by the image module and the one generated by the img_assist module

regards,
thx for this wonderful module

I could write a short book about how incredible this aspect of things is (tools to make it easy easy easy for the "average end user" or "web site owner" or contributor to put text and graphics on the internet), but I'll try to refrain... Other than to say, as others have mentioned regarding the general topic, there probably isn't anything more central or basic when it comes to the "comfort level" of that "average end user." And, from what I've seen, img_assist (with the image.module) takes care of the graphics part of that equation in a way that should make it possible for even those nearer the "average end idiot" end of the spectrum (people like me), to be able to include images with near-zero knowledge (of anything) and one eye closed...

Exellent job!

I also want to say that this particular thread is one of the best I've come across on the Drupal site. I'm sure there are many more like it, but everyone who's contributed to it ought to know it's: A) an impressive display of intelligent collaboration (a nice mix of things from "experts" and "not so experts," and good all around input from all concerned); and B) one that I found particulary helpful.

For example, Artem's "Installation screenshots" and "no-brainer" instructions made it possible for me to get the whole thing downloaded, installed and, wonder of wonders, working in something like 15 minutes... Not only that, but after installing everything, something seemed not quite right. Mainly, I couldn't see/find the options to position images on the right or left. After another 15 minutes of wondering and looking more closely, I figured out I ought to download the newer version from the page linked in Benshell's initial post. Made that switch and presto! All fixed.

And here's what's "impressive" about all that: As mentioned, I'm new to Drupal, don't come close to understanding it yet (taxonomy, vocabularies, books, nodes, etc.), and while I get the concept of modules and have looked them over (a real candy store!), I hadn't dared mess with any of them. So, being a near-average end idiot, it's only natural that the first thing I'd try to figure out is how to make it easy for people to insert graphics into whatever text they'd be adding to whatever sites I'd put together with Drupal... Never mind site structure, linking, etc. (see taxonomy, etc. above), let's just jump in here and see about getting a photo into a "story!"

And - thanks to img_assist and this thread (and Artem's guide for those in a hurry) - it looked like it might be, and, more importantly, actually was, a snap. So thanks everybody! This has been a good day for at least one Drupal beginner that will make things a LOT easier from here on out, no doubt (now that I've got this module installation things down and all - "Piece of cake" ;).

Okay... Pardon the length. I must be excited. And for all that, I do have a question that pertains to the images.module galleries... While I understand the necessity of the galleries being there, how can I set things so they don't show up as part of the "visible" site? That is to say, is it possible to set galleries to "invisible" so their only purpose is to serve as a "background repository" for the images placed via img_assist and not as "content items"? (If that makes sense.)

Also, is it possible for people to edit an image (right or left placement, description, etc.) after it has been inserted? Is there a way to bring it's img_assist "file" back up to edit the same way a story can be editied or is it best/simplest to just delete the code from the "story" and "re-add" the image? (If that makes sense).

So, like many other drupal devs, I'm moving some sites to 4.7. I've come around to the rich text editor/image management phase of the deployment, and, lo and behold, img_assist is broken.

We desperately need a well-supported image manager. TinyMCE is the editor of choice, so there should be no gotchas when running them together. Moxiecode has a good one that is, or soon will be, integrated with drupal (authentication etc). ATM, I'm willing to pay $40 for something that works. Long term, though, let's get this problem solved!

Concerns:

• This code should be in CVS.
• Is this going to be merged with the original img_assist? The screenshots look nice, and there seems to be lots of positive feedback.
• There is an effort to port the original img_assist to 4.7. If this is the new img_assist, then we should be porting it to 4.7.

Benjamin, Matt, what's the plan?

Respectfully,
Eric D

I have the same problems that some other users already posted. The module works fine, but not when I use TinyMCE. When I click on the camera icon a window with a 404 error opens. I am using TinyMCE 4.6.0 . I copied the tinymce.module from benshell. Do I have to change anything more? I could not find a file called "plugin_reg.php" I guess it was part of older versions from TinyMCE and not 4.6.0 ?!

Benshell, I'm having a problem with your version of img_assist on a fresh install of:

- Drupal 4.6.5
- tinymce module 4.6.0
- tinymce 2.0.1

I have no images loaded (just in case the old img_assist was causing problems). The tinymce module is working correctly with the advanced theme. I am using the tinymce.module and the drupalimage plugin you include with img_assist. I am using clean urls.

When I hover over the camera icon the browser statusbar is empty, but hovering over any other icon shows the tinyMCE.execInstanceCommand() function.

When I click the camera icon a new window opens up (no toolbars, statusbar, etc) displaying a themed window saying "Page not found". The address of this window is /modules/tinymce/tinymce/jscripts/tiny_mce/themes/advanced/index.php?q=img_assist/add&editor=tinymce

When I check to logs at /admin I have a warning saying "img_assist/add not found"

Any idea how to correct this? I don't really know where to start.

Thanks - I'm eager to start using the new img_assist. It looks great.

Hi Ben,
I'm really looking forward to getting your module working - sounds like just the job.

Just would like a little clarification on the installation process, on 2 points.

1. In installation.txt it states at the top under dependancies to use:

* Image Module version 4.6.2 or newer.

We're using drupal 4.6.5 and 'image' is not a core module. But the downloadable 'image module' is version 4.6.0 ? Am I looking in the wrong place for 4.6.2?

2. The other thing is when enabling the 'drupalimage plugin' for tinyMCE, the install.txt states:

FOR TINYMCE MODULE AFTER 4.6 (not including 4.6):

Edit the plugin_reg.php file in the tinymce module. Add
these lines:

I can't find a 'plugin_reg.php' do I just create it and paste the respective lines of code in and drop it into the modules/tinymce directory?

Thanks in advance - if I can get this working smoothly it's gonna be a life saver!

Sam

--
http://surfcore.co.uk

I had a hard time getting this module to work initially, and I finally discovered that my problem was a tinyMCE setting I had specified. If you set inline_styles = true, tinyMCE will try to replace the height and width tags of the placeholder image with style equivilents. While normally okay, this will break the img_assist cleanup routine and end up throwing a bunch of PHP errors caused by a divide by 0 error (since the height and width are both erased).

Great work on this program. It is much more verbose than the original img_assist and I'm glad you've put all this effort into it.

Backwards compatibility fix: in order to support nodes created with the old img_assist an additional function is needed: _img_assist_get_thumbnail(). Right now if you try to load a node with the old img_assist format, it'll choke the whole page with a nasty PHP error. Ben, could you add this function to the module to make the legacy code work? I added it in mine and it's working great now.

Here's the missing function from the old img_assist

/**
 * Attach the thumbnail metadata to the image object.
 *
 * Unfortunately we have to query the database since the thumbnail can be named
 * something entirely different from the original image.
 */
function _img_assist_get_thumbnail(&$image) {
  static $thumbs = array();

  if ($thumbs[$image->nid] === NULL) {
    $thumbpath = file_create_path(db_result(db_query("SELECT filepath FROM {files} WHERE nid = %d AND filename = 'thumbnail'", $image->nid)));
    // In the really old version of image.module thumbnail names were 'thumb_filename.ext'.
    if (!file_exists($thumbpath)) {
      $pos = strrpos($image->filepath, '/') + 1;
      $thumbpath = file_create_path(substr($image->filepath, 0, $pos) .'thumb_'. substr($image->filepath, $pos));
    }
    $img->thumbpath = is_file($thumbpath) && preg_match('|^'. variable_get('file_directory_path', 'files') .'\/'. variable_get('image_default_path', 'images'). '\/' .'|', $image->filepath) ? $thumbpath : $image->filepath;

    $dim = getimagesize($img->thumbpath, $info);
    $img->thumbwidth  = $dim[0];
    $img->thumbheight = $dim[1];
    $thumbs[$image->nid] = $img;
  }

  if ($thumbs[$image->nid]) {
    foreach($thumbs[$image->nid] as $key => $value) {
      $image->$key = $value;
    }
  }
}

Just paste it at the end of the new img_assist module (with the other legacy functions) and your site will be backwards-compatible.

Hello.

I'm using the cvs version of drupal.
I'm not using the img_assit cvs but the version img_assist47 rewritten by you.

When I create a image, i have an error:

The selected file /home/valerie/public_html/drupal4/files could not be copied.

But the image is created!!
And in the directory files, there is a directory images. In this directory, there are the image and the file named files (but it is not octet).

You can see the screenshot of my problem:

http://img20.imagevenue.com/img.php?loc=loc121&image=00e5b_plan_de_trava...

Can you help me?

Thank you.

When I enable img_assist and go to Create Content > Image or Admin > Settings, I get a completely blank screen. There isn't any undisplayed HTML either. Just completely blank screens. I've reloaded Drupal, image and img_assist and created a fresh database and get the same results. All the downloads are recent, like within the last week or so. image and img_assist were downloaded 2/7.

When I disable img_assist the two screens show up just fine and I can use both of them, Images end up in the images/temp directory when I do a Create Content > Image but I get an empty screen after I hit "Submit".

I'm running Mandrive 2006, Apache 2.0.54, PHP 5.0.4, MySql 4.1.12 and Drupal 4.5.7

I want to change the html outputted by img_assist - specificly the spans outputted around the image - editing the theme_img_assist_inline fuction seems to do nothing, infact deleting img_assist.module, yet the same html is been rendered still results in the same html been outputted. Yet I can't find anything else that outputs <span class="caption" style="width:.... only the theme_img_assist_inline function?

Thanks

Hello,

I'm very new to Drupal (testing),
but have worked with eZ publish (for corporation) and Mambo/Joomla (quick solution for my sport club).

On eZ publish there is an output independent format (xml) of xml-content fields.

http://ez.no/doc/ez_publish/technical_manual/3_6/reference/xml_tags#obje...

And you can additional relate other nodes/objects(e.g. images) with a node. for sanity checks like on an attempt to delete an image if it is used/referenced by another node this can be useful too.

http://ez.no/doc/ez_publish/technical_manual/3_6/concepts_and_basics/con...

Output can be in html or pdf or whatever format.

On Drupal I tried the pdfview on content with image included by img_assist(official current 4.6.0 version) and it doesn't work.

Another try with content that uses a table from the tablemanager.module doesn't work too. So pdfview must know all the formats that use other modules???

In Mambo/Joomla there is the mambot concept, where images (or other content that should be inline) are included in the textarea-fields as tags like {mosimage} while the references to the imagefiles(just relative filepaths to a global defined imagedir) and the params like alignment are saved in a database field.
This is done very simple in an unusual way, but if the user understood the concept it is ok, but lacks some cms features.

I believe image module and something like img_assist module should be added in a drupal distribution.

Further I full agree with Zachs comments especially the selection of fixed, predefined sizes for inline images, so editors/authors can't break the layout too easy. If you really want the ability to set the size then use the role system to give special roles the right to do so.

Just my 2 cents on this topic.

Firstly, good work Ben,

When I add an image only the photo icon comes up in a shaded box indicating where the image is placed rather than the actual image. Is this normal in the TinyMCE textarea? How can this be fixed or what might be the problem.

The whole thing works well but would be better if I could see the actual photo in the text area of TinyMCE once I insert the image.

Cheers.

Hi, don´t know if this is a bug, but I see, that the img_assist.css file is loaded for anonymous users that can not upload anything. there is an

<link type="text/css" rel="stylesheet" href="modules/img_assist/img_assist.css" />

in the header of every page loaded. I don´t want this.

is the functionality of img_assist dependent of inlusion of the css file on every page, even when the img_assist function is not used? I understand well, if the css is loaded at the point, when user wants to add images, but why is it loaded all the time? And, most importantly: how to change that?

Thanks!

Advanced user- Jesus, I wish I was!!! ;)

I am using a taxonomy_block (http://drupal.org/node/15192), what seems to be a good thing for setting up a site easily. Problem is: in these blocks the Image code shows up, not the image itself.

I do NOT want to have the Image in the $sidebar code. I do not know, what exactly generates that sidebar. The main content shows up correctly with image rendered - yes, I checked the filter page, img_assist is enabled.

What do I have to do to get the img-code OUT of the taxonomy_block? I am using the PHPTemplate box_cleanslate on 4.6.5 Drupal

I read about a similar problem in this thread, but did not understand the answer...

THANK YOU!

Later: Ok, I checked the code of the taxonomy_block.module and I replace line 248:

 #    $block['content'] = $content;
 #     replace with:
        $block['content'] = check_output($content);

Now the picture shows up in the Block. Well, of course the picture is much too big to be shown in a block, so ist there any possibility to ignore the inline image code? I only want the text in the teaser....

THANK YOU Very much for your attention!

And one more: seems like that code also kills my linebreaks, so the Title is not separated anymore from the teaser *sigh*... Boys, am i the first guy who wants images in taxonomy_blocks??? Sorry, i go sleep now, it´s too much...

Of course, if there is any other way to do what taxonomy_block does, but wihout images, please let me know... Thanks!

OK, I could not sleep before solving this:

I used this code now to strip the img_assist inline code:

248   $img_assist_tag = '%\[img_assist.*\]%';
249   $block['content'] = preg_replace($img_assist_tag,'',$content,1);

seems to work without any side-effects, but maybe anyone could check this? Thanks! Also I think it is a real dirty way of doing this and there moght be some better way of integrating img_assist with other modules? A cookbook recipe would be nice here...

OK, ONE MORE:

As the above code eats up all the $content, it is better to get it in the while loop that gets the nodes. I use it now like this (around line 235 in taxonomy_block.module):

    ### identify img_assist tag!
    $img_assist_tag = '%\[img_assist.*\]%';
    
    while ($node = db_fetch_object($nodes)) {
       $x++;
       $content .= '<div id="taxonomy_block_'. $x .'" class="'. (substr(decbin($x), -1) ? 'flip' : 'flop') .'"><h2>'. l($node->title, 'node/'. $node->nid,  array('title'=>t('view all'))) .'</h2>';
       if($result->teaser) {
 
       # $content .= strip_tags(substr($node->body, 0, $result->teaser) . (strlen($node->body) > $result->teaser ? '...' : '')) .'</div>';
       ### GET OUT THAT IMG_ASSIST TAG!
        $node->body = preg_replace($img_assist_tag,'',$node->body,1);
        $content .= strip_tags(substr($node->body, 0, $result->teaser) . (strlen($node->body) > $result->teaser ? '...' : '')) .'</div>';
       }
       else {
         $content .= '</div>';
       }
    }

As i really do not know anything about drupal code structures, please anybody with knowledge check this and, if not usable or unclean, tell me, how this kind of thing should have been done.

Thanks again...

Hi,

how can I get the img_assist_modul to make the inline images a link to a page with links to bigger versions of the pictures that were used in the article? You know, what I mean? It´s quite the usual "pop up image galerie" - is it possible with img_assist?

An alternative would be to have a link on just the bigger sized version of the picture with description - the link is not added automatically, so how can I get this link?

Thanks!

when drupalimage / img_assist is called from the tinyMCE toolbar in fullscreen window, the img_assist window loses communication with the parent and so cannot insert images into it.

I think this is a problem with img_assist rather than tinyMCE ?

apologies for the druplication (http://drupal.org/node/50439), but I submitted this as a bug report nearly a fortnight ago and have had no response.

Am I the only person having this problem or is it a bug?
Any information most welcome.

The latest archive code from http://www.benjaminshell.com doesn't appear to work on HEAD, probably because of the removal of the setting. All urls are broken, rendering the system unusable.

--
More Drupal modules

Ben, could you give us some idea of what remains to be done before you are ready to put this into CVS?

I would like to suggest that you create a completely new project (maybe "image_assist"), then put a note on the img_assist page saying that it is being replaced by this new image_assist for 4.7 and beyond, with a link to the new project. That way you could get it into CVS whenever you like (now?) and start with a fresh issue queue that's not polluted with all the stuff from the old code-base.

(It would also allow us to finally put this forum thread to rest :-)

Am I the only one who thinks we would be better off opening our own phpbb forum for this discussion?

I mean, I've been tracking this thread, but it's gotten to the point where I get a sick feeling when I see comments have been added because I don't have the energy to scroll.

What are our options here? This is starting to feel like one of those monolithic ad hoc email exchanges perpetuated by office people who don't know any better.

This can't be how smart people communicate.

--------

Ha, of course it would be my post that triggers the pager so at first glance I look like I'm nuts.

This bug was causing problems with my 'default' tinymce buttons, my symptoms were as follows:

• return key inserts double paragraph breaks : <p><br />return key</p><p>&nbsp;</p><p>&nbsp;</p>
• text formats (bold, italic, underline) don't apply to selected text
• list formats don't apply to selected text, but they do collapse the paragraph breaks and 'flicker' for a moment
• undo doesn't appear to work
• code cleaner doesn't appear to work
• search & replace stopped working (no pop-up window)

These buttons are working as usual: drupalimg_assist pop up (benshell's version), help popup, emoticons pop up, html popup,
fullscreen pop up, link and unlink buttons

the javascript console in Firefox was logging this error (quite frequently):

tinyMCE.switchClassSticky is not a function on line 178 of .../drupalimage/editor_plugin.js

Here is the *patched* whole 'parent' function with offending line (line 5 in the extract below) escaped :

function TinyMCE_drupalimage_handleNodeChange(editor_id, node, undo_index, undo_levels, visual_aid, any_selection) {
	function getAttrib(elm, name) {
		return elm.getAttribute(name) ? elm.getAttribute(name) : "";
	}

// tinyMCE.switchClassSticky(editor_id + '_drupalimage', 'mceButtonNormal');  /* it seems this whole line should not be here! */

	if (node == null)
		return;

	do {
		// This code looks at the name of the image to see if the drupalimage button should be selected.
		// However, by default 'name' is not accepted by TinyMCE as a parameter for the img tag, so it must
		// be added using the initialization string.  As far as THIS code goes, it could look at 'className' 
		// instead, therefore avoiding this requirement, however the regular image button looks at the 
		// 'name' value to see if it starts with 'mce_'.  If it does, it considers it an internal image and 
		// does not highlight the regular image button.  If 'className' is used here instead, BOTH buttons
		// highlight when a drupalimage is selected.
		if (node.nodeName.toLowerCase() == "img" && getAttrib(node, 'name').indexOf('mce_plugin_drupalimage') == 0) {
			tinyMCE.switchClassSticky(editor_id + '_drupalimage', 'mceButtonSelected');
		}
	} while ((node = node.parentNode));

	return true;
}

Now the drupalimage button and the ordinary (default) buttons seem to be functioning as they should (better than ever in fact - nice one benshell!)

Let's hope I haven't broken something else .... :)

The interface was working properly and I was able to insert images from my galleries into the TinyMCE workspace.

When I preview or submit the node, the image does not appear, and no HTML is being generated. I figured something was going wrong with the filter. I checked the database node_revisions table and saw that the tag being saved was something like:
[img_assist|/nid=48|title=Awesome Image|....]
and so on.

On closer inspection, img_assist is looking for a tag like
[img_assist|nid=48|title=Awesome Image|....]
so it doesn't expect to find a backslash before the nid.

I added the following to line 1064 of img_assist.module:

  if(!isset($attributes['nid']) && isset($attributes['/nid'])) {
      $attributes['nid'] = $attributes['/nid'];
  }

The images now display as expected. I don't know where the extra backslash was coming from (any ideas?), but this hack fixes my problem for now.

I'm running Drupal 4.7 - I think my CVS is up-to-date. PHP 5.1 and MySQL 5. I'm using Ben's non-versioned im_assist distribution and I'm a Drupal noob.

Being aware that the implementation of this flavour of the img_assist module is not for the impatient, I attempted to implement the module, but stopped mid-way because it tends to interfere with the prevailing CSS on the pages (changes the font-weight on all the links regardless of the class or ID).

Also, I am running 4.65 and I was not sure if your reference to all versions after 4.6 not including 4.6 refers to 4.6x. I must say that if it works, it's a good feature that my users have been asking for and I am looking forward to implimenting it once I have enough down-time to make the specific code changes and follow thet steps to install this module.

-----
Web Development & Production Advice - http://www.cmsproducer.com

I'm using 4.6.5. Benshell refered me to his rewrite of img_assist after I posted a feature request needing a way to disable the linking of some images.

I have close to 70 images so far all created with the old img_assist module, how is the legacy support working? I'd rather not have to replace all the old img_assist tags with new ones since it would be a royal pain.

Now what I need to do, and which isn't supported by the 4.6 version of this module, is to disable linking on some images, for usability reasons, but Ben said it shouldn't be that if you know some PHP and I've been messing with it since 2001.

I've organized my existing images using taxonomy vocab terms in multiple level hierarchies and it works great, does this work with this new rewrite as well?

Any serious bugs reported for the 4.6 version? I am trying to make up my mind whether to switch from the old img_assist to this one, trying to find out whether it's worth it.

I appreciate any feedback and advice.

Thank you for getting this out. I will bug test it soon...

So I got img_assist working perfectly, but one thing I would like to be able to do is have the images appear on my front page. The articles that appear there are simply grabbed via php, so it obviously skips the processing that img_assist and the other image modules do.

Is there an easy way to get my images to appear or am I out of luck?

Hi Ben,
I just went through the routine. I downloaded 'your' zip file and it all works. I have a question though.
In the TinyMCE demo program the image icon brings up an image browser and an advanced tab, etc. Can The TinyMCE image editor be used just like in the TinyMCE demo without the addon you have?
Sorry if this sound like I don't understabd because I don't. I am not a programmer. A side note here -- I was using htmlarea, it has a great image loader utility, but the code is not compliant and the editor in general is not clean, almost bulkie. I like the image tool in htmlarea but I like TinymCE editor --

Thanks again for your excellent work with TinyMCE.

Just a suggestion ... why don't we all file out of here respectfully and quietly and let this forum thread "Rest In Peace" now that this version of img_assist is in CVS.

We can use the issue queue for most things and create new forum topics for anything else.

新浪娱乐讯 由日刊SPORTS和JES共同主办，文化观光部和SBS协办的第42届百想艺术大赏，2006年4月14日下午18:00(北京时间14日下午17:00)，于韩国国立剧院隆重举行。wow gold 本届百想艺术大奖由申东叶、郑智英、尹贤真,wow gold 担任主持，SBS TV进行了2小时的现场直播。

Hi,
the popup window is framed and is not displaying curretly.. everytime i post I need to scroll down to see the rest of fields.. is there a way to change it?

Currently to add an image requires mininum 2 steps..

1st step is upload image as a node, then insert image.. this is quite difficult for most of web users.. expecially for beginners.

Is there anyway you can create a more user friendly input interface?

like 1) click drupimage icon a pop up window appears 2) click on upload the file tab, upload the file 3) alignment stuff(right, left, top, bottom, size, margin, and etc) 4) attach

by eliminating the first pop up window(post image node) would make a lot of ppls life easier.

Thanks very much for the great module!

cheers,

try this uploader for tinymce
http://drupal.org/node/78033

Will there be a 6.x version soon?