Closed (duplicate)
Project:
Simplenews
Version:
6.x-1.0-beta5
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Nov 2008 at 05:34 UTC
Updated:
2 Jan 2010 at 16:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
sutharsan commentedDoes this only happen in html emails? Does this happen when other modules send html emails? Does this happen in plain text newsletters?
Please investigate further. It is possible that this is a mime mail issue. Please use latest dev versions of both simplenews and mime mail.
Comment #2
cbeem commentedThanks for such a fast response! Much appreciated.
Yes, this only happens with html mail which I realised after my initial post. If 'plain' is selected with or without an attachment the links are displaying correctly except:
Attachments with spaces in the file name do not include the full link, i.e. //mysite/myfolder/test mailout.php appears as a link to //mysite/myfolder/test and the mailout.php is not included. This link is correct before sending in the Drupal screen.
I have not tried any other modules to send html email.
I am happy at this stage to send brief plain text messages with a PDF attached. It is easy enough to remove spaces from a PDF file name!
I will try the latest dev version of simplenews and mime mail and see what happens. Since I already have the latest version of mime mail, I will not change this.
Many thanks.
-------
Update-
I tried the latest development versions of simplenews and mime mail. It works!
I can send html email and the links display correctly. However there are two things I have noticed:
Thanks,
Cliff
Comment #3
patrickharris commentedI'm getting the same problem sending html emails with the latest dev versions of simplenews & mimemail. The footer appears as
href="/newsletter/confirm/remove/">Unsubscribe from this newsletterand images are displayed as attachments. Any idea what might be causing this?Comment #4
patrickharris commentedI wonder why more people aren't experiencing this? What seems to be happening, is that drupal_mail (in mail.inc) performs drupal_wrap_mail on the message body. Mimemail then performs a check_markup in its drupal_mail_wrapper() function ... and line break converter filter has fun in inserting numerous breaks all over the place which destroy the html message.
Can anyone else duplicate this?
Comment #5
sutharsan commentedI've seen this problem before but can't find it in the issue queue. Pls try the latest dev version of both modules and perhaps you have more luck searching the queue.
Comment #6
patrickharris commentedI'm using the latest dev versions of simplenews and mimemail.
Comment #7
cbeem commentedJust wondering, has this got anything to do with cleanurls? I am NOT using cleanurls, mostly because things just seem to go better without them - I have had all sorts of problems with various modules and css when using cleanurls. I too am using the latest dev versions of simplenews and mime mail. Links are appearing correctly now but images are all attachments.
Comment #8
cbeem commentedI have gone with phplist and the phplist integration module.
The phplist setup is working perfectly with Drupal.
I hope you can get simplenews running reliably, I like the interface.
Thanks for your time and effort.
Comment #9
hnln commentedI fixed the unsubscription link by theming theme_simplenews_newsletter_footer. I copied over the function from the module and in the format == 'html' condition I modified the line like so:
Where the change is adding in the $base_url in the link function.
Hans
Comment #10
sutharsan commentedHnLn, thanks for diving in. Although your solution is not optimal, you are definitely on the right track! The attached patch solves this by adding an 'absolute' = TRUE to the l() function.
The attached patch has been committed to 6.x-1.x-dev.
Comment #11
sutharsan commentedb.t.w. this only solves the footer link problem.
Comment #12
OneTwoTait commentedI had the exact same problem. Installing the dev version fixed it.
I still just get plain text like "Unsubscribe from this newsletter" on Hotmail though.... hmmmm
Comment #13
cbeem commentedSomething I have just noticed, I am using Mime Mail 6.x-1.x-dev - the core email module seems to be broken when this is installed. I get empty body and footer for emails sent out with anything that comes from the Drupal authentication (login) module, i.e. any emails to new users etc. are blank. Deleting Mime Mail fixes it. Obviously this is a Mime Mail bug but I thought you should know, since simplenews requires it.
Comment #14
sutharsan commented@patrickharris: I found the issue I thought handles the double filtering. #305650: Restore Mime Mail support in D6 But that was fixed. Related discussion at #306670: Simplenews ignores paragraphes on some installations
I've made a few improvements on the plain text alternative that simplenews passes on to mimemail. The attached patch is committed to 6.x-1.x-dev. I guess this is all I can do at simplenews side now.
Re #4: this is now reported frequently in this issue list.
Comment #15
sutharsan commentedFurther testing reveiled that the $text parameter of mimemail() is not only the plain text alternative for HTML emails, but also is the body of the plain text emails. The attached patch corrects this in simplenews.
Patch is committed.
Comment #17
donquixote commentedI still don't see how the issue with attachments is supposed to be fixed.
I tried including attachments as
but none of these results in
The first two create broken images like
I don't see how the above patches (all from 2008) are supposed to fix this issue, so I set it back to active.
Comment #18
donquixote commentedSee also the Mime Mail issue src="Array" if path to image is broken
Comment #19
sutharsan commentedDuplicate. Patched available at #319229: src="Array" if path to image is broken