|Project:||Project Issue File Review|
Justin Randell noticed this evening that the Menu item creation/deletion tests had a failure in them. So I spent a few minutes rolling back patches until it stopped failing. It turns out, this patch causes it.
The failure was:
"Menu item was reset" in menu.test line 317 (MenuTestCase->resetMenuItem())
Testing bot, however, did not catch this. :( I marked the patch back for retesting at :30, it passed at :57, and was committed at :18. The only thing committed in this ~20 minute window was http://drupal.org/node/67349#comment-1122071 which is a one-line change to SQLite, nowhere near the menu system.
We need to get to the bottom of this, because if we can't trust testing bot to come back with accurate results, it's not going to actually save core maintainers any time.