Hi,

thanks for working on a CCK-based gallery solution; even if I already figured out some pieces myself (e.g. simple taxonomy-based galleries with arguments), there's lots of stuff I haven't yet got working. So I'm pretty interested how you're accomplishing your goals.

However, the first dev release from yesterday seems to have several major issues; I second, that some instructions would be very helpful. In my setup, the content copy module is installed and activated; two new node types are being created, also two new views (gallery_contents and gallery_list_nodereference). Both views only include default settings, no page; gallery_list_nodereference filters for Node: Type "CCK Gallery", but does not contain any node reference or relationship; I simply don't get what it is supposed to do. The "CCK Gallery" node type does not have any CCK fields attached, so I don't understand what it does, either.

Lastly, there seems to be an uninstall function missing; after deactivating the module at /admin/build/modules, nothing is listed in the uninstall section (/admin/build/modules/uninstall); in the database, tables like "content_type_cck_image" and "content_field_gallery" remain untouched. I'm not sure if this is a wanted behaviour.

There seems to be some ground to cover with the module - my best wishes for that!

Greetings, -asb

Comments

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Hi asb,

Thanks for your comments and thanks for trying the module. To answer your questions:

1. The views don't need Page displays, as they are being called by a hook_menu() (in the case of the view for My Galleries) and by a views_embed_view function call in the /theme/node-cck_gallery.tpl.php file which you are supposed to copy to your theme (see README packaged with the module). Unfortunately, I should note I did forget to include a view - the one for the My Galleries page - in the default views hook so that view is missing. This is an error I cannot easily rectify until Monday, because I left the code in the office. Sorry about that. I know what the view settings were, so if I get a chance I'll re-create it at home and fix that issue - I'll leave this bug report active as a reminder.

2. CCK Gallery is effectively the "container" node type for "CCK Images". When you create an image, it must be related to a gallery. The gallery does not need any additional fields as it only acts as a reference point for several images. Clearly, it can contain a title, description and other meta data relating to the set. It is vital you copy the /theme/node-cck_gallery.tpl.php file to your theme, as it does state in the README, or the related images will not appear in the gallery. This template calls the view which lists all related image nodes (images in that gallery) under the gallery title and description.

3. There is no uninstall at the moment deliberately. Deleting the content types would cause problems with nodes left behind and deleting nodes on uninstallation is, IMO, a really bad idea. It is better to leave individuals to decide if they want to delete content types and related nodes themselves (which is a simple task and takes two minutes) rather than deciding for them and destroying their data. I might include an uninstall hook for getting rid of the Imagecache presets though (see other issues).

Hope that answers your questions for now. There is still a fair bit to do, but the critical point now is getting that view included... oops!

Ps - I'll update the project page now with some extra explanations and info.

asb’s picture

asb commented

Hi Greg,

thank you for your fast reply; since I'm trying to develop (without coding ;) something similar for myself, it itches me everywhere to suggest lots of features I would need (e.g. differently sized images in one gallery, distinguished by a tag (taxonomy term) or a flag (flag module)). However, I got the impression that you know pretty well what you're doing and what you want, so it's better to leave you some room and let you do your stuff ;)

Best wishes & greetings, -asb

PS: *itch* *itch* I'd like a module that wouldn't create own content types, but "snap" into, or add itself to existing ones; the same goes for the views and it's naming (l18n/i18n, even after upgrading the module), or the Imagecache presets - meaning: more a kind of "glue" than a full gallery package *itch* *itch*

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Title: Views have no pages » Ability to define different Imagecache presets for different galleries by Taxonomy
Category: bug » feature

Changed to feature request...

OK, so if I understand you right the new title describes *one* of the features you'd like? Some sort of mechanism for marrying ImageCache presets to taxonomy terms, so the applied term selects the ImageCache preset used to display the image?

I'll leave the idea here for future reference, but I need to get the initial concept working properly first.

In the meantime, did you see the admin settings? You can already point the module at your own image and gallery content types, and pick different views from the ones available, at admin/content/cck-gallery ... the only thing you can't do (which I didn't think of) is choose your Imagecache presets. I'll add this as a separate feature request.

One word of warning though - you *must* match the CCK Image content type's CCK fields for the gallery to still function and you *must* copy and paste the code at the end of /theme/node-cck_gallery.tpl.php in to the template for your newly selected gallery content type.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

FYI: http://drupal.org/node/363888

asb’s picture

asb commented

> Some sort of mechanism for marrying ImageCache presets to taxonomy terms, so the applied term selects the ImageCache preset
> used to display the image?

Yes, that describes it quite properly, I think.

What I want in the end is something like this (upper part of the page): One "teaser image", scaled to 400 px on top, below several "gallery images", scaled to 150 px in a 4x"n" raster (horizontal four thumbs until all images of the given gallery are displayed. More flexibility would be fine, but I'd have no idea how this could be automatized (bulk upload images into CCK imagefields how? tag them where and with which interface?) This was all so fast and eay in Microsoft Frontpage ;-)

Also thanks for you pointer in #4!

Greetings, -asb

asb’s picture

asb commented

Regarding the lack of an uninstall function one last comment: When trying to delete "CCK Image" nodes after uninstalling the module, I ran into a problem: Those nodes can not be deleted:

Galleries field is required.
Galleries field is required.
Image field is required.

The same goes for bulk operations from Administraer -> Content management (/admin/content/node):

An illegal choice has been detected. Please contact the site administrator.

This should be handled somehow.

Greetings, -asb

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Oooh, that sounds pretty bad. Could you do me a favour and raise that as a separate "bug report" so I have one issue per thread? =)

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Active » Fixed

Marking this as "fixed", because the actual task in the title is done (will be committed shortly). You can now pick the thumbnail to use in the gallery view using the settings page, instead of altering the view - you could alter the view anyway, but this keeps things in one place for non-techie users. Edit: Oops! See below.

Please do raise a separate bug report for #6 ... I will investigate.

Re: the example gallery you posted, you can already do this:

  • Add a CCK imagefield to the 'CCK Gallery' content type called 'field_gallery_main_image'
  • Create an ImageCache preset for the size you want
  • Under display fields for 'CCK Gallery' set your 'field_gallery_main_image' field to use your new preset on Node view (and probably normal thumbnail on Teaser - hide labels too)
  • Juggle the field order on the 'CCK Gallery' content type settings so the image is at the bottom, after the title and description

That's it - you're done! =)

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Arg! "Fixed" the wrong issue! =(

asb’s picture

asb commented
Status: Fixed » Active

Hi, I opened another issue and apologize for flooding the issue queue ;-) Greetings, -asb

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Active » Closed (fixed)

This is too much of an edge case I think. I won't have time to build it, for sure. If you really want something like this, raise a new issue over at Node Gallery for the new 6.x-3.x branch and explain what you want and why you want it. Sorry this never got built. Not enough hours in the day! =/