"exanded" elements of a menu-item-rooted tree aren't expanded

I need to better understand what you want before I can tell you how to do it. :-)

So, what happens when you click on the "Sub level 1 nav1"? Do you want the children to appear at that point? Or do you want it to remain hidden like it is to start?

Ok, so menu_block has the "expand all" checkbox, but you can't "expand only down to the 2nd level".

But…

To get around that, you could edit your menu under admin/build/menu and click the "expand" checkbox for all of the item on the first level that you want expanded. And then just menu_block work normally without its "expand all" feature enabled.

Does that work for you?

I just tested this and it works exactly as I describe. So something is misconfigured on your site.

If you'd like me to help, please provide screenshots of the block config and the menu config pages.

Ok. I just confirmed this.

I hadn't set the root of my menu block to a specific menu item. If I just use the menu root, things work as expected.

So, this is definitely a bug.

Having the same issue and would love a fix.

Attached is a very simple patcht that simply adds an additional check before trimming a menu tree.

If a menu item has the 'expanded' field ticked in the menu configuration, it will not be trimmed anymore.

I believe this is the proper fix for this issue, but I have only done limited testing.

Tried the patch and the code suggestions above. Neither of them seem to work for my menu tree.

I'm wondering if I'm doing something silly. I'm using a primary links menu with all the menus in trees, for example:

Section 1
Section 2
+ Page 1
+ Page 2
+ Page 3 (expanded)
++ Page 1a
++ Page 2a (expanded)
Section 3
...

So when viewing Page 3, I'd like the sub-menu showing Page 2a to be displayed in another block. I can't figure out a way of making this work, so I'm resorting to adding in menu blocks manually.

Also, I've noticed that if more than one section has 'Expanded' selected then the expanded items further down the menu list inherit all the previously expanded items in the breadcrumb. (sorry tricky to explain).

In our testing, the failure to expand for the active trail (distinct from what cedric fixes in #13) appears to be the same bug as Menu Block does not work with menu items pointing to the same destination.

We have a fairly simple structure, a set of top-level menu links. Everything below one top-level item is for one section and is put there with a menu block:

  - sub-menu item
     - sub-menu item's features
     - sub-menu item's what's new
     - sub-menu item's other stuff

The parent sub-menu item link and "features" go to the same page. The menu is expanded and active link highlighted fine for "what's new" and "other stuff" but that these sub-item links disappear entirely when going to "sub-menu item" or its identical child "features" is of course the problem.

This patch is against the 2.x-dev branch.

It is admittedly a crazy work-aroundish fix for menu_block menus not expanding when parent path the same as a child path (or perhaps my specific problem was that Submenu Item and Submenu Item's features link to the same internal product/196/features, which is also equivalent to simply product/196).

The problem was that Drupal core's menu_tree_page_data() was not returning any active trail information for that sort of menu item (parent or child).

This patch provides a modified version of that function that really only does one thing differently: if the href can be constructed from the menu item's map instead of the truncated version saved in $item['href'], the map-derived value is used instead. This fixes it. (The reason is that product/196 and its ilk have no parents in menu_links, and so no active trail; searching for product/196/features turns up two records, of course, and only one is used but it is expanding and highlighting correctly the active trail correctly for me.)

The ugliness of duplicating a core function is worsened by the need to opt out of menu's caching system for this to work. Might this be a bug that needs fixing in core?

More eyes and advice needed, but the change in the attached patch is going into service on a production site very shortly. It works, it is not likely the best way- and I am not sure it will fix the other cases reported here.

^{benjamin, agaric}

Tweaked this a little more– ensuring that the menu item with the most parents, rather than the least, gets loaded makes menus appear properly expanded on our site.

          $parents = db_fetch_array(db_query("SELECT p1, p2, p3, p4, p5, p6, p7, p8 FROM {menu_links} WHERE menu_name = '%s' AND link_path IN (". $placeholders .") ORDER BY depth DESC LIMIT 1", $args));

^{benjamin, agaric}

Does this patch fix http://drupal.org/node/618700 too?

I've applied patch http://drupal.org/files/issues/menu_block-fix-failure-to-expand-when-sam... (#17) to the -dev version of the module, but the problem on http://drupal.org/node/618700 has not been solved :-(

Patch #12 and #13 doesn't work for me either :-(

P.S: I've well summarized my problem at http://drupal.org/node/618700#comment-2530916

Anyone else come up with anything on this one?

I'll have to look at an alternative module because this is a showstopper for me.

Ok. How about this patch? I've converted menu_tree_trim_active_path() into a simpler recursive function that follows the active path or expanded menu items.

I've committed this, but please test. This bug should be fixed, but if I've missed anything, please re-open.

Thanks, guys!

that works for me, many thanks! that's a great start to Monday morning!

Patch Worked for me.

Hi,
when i start my block configuration the only field i can find in the section "block specific settings" is the block-title.
Any ideas what i'm doing wrong?
Thanks.

Hi Andreas,

Please open a new issue and describe more fully what you did. This is a closed issue about a bug that has already been fixed. And you have not provided enough information for anyone to help you.

Hello, I tried using 2.3 and 2.2-dev and I am not able to have the expanded settings from the menu be reflected in the menu_block. Essentially I need to start displaying level 2 and expand level 2 and 3 but hide level 4 until a level 3 item is clicked. This works fine if I don't use menu-block and use a normal menu, but I then miss all the features of your module...

I checked my menu_block.module and it indeed has the above patch from #23 applied to it already. Am I missing a setting somewhere? How can I get menu_block to show the expanded/collapsed menu's in accordance with how I have them expanded/collapsed in my menu settings?

At the moment I am hoping this is me just not knowing how to configure it, so I have set the status to "support request" instead of "bug".

Thank you,

Sebastian.

Please do not open closed bug reports to submit support requests.