Drupal 4.7 Update for img assist

It all works great for me.

One debugging line to be taken out of the first patch at line 89:

+ echo "YEP";

but other than that, great. You have saved me a lot of work tonight - I was just about to make a start on it myself... and given that it would have been my first dabbling in the new forms api, you probably did it a lot better and quicker than I would!

Actually found a problem now, although I'm not certain if it is as a result of your patch.

img_assist doesn't appear to be able to use image derivatives other than the thumbnail. They appear in the dropdown menu in the popup, but when the code is inserted the src attribute always links to the thumbnail image.

Can anyone else reproduce this?

Actually, the more I look at this, the more problems I find...

When you click on an image it doesn't populate into the image preview area.

If you choose an alternative derivative (thumbnail, orignal, preview etc) nothing happens. The sizes do not populate into the dimensions fields and the wrong link is returned.

Any description / alt tag information added in the img_assist window does not populate back to the code inserted.

All this is with the "insert html" mode. I haven't looked at the tag/filter option.

Any description / alt tag information added in the img_assist window does not populate back to the code inserted.

Actually, further testing shows that this field can't handle quotation marks, that's all.

Continuing this little conversation with myself, there were a couple of syntax errors in your patch which were causing all of these problems, and the use of a curious form attribute "#extras"... which is a new one on me! I switched it for "#attributes".

There may be more bugs I have not yet found.

Hello Simon,

I tried to apply your patch to revision 1.54 of the module and this is what happened:

$ patch img_assist.module < img_assist.module_1.patch
(Stripping trailing CRs from patch.)
patching file img_assist.module
patch: **** malformed patch at line 113: @@ -167,13 +219,39 @@

Any ideas?

Probably that I am evil and created it on Windows, so it will have windows line endings on it :-(

See http://drupal.org/node/324.

I should really learn how to do that myself - very antisocial, I know.

Not so much a bug report as I havent tested this.
Is is meant to work with 4.6?

Some feature request for new version.. seems like this would be best place to ask.

Anyway,
Waldemar mentioned that he would like to integrate this with Gallery 2.. That would be brilliant.

Similarly, could the new version integrate with Acidfree from the start?
Acidfree has some advantages in that it is closely integrated with Drupal, and stores images as a node [allowing tagging etc], but Gallery is more fully featured.

Lastly,
When using Img_assist to add images, could the option be there to add them to the preferred image module, whether it be Acidfree, Gallery or plain old image.

Thanks for the module, When I started using Drupal, I couldn't believe this wan't a core feature!
I now realise the value of modularity!

Regards
Alan

Sorry, Alan, this isn't going to answer any of those questions - I hope someone more knowledgable than I will be able to help you.

Instead here is (I think!) a unix friendly patch to apply to 1.54 of img_assist to make it work with 4.7.

I should say that I have already discovered further bugs - you can't actually upload a new image via img_assist at the moment.

Simon

I've basically solved all the outstanding bugs with this, except one.

When I use img_assist in conjunction with tinyMCE and insert HTML code from the img_assist window into the tinyMCE textarea the link which is sent with the image contains "../../../../../" before the actual like to the image node (node/xx). This doesn't happen when you are not using tinyMCE (i.e. you are plain-text editting). Which leads me to think that it must be an tinyMCE problem?

I would appreciate any input on this, because I don't think I can solve it myself. tinyMCE is too complicated for me!

Any suggestions?

If I solve this then I'll post the complete patch for 1.54 to make it 4.7 compliant.

Waldemar,

I've attached a new patch which brings everything up to date. I've also put in a workaround for the bug I just posted about (the relative link in tinyMCE). It's on line 902. I've included the absolute url instead. tinyMCE still appears to cut some bits off with a ../ or two, but the url is now long enough that it works in every case that I've tried. (Like, I said, I don't even claim to understand tinyMCE!).

The only other outstanding issue that I have is the setting entitled:

"Hide 'inline image link' for the following node types:"

I can't work out what this is supposed to do. I've fixed up the form so that it works in 4.7, but I can't see that setting implemented anywhere within the module! Any ideas?

Simon

That's exactly what I mean. Good luck trying to debug that one!

..."the image is inserted correctly, but when you move it around in tinymce for some reason ../../ gets appended to the image path."

The same thing happens in 4.6 when I use tables and images.

jim

i use diff npatch on a macsox and , he reject a lot of code
i use the img_assist.module_3.patch and the img_assist.module,v 1.54 2005/11/30 02:48:56

why ??

I apologise if there are any problems with the patch. Unfortunately I have to produce them on a windows system and then try to convert them to unix file formats. So it's highly likely that there may be some problems! Not a lot I can do... :-/ Sorry.

I have a few questions about this patch.

Before anything else we do know that there is a problem with running the patch. I wish someone will attach the module itself so that we can try it.

1. With this patch, will this enable the camera icon that appears below the texarea like in the 4.6.0 version? I could not get the icon to show up.

2. I applied the 3 patches manually and was able to get the img_assist plugin for tinyMCE to popup including all the image files. I was able to select the image to show in the preview pane having all the image properties displayed at the bottom portion of the popup window, however, clicking the insert button does nothing for me.

3. again, i wish someone who got this patch going create a working patch and post it here so we can try it.

I'll try to answer the points you raise.

Firstly, there are no known problems in applying these two patches:

properties.js.patch (970 bytes)
editor_plugin_src.js.patch (827 bytes)

The most significant patch is the one for the img_assist.module itself. I created the patch, it appears to have some problems - not with the code, rather with the format of the patch. I'm sorry that I can't help any further with that.

What I can say is that, with these patches applied, I have a fully working version of img_assist with the tinymce plugin working properly.

Attached is an img_assist.module_3.patch that works on something less selfish than Windows. It is the exact same patch as simon's, only made to work.

I also suspect, though I haven't investigated this, that it trumps phpcoder's (and my own) later patch at http://drupal.org/node/42553.

i have always this error whit this patch

i dont know why ?

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home2/c/cx-rousse/www/drupal47/modules/img_assist/img_assist.module on line 372

i use diffnpatch on osx

someone could send the complete module ??

This new patch makes the image directory work properly, whether it's configured to display as a list of all images, or to display a filtered list of images based on taxonomy (also works for 'my images'). It also rolls the img_assist.module patch and the properties.js patch together in one file.

The only thing I can see that still doesn't work properly is the 'image preview filter' select list on the img_assist settings page. This setting is used properly if set manually in the database; but it doesn't seem to get saved properly through the admin interface. Maybe a forms API multi-select problem, or a system.module problem?

Diff between img_assist.module with the previous version of the patch applied, and with the new version of the patch applied (so it's clear what new changes I've put in).

Changed an array2object() call to a cast using (object).

i cant apply this f.. patch
is it because i'm on a mac ??
strange , because it's not my first one.
could you send me the complete.

is there anyone who can host this thing for us or can we put this into cvs? i have a mac and i don't really feel like duplicating all these problems that people have had! patching is so much harder than just downloading a module, i'm not sure why we bother to do it, actually...

to clarify: i just gave it a try and wasted my time. these patchs aren't going to work on macs. but it's not like we're on a 12k baud modem! let's get the module. many thanks!

i'm agree whith kvanerlis

Greetings, I just applied the most current patch from Jaza called img_assist_formsapi_5.patch without any problems on my Mac OSX 10.4.4 machine.

$ patch img_assist.module < img_assist_formsapi_5.patch 
patching file img_assist.module
patching file properties.js 

What errors are you seeing? The maintainer of this module probably is not going to apply these patches to his module unless they can be thoroughly vetted by the community. That is what patches are for.

in fact i use the software"diffanpatch" and it always make me errors

Pardon my further questioning, but Mac OSX ships with GNU versions of the diff and patch utilities, and the way these patches are formed is valid. In order to facilitate your issue, we are going to need more detailed information.

After aplying the pacthes I had to coment out two lines on tinymce.module (lines 71 and 72) to make to make it work:

 function insertImage(form) {
    if (window.opener) {
      form['edit[filepath]'].value = window.opener.tinyMCE.convertURL(form['edit[filepath]'].value);
      form['edit[nodePath]'].value = window.opener.tinyMCE.convertURL(form['edit[nodePath]'].value);

to

 function insertImage(form) {
    if (window.opener) {
      //form['edit[filepath]'].value = window.opener.tinyMCE.convertURL(form['edit[filepath]'].value);
      //form['edit[nodePath]'].value = window.opener.tinyMCE.convertURL(form['edit[nodePath]'].value);

Thanks.

And the patched files for the people that can't patch them (the previous upload didn't seem to work)...

Note that img_assist has a new maintainer now, who has rewritten the module completely. His code should appear in CVS real soon now. Check it out in this post.

Bastiaan.

The img_assist_formsapi_5.patch when applied to the CVS version of the img_assist.module worked great for me in drupal.4.7 beta4. If the new version of img_assist that is being re-writen is in the works, I would like to see this current version continue since it is tested and works now with 4.7. Add my vote to commit this patch to CVS and then to 4.7 contrib modules.

@bryan kennedy,

please send me the complete code of your img_assist.modules (worked great for me in drupal.4.7 beta4) or attaches the file.

With my img_assist.module (same patch version) i can't save changes in settings -> Preview settings -> Image preview filter.

I would like to find even the error in the code.

Thanks
quiptime

I've just committed my new rewritten version of img_assist to the CVS repository. Hopefully it will work great for everyone (and if it doesn't please submit a bug report or feature request).