macFFBgHack.png not included in distribution

Starminder - March 19, 2009 - 23:34
Project:album photos
Version:6.x-2.6-beta3
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Description

The file "macFFBgHack.png" is missing from ../sites/all/modules/photos/thickbox/macFFBgHack.png

Quick fix: Copy from Thickbox module to destination. Please include in next release.

#1

eastcn - March 20, 2009 - 01:05

You enabled thickbox module?

If so, priority should be given to the use of its js. Please make changes:

<?php
// photos.module

function photos_init() {
   
drupal_add_js(drupal_get_path('module', 'photos').'/js/photos.js');
  
drupal_add_js(drupal_get_path('module', 'photos').'/js/jquery.jeditable.pack.js');
-  
drupal_add_js(drupal_get_path('module', 'photos').'/thickbox/thickbox-compressed.js');
-  
drupal_add_css(drupal_get_path('module', 'photos').'/thickbox/thickbox.css');
+  if(!
module_exists('thickbox')){
+    
drupal_add_js(drupal_get_path('module', 'photos').'/thickbox/thickbox-compressed.js');
+    
drupal_add_css(drupal_get_path('module', 'photos').'/thickbox/thickbox.css');
+  }
   
drupal_add_css(drupal_get_path('module', 'photos').'/css/photos.css');
}
?>

#2

Starminder - March 24, 2009 - 18:40
Version:6.x-2.6-beta2» 6.x-2.6-beta3

.png not included in latest beta 3.

I will try the thickbox patch as soon as I can get the module to work at all - at the moment it makes to where I cannot post a new blog entry.

#3

Starminder - March 24, 2009 - 18:40
Status:needs review» active

setting status to active

#5

Starminder - March 25, 2009 - 14:46

Thanks - I have the file, I think it needs to be included in the release. If not, then any new user of album photos will have this problem.

#6

Starminder - April 5, 2009 - 02:54

I tried replacing the init hook with the thickbox code above, but got an error:

Parse error: syntax error, unexpected T_IF in /usr/home/hoslo/public_html/sites/all/modules/photos/photos.module on line 1197

#7

Starminder - April 5, 2009 - 14:43

OK, tried again, no error, but I still don't see a thickbox view. Replaced code so it now looks like this:

//hook_init
function photos_init() {
drupal_add_js(drupal_get_path('module', 'photos').'/js/photos.js');
  drupal_add_js(drupal_get_path('module', 'photos').'/js/jquery.jeditable.pack.js');
  if(!module_exists('thickbox')){
  if(!module_exists('thickbox')){
     drupal_add_js(drupal_get_path('module', 'photos').'/thickbox/thickbox-compressed.js');
     drupal_add_css(drupal_get_path('module', 'photos').'/thickbox/thickbox.css');
  }
  }
drupal_add_css(drupal_get_path('module', 'photos').'/css/photos.css');

#8

Starminder - June 9, 2009 - 16:40
Status:active» needs work
 
 

Drupal is a registered trademark of Dries Buytaert.