Attached is a patch to rework the filter format settings hook. It seemed quite straightforward, but it seems the 'markup' elements of the form are still displayed (albeit in a slightly broken way) when the fieldset is collapsed.

Can any Forms API experts take a look? Is it a bug or a simple thing I've missed?

CommentFileSizeAuthor
#1 marksmarty_settings_fix_forms_api_r2.patch3.16 KBpfaocle
marksmarty.module.formsapi_partial_update.patch3.31 KBpfaocle

Comments

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Title: Update for Forms API - not quite right » Update for Forms API
Status: Needs work » Needs review
StatusFileSize
new marksmarty_settings_fix_forms_api_r2.patch3.16 KB

Needed to include paragraph tags around the markup elements, thanks to m3avrck for pointing this out. Patch works fine now.

teradome’s picture

teradome commented

Thanks so much for putting this patch in here -- "officially" the 4.7 port won't be committed until I can develop it against the final, but this helps the must-have-bleeding-edge users that are out there (myself not being one of them. :) that want to install 4.7 the moment it's released.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Title: Update for Forms API » Update for Forms API (Drupal 4.7)

Just been duped. 4.7 is getting closer.... ;)

teradome’s picture

teradome commented
Assigned: Unassigned » teradome
Status: Needs review » Fixed

patch looks good -- has gone in as first commit to the 4.7 branch. whee!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)