New issue in 6.10: Re-edit a revision in moderation ignores the 'new revisions in moderation' checkbox [patched]

We are seeing this issue. Here's the use-case I just scratched out to create an issue on it:

1. User x changes document.
2. Revision is placed in moderation.
3. User x sends URL for revision to User y.
4. User y edits revision, clicks Save.
5. Page is immediately published with user #3's changes -- Revision in Moderation flag is ignored.

We're using Drupal 6.10, 6.x-1.0-alpha1 of Revision Moderation. "Exempt administrators from revision moderation" is un-set.

It's a repeatable behavior on the site we've just launched.

This happens when editing any revision, not just revisions in moderation, and it affects nodes created both before and after installation of Revision Moderation. Can be observed for users with and without the "administer nodes" permission.

As a workaround for this, you could look at the Private module:

http://drupal.org/project/private

It creates a setting to 'make private' and a permission to 'view private nodes.' Haven't tried it yet, but will probably implement it to work around this issue for the site we're just launching. Hopefully Revision Moderation will be fixed by the time of our next launch.

Of course, "private" won't even remotely suffice. Real "D'oh" moment: Private requires that the content be made inaccessible to the public, which won't do. However, Revisioning, while complex, does seem to be designed to do a similar thing.

http://drupal.org/project/revisioning

Will require some careful testing, though, as it is designed to support much more complex workflows than Revision In Moderation and there's at least one report of serious consequences from un-installing it:

http://groups.drupal.org/node/21147

Revision In Moderation is much simpler, and would be a much better solution, if it did not have this bug.

BTW, since this makes the 6.x branch unusable, I've escalated to critical.

Thanks very much for posting your changes, this seems to work like a charm.

(While I was re-testing to make sure that I'd be able to tell if it would be fixed, I realized that the defect was stranger than this issue thread revealed: Sometimes "Create new revision" would spontaneously toggle-off, and sometimes edited revisions would go into moderation. Just putting this down for issue documentation.)

See patch @ http://drupal.org/node/433608#comment-1556528

what do i do with a .diff file to make this module work?

This needs review. I'll be looking later this week but it could use other eyes as well.

For those new to using patches (in this case the 'diff' in #5) please see http://drupal.org/patch/apply

If the patch works, could it be committed to -dev, or preferably as the next alpha?
Not good to have this module in completely unusable state for D6.

Going through the issue queue, I wonder if this module is in risk of being abandoned?
There is certainly a need for this module as the alternative moderation modules are way too complex for most sites. This one should be a perfect fit, even small enough to be considered for D7 core?

It is not at risk of being abandoned. Very likely it will have a D7CX pledge soon as well as more attention to the issue queue. The status of this issue is needs review as we need reviewers to determine if the patch works before it could be committed. This module won't be included in D7 core but it will be available for D7.

I used the diff file and it worked for me (using a 6.14 core system). Would be nice if the patch could be integrated into 6.x version of this module.

Committed thanks. It helps patches get committed faster if reviewers update the status when conducting a review.

It seems like this patch has broken "Exempt administrators from revision moderation" flag.

Please refer to http://drupal.org/node/663750 for more info.

#663750: After updating to 6.x-1.0-alpha2 "Exempt administrators from revision moderation" does not work should be worked in that issue not by re-opening this one.