Hello,
I just started using your module and it looks very nice. If I could make a suggestion, could I ask you to output your Unordered List with two class attributes? (anything unique will do) For example
ul style="..." class="brilliantgallery brilliantgallery_$foldername"
This way designers could more easily style all galleries or even one particular gallery.
I noticed right now you use inline styles, which I understand are the best way for you to output the user's options (padding etc), so I suppose any external .css properties would need an !important to override the inline style.
Thank you for considering this.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | bg-css-support.patch | 2.58 KB | drpchris |
| #3 | bg-css-support.patch | 2.01 KB | drpchris |
Comments
Comment #1
drpchris commentedA great idea - simple to implement too!
Comment #2
vacilando commentedSure, just send me a patch or a chunk of code to implement against the current dev version and I'll do it.
Comment #3
drpchris commentedTomas, after you apply my code cleanup patches (http://drupal.org/node/530798), this will put in css support. It's a simple patch, so it should be readable and useful in any case.
It uses this form:
ul class="brilliant_gallery" id="brilliant_gallery_path_to_folder" style="...where the id takes the first element in the bg tag ('path/to/folder') and swaps out the '/' for '_' since I'm not sure that '/' is legal in CSS naming.
Comment #4
drpchris commentedComment #5
drpchris commentedYou think you've got it all, and then right after you submit a patch you realize you've missed something. Happens every time.
Forgot to uncomment the drupal_add_css line.