Mailsave_to_imagefield D6 port issue

Thanks, I incorporated this patch in #315381: make mailsave_to_imagefield work with mailhandler for importing images to cck imagefields.

How i "succeded"

My Fix was replacing Line 107 in mailsave_to_imagefield.module

      // Let's create the directory path if it hasn't been created already
      $directory = file_create_path($widget_image_path);
      file_check_directory($directory, FILE_CREATE_DIRECTORY);

      $destination = file_destination(file_create_path($widget_image_path .'/'. $file['filename']), FILE_EXISTS_RENAME);
      file_move($file['filepath'], $destination);

with

      // Let's create the directory path if it hasn't been created already
      
      	$directory = file_directory_path()."/".$widget_image_path; //was file_create_path($widget_image_path);
		module_load_include('inc','filefield','field_file');   // added
		field_file_check_directory($directory, FILE_CREATE_DIRECTORY);  // was file_check_directory($directory, FILE_CREATE_DIRECTORY)

      	$destination = file_destination(file_create_path($widget_image_path .''. $file['filename']), FILE_EXISTS_RENAME);
      	file_move($file['filepath'], $destination);

Note: I had to remove the trailing slash /

$destination = file_destination(file_create_path($widget_image_path .' / '. $file['filename']), FILE_EXISTS_RENAME);

With a little help...

I also downgraded to mailhandler 6.x-1.8 and downloaded an complete package of mailsave with fixed mailsave_to_imagefield from this post:

http://drupal.org/node/714402

Steps

1. Downgraded to mailhandler 6.x-1.8

• Project Mailhandler: http://drupal.org/project/mailhandler
• Mailhandler Releases: http://drupal.org/node/3266/release
• mailhandler 6.x-1.8: http://ftp.drupal.org/files/projects/mailhandler-6.x-1.8.tar.gz

• mailsave_to_imagefield Errors Fixed: http://drupal.org/node/714402
• Mailsave Module hacked-up and fixed: http://drupal.org/files/issues/mailsave.zip
• Aplied the above mentioned Hack on top: http://drupal.org/comment/reply/478150
• Fixed it by removing trailing slash /

Attached is my complete Version of Mailsave-Fixed-Refix and Mailhandler.

Confirming that the solution in comment number 3 works. I tried it (make sure you use mailhandler 1.8, not the latest version):

• With a single image: works!
• With multiple images: works!
• With foreign characters and spaces in file names: works!

Thanks to kloewer. Note that there are four other issues pertaining to this:

• #440312: plans to make Mailsave to CCK Imagefield compatible?
• #714402: mailsave_to_imagefield Errors Fixed
• #315381: make mailsave_to_imagefield work with mailhandler for importing images to cck imagefields.
• #611384: Mailsave to CCK ImageField incompatible with Drupal 6.13?

This issue we are on now is already marked as a duplicate, and I've marked the three others as duplicates, of #315381: make mailsave_to_imagefield work with mailhandler for importing images to cck imagefields. so let me suggest we continue the discussion there.

Same issue with mailsave_to_video

Solution: http://drupal.org/node/774294#comment-3063090

I just wanted to say that yes, comment #3 did work for me. ALSO, it's working using the latest version of mailhandler, which is 1.11. However, I did NOT need to make the change that kloewer made to generate $destination... the '/' does not need to be removed... I'm guessing he needed to remove it because there was a trailing slash on his $widget_image_path, but the imagefield module specifically says that there should not be. So, the only code that should need to be changed from what's described in http://drupal.org/node/714402 is around line 107:

$directory = file_directory_path()."/".$widget_image_path; //was file_create_path($widget_image_path);
module_load_include('inc','filefield','field_file');   // added
field_file_check_directory($directory, FILE_CREATE_DIRECTORY);  // was file_check_directory($directory, FILE_CREATE_DIRECTORY)

So, now we've got a fix for this module with the latest version of mailhandler... how about an update? :)