Revisioning and Input Formats

wickwood - June 28, 2009 - 17:22
Project:Revisioning
Version:6.x-2.x-dev
Component:User interface
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed
Description

I'm trying to simplify (idiot-proof) my site now, and I have found usablitily issues that are not directly resulting from the Revisioning and Module Grants modules themselves, but to the overall workflow of revisioning between Contributors and Moderators.

On my site I have WYSIWYG, Better Formats, Image Assist, and Inline modules installed to help Contributors and Moderators create pretty content for the site.

I have roles like:

  • Contributor - Pages
  • Moderator - Pages
  • Contributor - Images
  • Moderator - Images
  • Webmaster

And I have created Input Formats that correspond to the various Roles with different levels of advanced features, like adding images to the content or doing advanced formating.

The problem arises that even though Better Formats will assign a default Input Format for creating new content, if the Moderator saves an edited node created by a Contributor with a Moderator Input format, the Contributor cannot edit the revision.  And if the Moderator saves it to an 'In Draft - Only Author can edit' Workflow state when using Revisioning with Workflows, now both the Moderator and the Contributor are locked out of editing the node!

The problem gets worst when you add in the complication of Inline Images.  If the Moderator has Image privledges, and saves the node back down to an Input Format that does not allow [Inline] tags (tokens), then the those [Inline] tags for the images no longer show up as images. However, after changing back to Input Format that allows those tage, does bring it back so all is not lost.

The layers of complexity in creating a smooth workflow for revisioning is really mind boggling!

I obviously need to rethink my strategy here, and see what I can come up with satisfy the requirements of this project where we have some users who can add images and other who cannot and also how to prevent moderators from locking everyone out but the Super-Powerful-Webmaster from having acces to the content.

I'm fortunate that I am good test idiot and if there is way to break a site, I'll find it!

Any thoughts you might have on this are most welcome, and if you think this dicussion belongs somewhere else, let me know that, too.

Steve

#1

RdeBoer - June 28, 2009 - 22:55

Hi Steve,
Well you've clearly become a publication approval workflow super user and expert, going way beyond where anyone's gone before!

Like you said, the issue you have may not be a Revisioning one, but I'm happy for it to live here for a while until someone feels it belongs somewhere else.
I must admit I haven't used any of the modules you mention, so without going into it as deep as you've done already and recreating your setup, I can't really comment on why you're seeing this behaviour.

One tip that may help. To find out which module is denying access I would recommend the following. In the file module_grants.module you'll find a function module_grants_node_access(...). In it are two commented lines that start with //drupal_set_message(.... Just remove the leading slashes, click around on your site, and you should see some debug info at the top of your screen regarding the operations (view, update, delete) that are attempted on the various pieces of content and whether access is granted (access code > 1) or not (access code = 0).

Good luck!
Rik

#2

wickwood - June 29, 2009 - 16:28

Hello Rik,

Yes, I do feel out there!

I know that the problem of locking out both the Contributor and the Moderator from the content is the result of saving the node with 'Moderator Input Format' and a Workflow State of 'In Review - Only Contributor Can Edit' at the same time.

The Moderator Input Format locks out the Contributor, and
the Workflow State locks out the Moderator.

What I decided to do was eliminate the different Input Formats and just use one for all Moderators and Contributors that I call 'WYSIWYG Input Format'. This gives authors more formatting options and allows anyone who is a Contributor to add images to their content with Image Assist.

But, since everything is going to be reviewed by a moderator anyway, there should be no harm done by giving more users these options.

Also, Image Assist doesn't allow users to add their own images unless they also have the permissions to create Image Content-types. So basically Contributors will be able to add any previously approved images from any approved imaged gallery.

I actually like this arrangement much better. Not only does it solve a lot of problems, it's simplier and creates a much better workflow since no one except Super-Webmaster Roles will ever have to deal with selecting Input Formats.

Also, Better Formats module lets one choose which formats are available for different node types. So I only allow 'WYSIWG Input Format' to Contributors and Moderators for content-types like Blogs and Pages, and only allow Filtered HTML for comments and forums. This prevents people from adding pictures from to the comments and forums, allows more general users to post comments and forum posts, and at the same time the Forum Moderators do not get the access to 'WYSIWG Input Format' that they do not need.

So I'm quite happy with the way everything is working out and I think it will be smooth for my client and their people with minimal skills to use.

I feel like I could write a book now on revisioning in Drupal, or at least good chapter. And when I get my work done here, I think I will for my own reference as well everyone else.

Thanks for the Tip for uncommenting the trouble shooting code. That I'm sure will come in handy in from time to time.

Steve

#3

RdeBoer - July 1, 2009 - 03:59
Status:active» closed

Hi Steve,
Another great find to include in your write-up/tutorial/chapter/lament about "content approval and publication workflows"!
Closing this issue.
Rik

 
 

Drupal is a registered trademark of Dries Buytaert.