Posted by Magnity on July 5, 2009 at 4:00pm
Jump to:
| Project: | Storm |
| Version: | 7.x-1.x-dev |
| Component: | Storm.module |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
The aim is to get the port to D7 completed so that a stable Storm release for D7 will be ready by the time that the Drupal 7 core release is made (D7CX)
Comments
#1
I was looking for source od D7CX tag, and what it exactly means :). Here it is: http://cyrve.com/d7cx (if someone else wants to know).
And I would like to help you in this effort, it is very important step (or better: leap :) ).
#2
OK - I have tagged HEAD as being the 7.x development release. Therefore, there is something to patch against.
Notes:
- I have not done any code changes at all so far - therefore it will not even install on a D7 system atm.
- HEAD was an old version of Storm - i'm not sure from when. Therefore, it won't be totally up to date on changes. I'm not sure when the branch happened even so I'm not sure when its from. When patching, please specify whether it is a patch from the D6 development release or from HEAD (D7 dev release). It may be easier to do it from the D6 one for now.
Code freeze isn't until Sept 1st, so i don't feel overly rushed to get patches in until then - but from that point it'd be good to really push on so that we can get a stable version out for D7 release.
Lets use this issue to record overall progress and separate issues for specific steps / patches / bugs / issues etc.
Thanks.
#3
Progress with port to D7:
- Storm dashboard displays ok
- Most permissions changed over.
- Bug with adding nodes when Storm core is enabled
- Need to redo list pages. Currently just showing simply "Array" plus errors.
#4
I have installed Drupal 7.x-dev (night build 04.12.2009) and storm-7.x-1.x-dev
Every storm's page has an errors...
What versions should be used to see features of storm?
Thanks for greate module.
#5
The port to D7 is still in progress.
If you're looking to test out Storm, then try the D6 version.
#6
Update:
Storm Knowledgebase is almost fully ported to D7.
- Access controls need checking
- Needs upgrade path from D6
- Needs Field API support to be added to the Views module (#626704: Build views integration for field.module). Currently the list view is incomplete due to this.
Now that this simple-ish one is out of the way, I think Storm Organization comes next...
#7
+1 Subscribed
- As Storm and Ubercart (hopefully will be easier to integrate come D7?) are pretty much the only modules I use, this port is pretty important to me. I want to switch to D7 as soon as I can
#8
Subscribing...
#9
Subscribing
#10
Subscribing
I am using Project Issue Tracker on D6, but I am considering setting up a brand new D7 site (much easier, although there is still a lot of room for improvement). Since I don not maintain software but publishing project, Storm may be closer to my expectations. Plus, for now, it is the only D7 project tracker, according to this page.
#11
Let me just update on this. Due to the changes in maintainer this has fallen a little bit by the wayside. However, I am quite keen that we still keep to the D7CX pledge of getting a stable D7 release out by the time that Drupal 7.0 is released. The number of critical issues for D7 (113 at this moment) is dropping fast now, so I suspect that we don't have all too long now.
I'm quite busy on other projects at the moment, but in around 3 weeks, I should have time to focus more on Storm.
It may be that some of the Fields API integration has to be put on hold to get an initial release out. Which is a shame, because the plan was to be rid of the attributes module - but that may have to be for now.
Obviously everyone who has subscribed to this issue has an interest in seeing the D7 port come out. Therefore, it would be great if people could comment and commit to helping out on this. As I said, hopefully in about 3 weeks I will have a bit more time to spend on it.
#12
I am very interested. Unfortunately, I cannot contribute any kind of code.
#13
Subscribing...
#14
Just to update this issue, I hope to do a significant amount of work on this during today and tomorrow. I will use separate issues to test patches etc. Please do get involved if you have some time.
#15
subscribing
#16
subscribing
#17
Hi all,
Here is the current status of the D7 port. I have started this several times, but have never had time to get far enough to make it worthwhile.
Unless others chip in with their time, it is unlikely this will be done soon.
Something that would really help is amending the d6 version to utilise other modules such as views. I have listed a few issues in the roadmap for 6.x-1.35.
I look forward to everyone that has subscribed to this issue doing a small bit themselves to help.
#18
I think Storm could be a Feature in Drupal 7. More and more feature modules are coming up on drupal.org. That might make it easier to build Storm for D7? Features for D7 has been sort of ready to use for a couple of weeks now. What do you think?
#19
Features is a topic for a different issue. I have had previous offline discussions about it and have not been persuaded, but tbh I am not up to speed on exactly how it would affect storm.
I think this issue should remain to discuss a direct port of the current drupal 6 version into drupal 7.
#20
subscribe
#21
subscribe
#22
subscribe
#23
Out of curiosity I ran storm.module through coder, other than dumb little changes to the coding standard (like string concatination now requiring spaces on both sides of the ".") most of the issues I see are fairly manageable. The only exception is the DBTNG conversion as hook_db_rewrite_sql is gone in D7 (something I think was a good idea) that means a lot of query re-writing for Storm. Given that Storm uses hook_db_rewrite_sql to enforce all of it's security that means more fun with tests. From what I can tell the best strategy is to move a system where hook_storm_rewrite_where_sql is replaced by hook_query_storm_node_access_alter see http://drupal.org/node/224333#db_rewrite_sql and storm_db_rewrite_sql is dropped altogether.
For example in the stormticket module in lieu of stormtimetracking_storm_rewrite_where_sql($query, $primary_table, $account) it would be stormticket_query_storm_node_access_alter(QueryAlterableInterface $query). I get hook_query_storm_node_access_alter because I'm adding $query->addTag('storm_node_access') to the query object in the sample below from line 901 of storm.module (6.x-2.x-dev branch):
Replace
$sql = "SELECT n.nid FROM {node} AS nINNER JOIN {stormproject} AS spr
ON n.vid=spr.vid
WHERE n.status=1
AND n.type='stormproject'
AND spr.organization_nid=%d";
$sql = stormproject_access_sql($sql);
$result = db_query(db_rewrite_sql($sql), $organization_nid);
while ($project = db_fetch_object($result)) {
With
$query = db_select('node', 'n');$spr_alias = $query->join('stormproject', 'spr', 'n.vid=spr.vid');
$query->fields('n', array('nid'));
$query
->condition("n.status", 1)
->condition("n.type", 'stormproject')
->condition("{$spr_alias}.organization_nid", $organization_nid);
$query->addTag('storm_node_access');
$result = $query->execute();
// TODO: update stormproject_access_sql
$sql = stormproject_access_sql($sql);
while ($project = $result->fetchObject()) {
$projects[] = $project->nid;
}
I haven't figured out where the various _access_sql functions and storm_rewrite_sql fit into this plan, but then I only have an hour or two into this and most of that was spent trying to get rid of annoying syntax issues pointed to be coder :)
#24
I have to admit i'm not quite sure I understand the reason for the two sets of functions that re-write the sql for node access purposes.
It seems, and I'm sur eI'm missing something here, that various _access_sql functions and storm_rewrite_sql functions do about the same thing as hook_storm_rewrite_where_sql. I know the resulting SQL is different but what is it that necessitates the two sets of nearly identical functions? ideally there would be a more efficient way to do that.
#25
Subscribing
#26
sub
#27
Getting an error when trying to install the Storm - Organizations module:
FieldException: Attempt to update an instance of a nonexistent field . in field_update_instance() (line 524 of /home/.../public_html/dev/drupal/modules/field/field.crud.inc)
#28
Subscribing
#29
The installation passed w/o any errors, but when attempting to open Storm dashboard the following error message is displayed:
Fatal error: Call to undefined function stormorganization_access() in /var/www/html/cm7/sites/all/modules/storm/storm.module on line 644Shouldn't be name of this function not "stormorganization_access_sql"?
The site was migrated from Drupal 6.20.
#30
Subscribing
#31
subscribing
#32
Subscribing
#33
Subscribing
#34
Subscribing.
#35
Subscribing
#36
Subscribing
#37
subscribing
#38
Subscribing
#39
subscribing.
#40
subscribing
#41
subscribe
#42
Changing issue title so it doesn't get lost in dashboard
#43
Hi all,
Here is an update on where Storm is currently at, especially considering that people are asking when Storm will be ported to run with Drupal 7 core.
Unfortunately, the number of people who are actually helping out with issues (whether this be to answer questions, ensure full information is available on bug requests, or to code solutions) seems to be decreasing. Furthermore, this is directly impacting the rate of development of Storm.
Currently, my main focus is on getting a few key features (such as full use of the views module) into the 6.x-2.x branch, so that I can start point releases on that branch and make it the recommended version.
Once this is complete, I will move my focus to porting that branch to Drupal 7. However, this will be a significant effort, and I may not have time for it unless Storm users step up and help, either by direct development, sponsorship, or either taking the load of some of the bug fixes and tasks that need to be done outside of the port to Drupal 7.
I am not suggesting any timescale for the port, as it is dependent on when I have time to do so, and how much (if any) support comes from others.
#44
subscribing
#45
subscribe
#46
subscribing
#47
Has any progress been made since May?
Is there any kind of roadmap for the project? I looked in the group, but I didn't see anything.
I'm wondering where you plan to go with the D7 version once you've been able to get it ported and stable. Especially if you are going to work on upgrading the interface to something modern.
#48
I don't think anything changed from the statement made by juliangb in #43.
There should be a stable release of the branch 2.x first, which can be ported later.
In my opinion the drupal 7 version of storm should do a lot with the core fields of d7, but this means a lot of rewrite, maybe to start form scrap...
#49
Not meaning to pester you, but I too am anxious for a Drupal 7 release and would really appreciate a best guess time-frame on when it should be available.
Thanks.
#50
Drupal 7 is working with entities and all recent contributed modules are based on entities.
Porting from D6 makes no sense at all, since storm is not just a one little module but a whole set, working together. The D7 version will need to be a rewrite from scratch, since all containing submodules will be need to based on the recent developments in D7. So +1 for a whole rewrite...but, it will be a lot more flexible in the end.
I have been working with D7 since it came out, and I think about now it is very wise to switch to D7, since the most important modules are fairly stable. And, the whole D7 entity based framework makes it also easier to build.
#51
I would refer everyone who is commenting, to my last comment in #43.
Please think about whether you could help out with Storm. Even if it isn't directly with the port, if we can have more eyes on bugs / necessary tasks, then it will be easier to move towards Drupal 7.
#52
@Yuri: that is not true. The recommended porting procedure is to make minimal changes from the latest 6.x branch, then create a new 7.x-2.x branch to contain the updated 7.x coding. So juliangb's statements are correct and the way to go.
#53
So, if I'd like to help test things, would it be wiser to spend my time on 6.x-2.x, or on 7.x-1.x?
#54
I would recommend spending the time testing 6.x-2.x. We are hoping to make a stable release on this branch soon.
Once the 2.x release is out, we can discuss the best way forward for Storm-like functionality in Drupal 7.
#55
I think now would be a good time to re-ignite this discussion.
For anyone that hasn't followed it closely, the 6.x-2.x branch has now reached betas, and I'm confident that we'll be moving on to a full release fairly soon. Thus, it is time to think about Drupal 7 again.
Before going full steam ahead on porting, I'd like to get views on whether this is the right approach. Are there any other modules that mean Storm is not necessary for Drupal 7? The only similar module that seems to have D7 code is the support module, but this offers only a small part of Storm functionality. Any thoughts?
On the assumption that we will port Storm in it's entirety, here's a proposed plan of action:
I'd welcome any options, and just as importantly, is there anyone that is willing to commit to helping out on this?
#56
Wow, I am really looking forward to this. I have been using this module on D6 for my own projects and will volunteer my support in testing and development. I'm no PHP expert but I have some basic development knowledge in D6, especially theming, and would appreciate the chance to work on something in D7.