Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We currently have code and an accompanying cvs commit message convention that links issues to commits (e.g. "Patch #46746 by Matt" will appear as a link to that issue in http://drupal.org/cvs ).
We could add a convention like "Patch #46746 by u:Matt" to allow backlinking to the user.
Going a step further, we could maybe add a tracker option for listing commit message credits.
Comments
Comment #1
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedThis seems to be true for all recent projects, including mine. I poked a bit around and even inserted the correct nid but http://drupal.org/project/developers/57166 is still not showing anything although the query in function cvs_get_project_contributors($nid) works...
Comment #2
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedlast comment was for http://drupal.org/node/59529
I think enforcing conventions on cvs committers is a bad idea.
Comment #3
catchI'm not sure why this would force conventions on committers - it'd be optional same as #1234 no?
Comment #4
sunIntroducing standards is must for rapidly growing projects. We should have a standard for commit messages, too.
It's important, because it simplifies co-maintaining and taking over projects. Having better maintained projects will lead to less duplicate modules, more feature-rich modules, better support and documentation, aso. It also makes CVS logs cleaner and more comprehensive for actual users of a project. Furthermore, if we have a standard, we can build new features and logic upon it, like this issue suggests.
Specifically, I want to propose to convert the best practice for commit messages into a forced requirement for each commit.
A syntax validation would be a relatively simple regular expression.
Comment #5
Michelle-1 on forcing it.
I grudgingly agreed to try following that even though I think it looks silly for a singly maintained project but there's always going to be things that really don't fit. What if there's no issue # to put in there, for example? Plus, I'm not fond of the simple list of names. If I commit something that I spent a lot of time coding based on a rough suggestion by someone else, I don't want to put "Michelle, SomeoneElse" yet I still want to give them credit for the idea. There needs to be flexibility.
So, encourage by all means but force? No thanks.
Michelle