"Unsubscribe" link returns "page not found"

rdosser - July 24, 2009 - 20:03
Project:Simplenews
Version:6.x-1.0-rc6
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

The unsubscribe links that my newsletters are generating are of the form:

http://[mysite]/newsletter/confirm/remove/7a7115a8b90t2

But when followed, the server returns "Page not found. The requested page could not be found."

How can I determine what's going wrong?

Thanks,
Ralph Dosser

#1

Dave.Ingram - September 1, 2009 - 19:23

I'm getting the same thing. It happened when I sent a test mail. The email address I used does not have an account on the site.. not sure if that would make a difference. Any help would be appreciated.

#2

LiveLoveWorkPlay - September 11, 2009 - 23:46

Same issue here. Quite annoying for users that want to unsubscribe. It should be easy to unsubscribe, (likewise, subscribe) for all users logged in or not ... the issues for not logged in users are truly difficult to justify.

#3

jamespharaoh - September 12, 2009 - 11:08

This happens to me when the newsletter taxonomy field is set to none. The code which checks this looks a bit suspect. The attached patch seems to fix this.

AttachmentSize
simplenews.patch 1.07 KB

#4

Sutharsan - September 12, 2009 - 11:31

@all please supply the failing unsubscribe link as rdosser did. The format of the link is: newsletter/confirm/[remove|add]/<10 char unique key>t
snid = subscription id
tid = taxonomy term id

@rdosser: your snid is '0'. This is probably the link found in the test email. This link fails by design if your test address is not subscribed.

@jamespharaoh: the taxonomy field is now required also for test mails. What does your patch fix exactly?

#5

jamespharaoh - September 17, 2009 - 09:07

The original line:
- Makes a redundant second call to isset($node->taxonomy[$vid]), short circuit boolean evaluation prevents this from being reached if it is going to return false.
- Relies on boolean operator precedence binding && tighter than ||. This is purely stylistic but I find it very confusing.
- Fails if the taxonomy is not set but will succeed if it is empty. I'm pretty sure this is unintentional.

Just to be clear, my version fails on an unset, empty or invalid taxonomy term. The original line fails on an unset or invalid term but succeeds on an empty one.

Sorry for not attaching a description in my original patch, I think I was in a bit of a hurry.

#6

goloops - September 19, 2009 - 14:11

i also got the same problem, could you tell me how to fix it? i am not a programmer, hope there is a step by step guide for me to follow. thanks a lot...:)

#7

Sutharsan - September 19, 2009 - 17:46

@goloops: start with providing details of the problem. What is the link, which taxonomy related modules do you use, any errors on screen or in the log.

#8

Edgar Saumell - October 15, 2009 - 12:18

Similar issue here. Not sure to open a new one...

My unsubscribe links are of the form:
http://www.example.com/newsletter/confirm/remove/

So user get a 404 error.

I have Mimemail 6 dev module installed, and happens with both HTML and plain text mails.
My setup don't use i18n module, but use:
Content translation 6.14
Locale 6.14
Localization client 6.x-1.7
I have one non English language added that is the default one.

All works fine with mails generated from Simplenews block while subscribing/unsubscribing.

#9

Sutharsan - October 24, 2009 - 16:45
Status:active» fixed

@jamespharaoh: thanks for the patch and sorry for the delay. Patch committed to HEAD and 6.x-1.x-dev.

#10

System Message - November 7, 2009 - 16:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.