Closed (fixed)
Project:
Simplenews
Version:
6.x-1.4
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Jul 2009 at 20:03 UTC
Updated:
23 Feb 2013 at 03:37 UTC
Jump to comment: Most recent file
Comments
Comment #1
Dave.Ingram commentedI'm getting the same thing. It happened when I sent a test mail. The email address I used does not have an account on the site.. not sure if that would make a difference. Any help would be appreciated.
Comment #2
mradamjohn commentedSame issue here. Quite annoying for users that want to unsubscribe. It should be easy to unsubscribe, (likewise, subscribe) for all users logged in or not ... the issues for not logged in users are truly difficult to justify.
Comment #3
jamespharaoh commentedThis happens to me when the newsletter taxonomy field is set to none. The code which checks this looks a bit suspect. The attached patch seems to fix this.
Comment #4
sutharsan commented@all please supply the failing unsubscribe link as rdosser did. The format of the link is: newsletter/confirm/[remove|add]/<10 char unique key>t
snid = subscription id
tid = taxonomy term id
@rdosser: your snid is '0'. This is probably the link found in the test email. This link fails by design if your test address is not subscribed.
@jamespharaoh: the taxonomy field is now required also for test mails. What does your patch fix exactly?
Comment #5
jamespharaoh commentedThe original line:
- Makes a redundant second call to isset($node->taxonomy[$vid]), short circuit boolean evaluation prevents this from being reached if it is going to return false.
- Relies on boolean operator precedence binding && tighter than ||. This is purely stylistic but I find it very confusing.
- Fails if the taxonomy is not set but will succeed if it is empty. I'm pretty sure this is unintentional.
Just to be clear, my version fails on an unset, empty or invalid taxonomy term. The original line fails on an unset or invalid term but succeeds on an empty one.
Sorry for not attaching a description in my original patch, I think I was in a bit of a hurry.
Comment #6
goloops commentedi also got the same problem, could you tell me how to fix it? i am not a programmer, hope there is a step by step guide for me to follow. thanks a lot...:)
Comment #7
sutharsan commented@goloops: start with providing details of the problem. What is the link, which taxonomy related modules do you use, any errors on screen or in the log.
Comment #8
edgar saumell commentedSimilar issue here. Not sure to open a new one...
My unsubscribe links are of the form:
http://www.example.com/newsletter/confirm/remove/
So user get a 404 error.
I have Mimemail 6 dev module installed, and happens with both HTML and plain text mails.
My setup don't use i18n module, but use:
Content translation 6.14
Locale 6.14
Localization client 6.x-1.7
I have one non English language added that is the default one.
All works fine with mails generated from Simplenews block while subscribing/unsubscribing.
Comment #9
sutharsan commented@jamespharaoh: thanks for the patch and sorry for the delay. Patch committed to HEAD and 6.x-1.x-dev.
Comment #11
hemans2510 commentedComment #12
edgar saumell commentedAs of #9 http://drupal.org/node/530232#comment-2187134 this is fixed.