Hierarchal Select & Community Tags modules support - taxonomy_override_selector

I can not reproduce.

Try clearing your browser cache.

Do still see the rest of the AT widget? terms above the text box?

Unfortunately, I have not been able to reproduce this. Without more information there is little I can do.

I need something that points me in the right direction to the problem. An error? A partial debug? something.

As it stands now the issue could be caused by something specific to your Drupal install, your server, your PHP, or something completely else. It works on my servers and I haven't had any more bug reports on this yet. So at this point all I can do is wait for someone to give me an idea of where and/or why it is breaking on some servers and not others. Or we have to wait and see if we get enough bug reports with information that a pattern emerges that shows where the issue is.

I added this module to my ever growing list of modules today where 1.5 wouldnt do anything with my vocabularies. After reading this issue I tried 1.4 which worked straight away.

I traced a few things back where I found out that the javascript and css didnt even get loaded. As if it believes $ids is still empty:

  if (!empty($ids)) {
    drupal_add_css(drupal_get_path('module', 'active_tags') .'/active_tags.css', 'module');
    drupal_add_js(array('active_tags' => $ids), 'setting');
    drupal_add_js(drupal_get_path('module', 'active_tags') .'/active_tags.js', 'module');
  }

Unfortunately I cant do much more of a backtrace as I have too many modules going to rule them out 1 by 1.

Hope it helps you figure it out.

I have the same problem in a clean Drupal install. The widget doesn't appear at all because the condition isset($form['taxonomy']['tags']) in the function active_tags_form_alter() (line 51 in active_tags.module) is always false. The attached patch will remove the condition and everything works fine.

I hope this solves the problem for everyone. (Note full patch is attached to next comment)

Robin.

Follow up on my previous comment. The full patch is attached to this comment.

Robin

This is odd. I still can not reproduce this.

Those reporting can you supply some information:

1. Do you have the taxonomy enabled for your content type?

2. Is your taxonomy set configured as Tags?

3. Have you enabled active tags in your vocabulary settings?

The above 3 things have to be set for AT to work. A screen shot of the 3 check boxes is attached.

Planning to upgrade soon. So subscribing +1

In reply to your questions in comment #10: Taxonomy is enabled, The set is configured as Tags and I have active tags enabled in the vocabulary.

At my site I had the Hierarchical Select module enabled. When this module is active it sets the setting taxonomy_override_selector to true. This causes the core taxonomy module not to fill $form['taxonomy']['tags'] variable (see function taxonomy_form_alter in taxonomy.module).

This means that the current version of Active Tags is not compatible with Hierarchical Select or any other module that sets taxonomy_override_selector to true.

I'am only using Active Tags so my problem is solved by disabling Hierarchical Select, but others who need both modules can still benefit from my patch in comment #9.

I hope this helps.

Robin

Thanks for finding the issue rehos!

While your patch in #9 is valid it also causes a performance hit so I am extremely hesitant to make that change.

If other modules are overriding your taxonomy selector and telling taxonomy.module to not include it's selector, then there is little I can do because AT requires that the taxonomy tags selector is present in the form.

I will look into this more though and see if there is an acceptable way around this.

subscribing

After more research, here are my findings:

1. The 'taxonomy_override_selector' is globally set. Modules that use this variable do not realize the impact it has. The variable will prevent all taxonomy selectors and stops core taxonomy.module from loading terms. These modules are setting this variable and only recreating part of the functionality that they are disabling.
2. The functionality these modules override do not mimic core taxonomy.module. Instead they all do their own thing. This makes it difficult if not impossible correctly integrate with these solutions.
3. In most cases these modules and AT can not be used together at the same time on the same vocabulary because they all provide different taxonomy selectors. AT only works with the autocomplete tags style selectors.

If these modules mimicked core taxonomy.modules $node['taxonomy']['tags'] structure, some integration would be possible but more work would have to be done to prevent issues of users attempting to use them together.

Since only one module/selector can be used at any one time for a vocabulary, it would be best if we could create an API or standard solution that would allow the admin to choose/select this appropriately. As it sits now there is little area for integration with modules that are basically overriding all of core taxonomy.module(minus storage) with the 'taxonomy_override_selector' variable.

I will continue looking for a solution to allow these modules to work together but the near future is looking grim. Any real current solution would need to happen in these other modules not AT by these module properly mimicking core taxonomy features.

hi all,

I have the same problem, and I've checked that no other modules are modifying the taxonomy_override_selector variable.
At least not directly.

If you have ever installed a module that changes that variable it may be changed. Some modules don't change it back on uninstall as it is a global variable and could override other modules. And if you did not run uninstall of a module properly that does change it, it would change either.

Check you database in the variable table.

Hi dragonwize,

I've checked the variable table and taxonomy_override_selector doesn't exist. And the module is installed, active and bound to the vocabulary.
I've tried creating taxonomy_override_selector variable, setting it to 1, and 0, cleaning cache each time, but still nothing...

Thanks for your help.

@birwel: You have a different issue then. Please open a new issue and include as much information as possible about your problem. Screenshots of the node create screen as well as the taxonomy vocab settings screen are helpful.