Weblinks new and updated flags show even to author

izmeez - August 14, 2009 - 11:30
Project:Web Links
Version:6.x-2.1
Component:Miscellaneous
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed
Description

I am wondering if there is something I can do to stop having the "new" and "updated" flags appear to the author themselves on weblinks in views like recent posts? Usually for content, the "new" and "updated" flags don't appear to the author themselves forcing them to have to view the weblink just to clear the flag.

Thanks,

Izzy

#1

NancyDru - August 14, 2009 - 14:38

If you're talking about in the Views module, I have no clue, but there may be some checkbox to turn it off. If you're talking about somewhere else, I also have no idea since we don't use theme_mark.

#2

NancyDru - August 14, 2009 - 14:39
Status:active» postponed (maintainer needs more info)

#3

izmeez - August 14, 2009 - 17:36

Thanks, I am talking about through Views.
It occurs with Views default tracker "Recent posts" if enabled and all other views.

Izzy

#4

NancyDru - August 14, 2009 - 18:20
Status:postponed (maintainer needs more info)» by design

That would be normal for Tracker and has nothing to do with Web Links.

#5

izmeez - August 23, 2009 - 22:43

That's not the case when creating and updating other content types.

Izzy

Edit: This comment of mine is not correct, I see that the new and update flags do show with other content types.

#6

NancyDru - August 16, 2009 - 13:29

Well, you can ask in the Views queue and let us know what they say.

#7

NancyDru - August 21, 2009 - 14:32
Status:by design» active

Ah, I think I see what you're talking about - it's not Views, it's the "user/%/weblinks" page? I do see a theme('mark') there. And I see marks on my own stuff, which probably shouldn't be there.

#8

NancyDru - August 21, 2009 - 14:45
Status:active» fixed

Fix committed.

#9

izmeez - August 23, 2009 - 22:46

Nancy,

I'm happy to hear you spotted something but I think you are correct that my comment applies to the behaviour of Views and occurs with other content. I hate to open an issue in the Views queue because they are so busy and doing a great job but I think you're right that's were the comment belongs.

Thanks,

Izzy

#10

NancyDru - August 24, 2009 - 00:12

Actually, based on what I found, I believe the answer is actually a core issue, but very difficult to patch. Theme_mark or node_mark should be checking for the currently logged in user. In our code, I check for that and don't call theme_mark.

#11

izmeez - August 24, 2009 - 16:03

I have been using the Support module and it seems to be doing something also because I think that is why I noticed the difference. I'm not very familiar with php and haven't tried to look at what is being done there.

Izzy

#12

izmeez - August 24, 2009 - 17:31

I did open an issue in the Views queue http://drupal.org/node/557424 and now discovered today the problem seems to be resolved. I am not sure why but I am using the latest Views 6.x-2.x dev from Aug 22.

Izzy

#13

NancyDru - August 24, 2009 - 19:50

Well, if it's a duplicate of something already resolved, they will be quick to tell you.

Web Links should no longer be showing the marks in its user page.

#14

izmeez - August 25, 2009 - 16:11

I feel almost foolish having made these comments but I now have a better understanding of what is happening. I do think the comment that this is likely a core behaviour is correct.

What I have noticed is that when a node is viewed and then the user clicks on edit, after updating the node the user is returned to the node view and the "updated" flag is be cleared, so it does not appear on the tracker views.

If the user starts from a listing of nodes, such as Content or VBO and has an edit link available from that list, after the user edits the node they return to the list so the updated flag is not cleared until the user specifically views the node.

With weblinks, if a user views a weblink it appears as a node view with the edit option available. After editing, the user does not return to the node view but rather to the weblinks page, thus the updated flag is not cleared.

The behaviour is consistent with core and my question really does belong as a feature request to core.

Thanks so much for your patience and attention to my questions.

Izzy

#15

NancyDru - August 27, 2009 - 15:40
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.