$variable is not visible in commit message

http://drupal.org/cvs?commit=257292
http://drupal.org/cvs?commit=256552

I do not know if it is a limitation of cvs, or it is stripped at display.

Comments

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

CVS Keywords are dollar-sign delimited strings that CVS interprets and automatically expands.

added a comment to handbook page: http://drupal.org/node/52287

dww’s picture

dww
we/he/they
commented
Status: Active » Closed (works as designed)

@pasqualle: Deleted that comment. CVS keywords are for the files you check in to CVS, not the commit messages themselves. If you look, the $variable didn't show up in cvs (http://cvs.drupal.org/viewvc.py/drupal/drupal/includes/file.inc?view=log...) nor the log display here in the d.o DB. That tells me that Dries probably did something silly like this from the shell:

cvs commit -m "- Patch #561520 by Pasqualle: $variable is an object." includes/file.inc

His shell saw a " quoted string and tried to expand the $ variables. Since $variable had no value, that was replaced with an empty string.

The right thing to do (if you're going to use -m and pass the commit message as a command-line arg) is to use single quotes so that the shell doesn't try to interpret $ for variable substitution, like so:

cvs commit -m '- Patch #561520 by Pasqualle: $variable is an object.' includes/file.inc

This is UNIX 101 -- it has nothing to do with CVS nor d.o, nor the cvs.module.