updating system module: stuck at 58%

1) Are you sure it really is stuck? There are a number of upgrades which can take a long time. For example the update for drupal.org lasted up to 8 minutes on a dual processor machine.
2) If there were any errors, they should be found in your watchdog table.
--
Drupal services
My Drupal services

Try running the update with javascript turned off in your browser. This will allow you to see if there are any problems.
--
Gordon Heydon
Heydon Consulting

I started this site back in 4.5 and i've upgraded it to 4.6.3 successfully in the past and then just now i upgraded to 4.6.6 to make sure that I had the latest tables.
Now, I've just installed 4.7, and the little progress bar sticks at 58%.

What is 58% anyway?? I'd much rather have a verbose output that tells me what's going on and where, so i could know where this has hung.
It's totally hung, and it's been about 20 minutes.

here, upgrading from 4.6 to cvs.
same behaviour, stuck at 58%

can pass the dump, gerhard, if you like to (it's 333MB unpacked ;)

where is the exact URL to bugreport?

This is very annoying! I interim-upgraded from 4.5.0 to 4.6.6 - and my site, which has several hundred thousand records, runs fine.

If I create a copy of the 4.6.6 database, set access_check to false and browse directly to the 4.7.0 updata.php (necessary since I can't log in or see anything at all except error messages), it zooms to 58% and then stays there until the php script times out. I then eventually get the error page which says:

The update process was aborted prematurely while running update #159 in system.module. All other errors have been logged. You may need to check the watchdog database table manually.

(there are no other errors shown)

Below is the snippet which shows what is happening....

--------------------
Update #157

* DELETE FROM {url_alias} WHERE src = 'node/feed' AND dst = 'rss.xml'
* INSERT INTO {url_alias} (src, dst) VALUES ('rss.xml', 'node/feed')

Update #158

* ALTER TABLE {old_revisions} ADD done tinyint(1) NOT NULL DEFAULT 0
* ALTER TABLE {old_revisions} ADD INDEX (done)

Update #159

* UPDATE {sequences} SET id = 1288 WHERE name = '{node_revisions}_vid'
* UPDATE {sequences} SET id = 1302 WHERE name = '{node_revisions}_vid'
* UPDATE {sequences} SET id = 1304 WHERE name = '{node_revisions}_vid'
* UPDATE {sequences} SET id = 1306 WHERE name = '{node_revisions}_vid'
...
...
... (this continues with 'SET id = xxxx' incrementing by one, forever.....)
-------------------
I tried to go into update.php and completely skip doing update 159, since at one point I searched these archives (for 'update 159') and found this thread: http://drupal.org/node/40662

(begin quote from thread)
---------------------------------
#3 submitted by killes@www.drop.org on December 11, 2005 - 11:07

If you did create the site in September then you would not run update.php at all and the update that created the old_revisions table.
#4 submitted by beginner on December 11, 2005 - 15:50

So, what about the error message? Do we need those tables or not? Do I need to create them "manually"?
#5 submitted by killes@www.drop.org on December 11, 2005 - 16:23

The table is created in update 146 and holds old revisions that were created using the old revision table. For core node types, these old revisions are put into the node_revisions table in update 158/159. Non-core modules will need to create separate update scripts to retrieve their revisions.

A possible fix could be to create this table in update 158 if it does not exist. Don't know if this would work with pgsql.
#6 submitted by Cvbge on December 13, 2005 - 20:31
Priority: normal » minor
Status: active » won't fix

It's not trivial for postgres.

This error can't happen if you upgrade from 4.6. If you're using cvs - you should be ready to have some problems (and this one is completly safe afaik).

IMO this is not worthy fixing.
---------------------------------------
(end quote from thread)

Anyway, if this is true, I can totally skip this update, right? I edited update.php - the function fix_update_schema_version() - and below the switch case statement, I found this statement;

variable_set('update_170_done', TRUE);

I added a line below that which reads

variable_set('update_159_done', TRUE);

and tried again. No luck! Apparently the line

variable_set('update_170_done', TRUE);

only gets executed if

if (update_start=variable_get('update_start, FALSE)) {

so then I tried moving

variable_set('update_159_done', TRUE);

*above* the if statement...but that also did nothing!

WHERE ARE THE ACTUAL UPDATE INSTRUCTIONS STORED? I can't seem to find the file that contains them. I would be perfectly happy to go into that file and get rid of the line that causes the endless loop...

HELP HELP HELP!!!

Well, I got this error too. I've contacted Killes to send him my SQL dump... let's keep our fingers crossed.

Update system from 129, og from 1.

After a few seconds ("updating system module" is never displayed):

warning: reset() [function.reset]: Passed variable is not an array or object in /...xxx.../update.php on line 405.

After the second attempt:

    * user warning: Can't DROP 'title'; check that column/key exists query: update_sql ALTER TABLE boxes DROP INDEX title in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Table 'contact' already exists query: update_sql CREATE TABLE contact ( subject varchar(255) NOT NULL default '', recipients longtext NOT NULL default '', reply longtext NOT NULL default '' ) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate entry 'rss.xml' for key 2 query: update_sql INSERT INTO url_alias (src, dst) VALUES ('node/feed', 'rss.xml') in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Unknown column 'subject' in 'contact' query: update_sql ALTER TABLE contact CHANGE subject category VARCHAR(255) NOT NULL in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Multiple primary key defined query: update_sql ALTER TABLE contact ADD PRIMARY KEY (category) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Table 'node_revisions' already exists query: update_sql CREATE TABLE node_revisions SELECT nid, nid AS vid, uid, type, title, body, teaser, changed AS timestamp, format FROM node in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate column name 'log' query: update_sql ALTER TABLE node_revisions ADD log longtext in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Multiple primary key defined query: update_sql ALTER TABLE node_revisions ADD PRIMARY KEY vid (vid) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate key name 'nid' query: update_sql ALTER TABLE node_revisions ADD KEY nid (nid) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate key name 'uid' query: update_sql ALTER TABLE node_revisions ADD KEY uid (uid) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Table 'old_revisions' already exists query: update_sql CREATE TABLE old_revisions SELECT nid, type, revisions FROM node WHERE revisions != '' in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Can't DROP 'type'; check that column/key exists query: update_sql ALTER TABLE node_revisions DROP type in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Table 'search_dataset' already exists query: update_sql CREATE TABLE search_dataset ( sid int(10) unsigned NOT NULL default '0', type varchar(16) default NULL, data longtext NOT NULL, KEY sid_type (sid, type) ) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Incorrect table definition; there can be only one auto column and it must be defined as a key query: update_sql ALTER TABLE contact DROP PRIMARY KEY in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate column name 'cid' query: update_sql ALTER TABLE contact ADD COLUMN cid int(11) NOT NULL PRIMARY KEY auto_increment in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate key name 'category' query: update_sql ALTER TABLE contact ADD UNIQUE KEY category (category) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate column name 'weight' query: update_sql ALTER TABLE contact ADD COLUMN weight tinyint(3) NOT NULL DEFAULT 0 in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate column name 'selected' query: update_sql ALTER TABLE contact ADD COLUMN selected tinyint(1) NOT NULL DEFAULT 0 in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate column name 'done' query: update_sql ALTER TABLE old_revisions ADD done tinyint(1) NOT NULL DEFAULT 0 in /var/...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Table 'poll_votes' already exists query: update_sql CREATE TABLE poll_votes ( nid int(10) unsigned NOT NULL, uid int(10) unsigned NOT NULL default 0, hostname varchar(128) NOT NULL default '', INDEX (nid), INDEX (uid), INDEX (hostname) ) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Table 'client' already exists query: update_sql CREATE TABLE client ( cid int(10) unsigned NOT NULL auto_increment, link varchar(255) NOT NULL default '', name varchar(128) NOT NULL default '', mail varchar(128) NOT NULL default '', slogan longtext NOT NULL, mission longtext NOT NULL, users int(10) NOT NULL default '0', nodes int(10) NOT NULL default '0', version varchar(35) NOT NULL default'', created int(11) NOT NULL default '0', changed int(11) NOT NULL default '0', PRIMARY KEY (cid) ) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Table 'client_system' already exists query: update_sql CREATE TABLE client_system ( cid int(10) NOT NULL default '0', name varchar(255) NOT NULL default '', type varchar(255) NOT NULL default '', PRIMARY KEY (cid,name) ) in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Table 'file_revisions' already exists query: update_sql CREATE TABLE file_revisions ( fid int(10) unsigned NOT NULL default 0, vid int(10) unsigned NOT NULL default 0, description varchar(255) NOT NULL default '', list tinyint(1) unsigned NOT NULL default 0, PRIMARY KEY (fid, vid) ) /*!40100 DEFAULT CHARACTER SET utf8 */ in /...xxx.../includes/database.mysql.inc on line 120.
    * user warning: Duplicate entry '1-331' for key 1 query: update_sql INSERT INTO file_revisions SELECT DISTINCT fid , vid, description, list FROM files_tmp in /...xxx.../includes/database.mysql.inc on line 120.

Normalizing files table failed. A backup of the original table called {files_backup} remains in your database.

Query log (failed only):

The following queries were executed
system module

Update #131

    * Failed: ALTER TABLE {boxes} DROP INDEX title

Update #133

    * Failed: CREATE TABLE {contact} ( subject varchar(255) NOT NULL default '', recipients longtext NOT NULL default '', reply longtext NOT NULL default '' )

Update #138

    * Failed: INSERT INTO {url_alias} (src, dst) VALUES ('node/feed', 'rss.xml')

Update #143

    * Failed: ALTER TABLE {contact} CHANGE subject category VARCHAR(255) NOT NULL
    * Failed: ALTER TABLE {contact} ADD PRIMARY KEY (category)

Update #146

    * Failed: CREATE TABLE {node_revisions} SELECT nid, nid AS vid, uid, type, title, body, teaser, changed AS timestamp, format FROM {node}
    * Failed: ALTER TABLE {node_revisions} ADD log longtext
    * Failed: ALTER TABLE {node_revisions} ADD PRIMARY KEY vid (vid)
    * Failed: ALTER TABLE {node_revisions} ADD KEY nid (nid)
    * Failed: ALTER TABLE {node_revisions} ADD KEY uid (uid)
    * Failed: CREATE TABLE {old_revisions} SELECT nid, type, revisions FROM {node} WHERE revisions != ''

Update #147

    * Failed: ALTER TABLE {node_revisions} DROP type

Update #150

    * Failed: CREATE TABLE {search_dataset} ( sid int(10) unsigned NOT NULL default '0', type varchar(16) default NULL, data longtext NOT NULL, KEY sid_type (sid, type) )

Update #153

    * Failed: ALTER TABLE {contact} DROP PRIMARY KEY
    * Failed: ALTER TABLE {contact} ADD COLUMN cid int(11) NOT NULL PRIMARY KEY auto_increment
    * Failed: ALTER TABLE {contact} ADD UNIQUE KEY category (category)

Update #154

    * Failed: ALTER TABLE {contact} ADD COLUMN weight tinyint(3) NOT NULL DEFAULT 0
    * Failed: ALTER TABLE {contact} ADD COLUMN selected tinyint(1) NOT NULL DEFAULT 0

Update #158

    * Failed: ALTER TABLE {old_revisions} ADD done tinyint(1) NOT NULL DEFAULT 0

Update #164

    * Failed: CREATE TABLE {poll_votes} ( nid int(10) unsigned NOT NULL, uid int(10) unsigned NOT NULL default 0, hostname varchar(128) NOT NULL default '', INDEX (nid), INDEX (uid), INDEX (hostname) )

Update #166

    * Failed: CREATE TABLE {client} ( cid int(10) unsigned NOT NULL auto_increment, link varchar(255) NOT NULL default '', name varchar(128) NOT NULL default '', mail varchar(128) NOT NULL default '', slogan longtext NOT NULL, mission longtext NOT NULL, users int(10) NOT NULL default '0', nodes int(10) NOT NULL default '0', version varchar(35) NOT NULL default'', created int(11) NOT NULL default '0', changed int(11) NOT NULL default '0', PRIMARY KEY (cid) )
    * Failed: CREATE TABLE {client_system} ( cid int(10) NOT NULL default '0', name varchar(255) NOT NULL default '', type varchar(255) NOT NULL default '', PRIMARY KEY (cid,name) )

Update #173

    * Failed: CREATE TABLE {file_revisions} ( fid int(10) unsigned NOT NULL default 0, vid int(10) unsigned NOT NULL default 0, description varchar(255) NOT NULL default '', list tinyint(1) unsigned NOT NULL default 0, PRIMARY KEY (fid, vid) ) /*!40100 DEFAULT CHARACTER SET utf8 */
    * Failed: INSERT INTO {file_revisions} SELECT DISTINCT fid , vid, description, list FROM {files_tmp}

Superficially, things look okay. Exceptions are: national characters are now mangled, probably because of the conversion to UTF-8, and the database schema for organic groups seem broken (missing column og.directory).

The issue of the update hanging at '58%' is solved for me by applying this patch.

http://drupal.org/node/61867

-------

*nix instructions.
in your drupal 4.7 directory:

wget http://drupal.org/files/issues/infinite_loop.patch.txt
patch -b -p0 < infinite_loop.patch.txt

then proceed with the update as per normal