Closed (fixed)
Project:
Project
Version:
x.y.z
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
18 May 2006 at 22:07 UTC
Updated:
23 Jun 2006 at 16:31 UTC
Jump to comment: Most recent file
now that http://drupal.org/node/18260 has been committed, the project module no longer works against CVS HEAD. :( at least in local testing, what used to be a link called "follow-up" at the bottom of all issues becomes a link like this: < and it brings you to "page not found". :( no time to debug this ATM, but i wanted to create an issue for it in case anyone cares to work on it. i'm attaching a screenshot of the broken issue page from a local test site.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | project_hook_link_fix.patch.2 | 7.14 KB | dww |
| #5 | project_hook_link_fix.patch | 3.28 KB | dww |
| #1 | link.patch | 1.25 KB | m3avrck |
| project_link_alter_broken.png | 90.7 KB | dww |
Comments
Comment #1
m3avrck commentedHere's a patch that fixes this. Untested, but should work.
Comment #2
dwwa) syntax error in the patch:
$links['project_view_all] = array(=>$links['project_view_all'] = array(b) because of the wonky nature of the project module, there are places the code directly tries to alter the links[] array in the project node. ;) (fun, huh?) check out project.module, around line 725. those are all still broken, even with this patch (modified to fix (a), of course).
given m3avrck's patch, i think i could roll one that'll solve (b), but perhaps someone else can take care of this, first... ;)
note: we shouldn't commit any fix for this until we branch for DRUPAL-4-7. see http://drupal.org/node/59904
Comment #3
m3avrck commentedHmmm, looks like hook_link_alter() might be of use now :-)
Comment #4
dwwno, we don't actually need hook_link_alter(). all we need is to use the new structured links arrays anywhere we're going to be using theme('links') or in the nodes themselves. unfortunately, this is a lot of places. ;) i don't have time right now for a full patch, but i'll work on it soon.
Comment #5
dwwthis appears to be the minimum patch required to get project working again against the HEAD of core. there are other places we're building up an array of links, but we print those with
theme('item_list', $links, ...). i guess we should probably fix all of those, too, but i don't really feel like messing with all of that at the moment. ;) once i get this committed and the basics are working again, we can re-open this issue to deal with the full port to hook_links() and structured link arrays.m3avrck, nedjo, dries? RTBC? thanks.
Comment #6
dwwas soon as i commit http://drupal.org/node/64647 we're going to have more broken links in HEAD, since more will be using theme('links')... we could still commit this one as is and handle those later, but i just wanted to make a note here. i'm tempted to set to "needs work"...
Comment #7
dwwi just committed #64647, so this needs work again...
Comment #8
dwwupdated patch to handle the issue query page links
Comment #9
dww2 recent duplicate issues with this:
http://drupal.org/node/68179
http://drupal.org/node/68181
now that drupal.org is running core (and all contrib modules) from the DRUPAL-4-7 branch, it's safe to commit this patch...
Comment #10
dwwjust did a final round of testing to make sure this is still cool. commited to the trunk.
Comment #11
(not verified) commented