on the issue query page (/project/issues), the list of links at the top (submit, statistics, etc) takes up a lot of space. i'd like to make that list horizontal, and i'm pretty sure there's reasonable CSS hackery to do it. i'll give it a shot and see if i can roll a patch.

CommentFileSizeAuthor
#7 project_issue_horizontal_links.patch.2701 bytesdww
#6 project_issue_horizontal_links.patch.1557 bytesdww
#4 project_issue_vertical_links.png118.96 KBdww
#3 project_issue_horizontal_links.png101.07 KBdww
#2 project_issue_horizontal_links.patch1.22 KBdww

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Good idea. This is what's done with li items in e.g. the PHPTemplate primary link buttons.

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new project_issue_horizontal_links.patch1.22 KB

here's a simple patch. i ended up going with the <br class="clear" /> trick to clear the floating elements, since this isn't inside a fieldset, and i'm not enough of a CSS heavyweight to get this right. ;) any suggestions for visual improvement are welcome. i'll attach a screenshot next with the results of this patch (along with my patch from http://drupal.org/node/64648).

dww’s picture

dww
we/he/they
commented
StatusFileSize
new project_issue_horizontal_links.png101.07 KB

screenshot, as promised.

dww’s picture

dww
we/he/they
commented
StatusFileSize
new project_issue_vertical_links.png118.96 KB

for comparison, here's the "before" view, with all the links vertical.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Needs work

Nice!

I think we should be able to get away without the
(and in general we want to be avoiding adding HTML outside theme calls). Maybe try using display: inline in the css li setting. For examples of how we do this elsewhere, look at the /* Tab navigation */ section in drupal.js.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Needs review
StatusFileSize
new project_issue_horizontal_links.patch.1557 bytes

indeed "display: inline;" did the trick. new patch attached.

dww’s picture

dww
we/he/they
commented
StatusFileSize
new project_issue_horizontal_links.patch.2701 bytes

heh, merlinofchaos suggested an even easier fix (1 word different): 

-    $group = theme('item_list', $links);
+    $group = theme('links', $links);

new patch. this even includes fancy separators between the links for us. ;)

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Yep, that's the way to do it.

You could I suppose wait a day or two before applying just in case anyone is attached to the old look.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

hearing no objections, applied to HEAD and 4.7. backported to 4.6.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)