Closed (fixed)
Project:
Project
Version:
4.7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
20 May 2006 at 17:00 UTC
Updated:
7 Jun 2006 at 17:46 UTC
Jump to comment: Most recent file
i think the "advanced search" link takes up way too much valuable space in the bar of select lists for what issues you want to see on the issue query pages. i'm planning to add a select list for "component" in there, which would be vastly more useful. and, it seems a little out of place, too, since it really is just another action link, not necessarily something for modifying the query. i can see why folks wanted to stick it right next to the search button, so people know it's there. however, i think there are other ways to accomplish that. for example, i'd like to use CSS to make that list of links horizontal to take up less space, too (http://drupal.org/node/64647). anyway, i believe getting it out of the query bar is a good thing in its own right, so i'll probably commit this in a day or 2 if there are no objections.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | project_issue_move_adv-search.patch.2 | 2.34 KB | dww |
| #2 | project_issue_move_adv-search.patch | 2.35 KB | dww |
Comments
Comment #1
nedjoAgreed, a component select would be a better use of the space.
Comment #2
dwwwhoops, forgot to attach the patch. ;)
Comment #3
nedjo+1
* 'Use the advanced search interface %project issues.' is missing a 'for' before the %project
* The term 'interface' is a bit techie, maybe we could leave it out.
Comment #4
dww"interface" => "page", fixed missing word. nice catch. thanks. ;)
Comment #5
dries commentedI used the advanced search all the time. Why? Because I need the version-selector. If you have per-version maintainers (like we have), the version-selector is very handy. On the other hand, if you have per-component maintainers (like other projects have), the component-selector could be more useful.
Anyway, I don't really care where the 'advanced search' link is placed, as long it is easy to access.
PS: can we wrap the search box in a fieldset so they look consistent with the 'Project information' fieldset, and the 'Issue information' fieldset on the 'new issue comment' page? :)
Comment #6
dwwindeed. if i can fit both in there, i'll do it. ;)
ok. i'm just talking about putting it in the pile of other links at the top of the page, instead of all the way to the right in the query bar.
i think you lost me. ;) can you be more specific? maybe you mean we should split up the search query bar into 2 bars, like when you're submitting an issue or a followup, and have all the same dropdowns in the same order, etc? yeah, that could work. ;) i'll see what i can do...
thanks,
-derek
Comment #7
dries commentedok. i'm just talking about putting it in the pile of other links at the top of the page, instead of all the way to the right in the query bar.
I know and I'm OK with moving the link to the top of the page. Just wanted to take the opportunity to document my use of the 'advanced search' option.
i think you lost me. ;) can you be more specific? maybe you mean we should split up the search query bar into 2 bars, like when you're submitting an issue or a followup, and have all the same dropdowns in the same order, etc? yeah, that could work. ;) i'll see what i can do...
The quick search bar on top of issue listings doesn't use a fieldset (example). I suggested (or tried suggesting ;)) that we make it use a fieldset as well (like the other "bars" in the project module).
Comment #8
dwwpatch from #4 applied to HEAD and DRUPAL-4-7. backported to DRUPAL-4-6.
let's move the rest of this discussion to http://drupal.org/node/65336, which i just opened up for the purpose. ;)
thanks,
-derek
Comment #9
(not verified) commented