PayPal Pro Module Compatible with 4.7

Actually, We(mostly me) have broken a lot of things ppp uses. I've had a patch I've been holding onto for a while till I got a chance to test the SSL portion of it but I'll go ahead an put it up. This hasn't been tested redirecting to SSL.

Things accomplished in the patch:
1) Update the last remaining bits to new FAPI
2) moved the rest of the express functions(SOAP and menu hook) to separate module.
3) Address object changes
4) Changed PP logo on payment selction screen to not look like a link to somewhere(different payment logo from paypal)
5) moved _settings to _ec_settings.
6) renamed paypalpro_page to paypalpro_paymentform to avoid confusion with core hook.
7) drupal_goto instead of setting header
8) watchdog errors instead of showing user. give user simple error.
9) added paypalpro curl wrapper function
10) removed ?> from end of files
11) probably more little things.

Apologies for the size of the patch. It's a lot of little fixes I've been putting off posting and some rather large fixes rolled together.
Testing would be appreciated. this should apply cleanly and work with the latest CVS as of this posting.

Check out what samys has done in the payment module for making the creation of credit card forms much easier.

If you can follow this same format so that all the credit card forms are consistant.

I had thought about this but didn't want to implement it until I had read through the paypal rules on credit card forms.

Marked http://drupal.org/node/68462 as duplicate of this

This patch is based off the above, and does a few additional things:

1) groups the form fields into fieldsets
2) fixes the return value on paypalpro_form()
3) fixes $base_path with base_url()

Just trying to clarify a few things...

Is "paypalpro.module_4.patch" based on "paypalpro.module_1.patch" or "64456.patch.txt" ?

I'm guessing the patching process would be similiar to the following:
1. Run either module_1.patch and/or 64456.patch (not sure which one) on CVS of paypalpro.module
2. Run module_4.patch on the result of step 1.

I'm a little confused. My patch does group the fields in fieldset.

Also, the return value seems the same but the 3rd parameter for drupal_get_form is a callback name. passing a url path here will break validation and submit functions.

And the base_path() fix wont work. The idea of those lines is to redirect to a secure site. However base_path only returns the path. Example: (h left out of http to break comment parse from making it a url)

echo $base_url;  // ttp://www.example.com/drupal_ec7_testsite
echo base_path();  // /drupal_ec7_testsite
echo str_replace('http://', 'https://', $base_url);  // ttps://www.example.com/drupal_ec7_testsite
echo str_replace('http://', 'https://', base_path()); // /drupal_ec7_testsite

Also, url() applies base_path or base_url. check api.drupal.org.

A better solution that I was hoping to add in a later thread was to allow the user to specify the secure url. Many sites use a different server or path for the secure site and this would allow that functionality.

Hi-

Sorry for the confusion that I'm creating. I think I got confused about which patch I applied, which is why I'm causing some malarkey.

I was trying to avoid using $base_url because it's now listed as being optional in the settings.php file. I take your point about why my solution might cause problems. How best to deal with cases where $base_url isn't set?

I will create an admin option for the SSL url in the settings file which should help solve the problem.

I'll take that charge :)

I'm willing to test this thoroughly. Lets go!

I get the following errors when trying to apply 64456.patch.txt. I attempted to apply it on a fresh CVS copy of paypal pro using the following command:

patch -p0 < 64456.patch.txt
patching file contrib/paypalpro/paypalpro.module
Hunk #9 FAILED at 815.
1 out of 9 hunks FAILED -- saving rejects to file contrib/paypalpro/paypalpro.module.rej
patching file contrib/paypalpro/paypalpro_express.module

----------------------------------------
Contents of paypalpro.module.rej
----------------------------------------
***************
*** 1152,1244 ****
$IPAddress
$MerchantSessionId

-
-
-

-

End_Of_Quote;

return $SOAPrequest;
}
-
- /**
- * A simple xml parsing function.
- *
- * @param $xml A text string that contains the xml to be parsed.
- * @param $open_tag The opening xml tag to search for.
- * @param $close_tag The closing xml tag to search for.
- * @return string The string between $open_tag and $close_tag
- */
- function paypalpro_parse_xml($xml, $open_tag, $close_tag) {
- $pos1 = strpos($xml, $open_tag);
- $pos2 = strpos($xml, $close_tag);
- return substr($xml, $pos1 + strlen($open_tag), $pos2 - ($pos1 + strlen($open_tag)));
- }
-
- /**
- * A recursive xml parsing function for obtaining multiple error messages.
- *
- * @param $xml A text string that contains the xml to be parsed.
- * @param $open_tag The opening xml tag to search for.
- * @param $close_tag The closing xml tag to search for.
- * @return array All error messages found in the xml.
- */
- function paypalpro_get_errors($xml) {
- // errors in returned xml are comprised of short and long messages
- define(SHORT_OPEN, '');
- define(SHORT_CLOSE, '');
- define(LONG_OPEN, '');
- define(LONG_CLOSE, '');
- $errors = array();
- // loop through xml to find all error messages
- $loop = TRUE;
- while ($loop) {
- // test if there are any more errors by looking for the SHORT_OPEN string
- if (strpos($xml, SHORT_OPEN)) {
- $error['short'] = paypalpro_parse_xml($xml, SHORT_OPEN, SHORT_CLOSE);
- // there's no need to report the generic "Internal Error"
- if ($error['short'] != 'Internal Error') {
- $error['long'] = paypalpro_parse_xml($xml, LONG_OPEN, LONG_CLOSE);
- $errors[] = $error;
- }
- $xml = substr($xml, strpos($xml, LONG_CLOSE) + strlen(LONG_CLOSE));
- }
- else {
- // no more error messages found
- $loop = FALSE;
- }
- }
- return $errors;
- }
-
- /**
- * Look for an adress in the user's address book that exactly matches the
- * address returned by PayPal. If found, return the aid.
- *
- * @param $edit The $edit array, with address info returned from PayPal.
- * @return $aid The id of the address entry in the database, if match found.
- */
- function paypalpro_address_get_aid($edit) {
- $address = db_fetch_object(db_query("SELECT aid FROM {ec_address} WHERE uid = %d AND firstname = '%s' AND lastname = '%s' AND street1 = '%s' AND street2 = '%s' AND zip = '%s' AND city = '%s' AND state = '%s' AND country = '%s'", $edit->uid, $edit->firstname, $edit->lastname, $edit->street1, $edit->street2, $edit->zip, $edit->city, $edit->state, $edit->country));
- return $address->aid;
- }
-
- /**
- * Save the address returned from PayPal in the local address book, then return
- * the aid. If the address already exists, simply return the aid.
- *
- * @param $edit The $edit array with address info returned from PayPal.
- * @return @aid The id of the address entry in the database.
- */
- function paypalpro_address_save($edit) {
- $aid = paypalpro_address_get_aid($edit);
- if (!$aid) {
- db_query("INSERT INTO {ec_address} (uid, firstname, lastname, street1, street2, zip, city, state, country) VALUES (%d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s')", $edit->uid, $edit->firstname, $edit->lastname, $edit->street1, $edit->street2, $edit->zip, $edit->city, $edit->state, $edit->country);
- $aid = paypalpro_address_get_aid($edit);
- }
- return $aid;
- }
-
- ?>
--- 815,827 ----
$IPAddress
$MerchantSessionId

+
+
+

+

End_Of_Quote;

return $SOAPrequest;
}

----------------------------------------
END Contents of paypalpro.module.rej
----------------------------------------

I get the following errors when trying to apply 64456.patch.txt. I attempted to apply it on a fresh CVS copy of paypal pro using the following command:

patch -p0 < 64456.patch.txt
patching file contrib/paypalpro/paypalpro.module
Hunk #9 FAILED at 815.
1 out of 9 hunks FAILED -- saving rejects to file contrib/paypalpro/paypalpro.module.rej
patching file contrib/paypalpro/paypalpro_express.module

Contents of paypalpro.module.reg

***************
*** 1152,1244 ****
      <IPAddress>$IPAddress</IPAddress>
      <MerchantSessionId>$MerchantSessionId</MerchantSessionId>
  
- 				</DoDirectPaymentRequestDetails>
- 			</DoDirectPaymentRequest>
- 		</DoDirectPaymentReq>
  
- 	</SOAP-ENV:Body>
  </SOAP-ENV:Envelope>
  End_Of_Quote;
  
    return $SOAPrequest;
  }
- 
- /**
-  * A simple xml parsing function.
-  *
-  * @param  $xml        A text string that contains the xml to be parsed.
-  * @param  $open_tag   The opening xml tag to search for.
-  * @param  $close_tag  The closing xml tag to search for.
-  * @return string      The string between $open_tag and $close_tag
-  */
- function paypalpro_parse_xml($xml, $open_tag, $close_tag) {
-   $pos1 = strpos($xml, $open_tag);
-   $pos2 = strpos($xml, $close_tag);
-   return substr($xml, $pos1 + strlen($open_tag), $pos2 - ($pos1 + strlen($open_tag)));
- }
- 
- /**
-  * A recursive xml parsing function for obtaining multiple error messages.
-  *
-  * @param  $xml        A text string that contains the xml to be parsed.
-  * @param  $open_tag   The opening xml tag to search for.
-  * @param  $close_tag  The closing xml tag to search for.
-  * @return array       All error messages found in the xml.
-  */
- function paypalpro_get_errors($xml) {
-   // errors in returned xml are comprised of short and long messages
-   define(SHORT_OPEN, '<ShortMessage xsi:type="xs:string">');
-   define(SHORT_CLOSE, '</ShortMessage>');
-   define(LONG_OPEN, '<LongMessage xsi:type="xs:string">');
-   define(LONG_CLOSE, '</LongMessage>');
-   $errors = array();
-   // loop through xml to find all error messages
-   $loop = TRUE;
-   while ($loop) {
-     // test if there are any more errors by looking for the SHORT_OPEN string
-     if (strpos($xml, SHORT_OPEN)) {
-       $error['short'] = paypalpro_parse_xml($xml, SHORT_OPEN, SHORT_CLOSE);
-       // there's no need to report the generic "Internal Error"
-       if ($error['short'] != 'Internal Error') {
-         $error['long'] = paypalpro_parse_xml($xml, LONG_OPEN, LONG_CLOSE);
-         $errors[] = $error;
-       }
-       $xml = substr($xml, strpos($xml, LONG_CLOSE) + strlen(LONG_CLOSE));
-     }
-     else {
-       // no more error messages found
-       $loop = FALSE;
-     }
-   }
-   return $errors;
- }
- 
- /**
-  * Look for an adress in the user's address book that exactly matches the
-  * address returned by PayPal.  If found, return the aid.
-  *
-  * @param  $edit  The $edit array, with address info returned from PayPal.
-  * @return $aid   The id of the address entry in the database, if match found.
-  */
- function paypalpro_address_get_aid($edit) {
-   $address = db_fetch_object(db_query("SELECT aid FROM {ec_address} WHERE uid = %d AND firstname = '%s' AND lastname = '%s' AND street1 = '%s' AND street2 = '%s' AND zip = '%s' AND city = '%s' AND state = '%s' AND country = '%s'", $edit->uid, $edit->firstname, $edit->lastname, $edit->street1, $edit->street2, $edit->zip, $edit->city, $edit->state, $edit->country));
-   return $address->aid;
- }
- 
- /**
-  * Save the address returned from PayPal in the local address book, then return
-  * the aid.  If the address already exists, simply return the aid.
-  *
-  * @param  $edit  The $edit array with address info returned from PayPal.
-  * @return @aid   The id of the address entry in the database.
-  */
- function paypalpro_address_save($edit) {
-   $aid = paypalpro_address_get_aid($edit);
-   if (!$aid) {
-     db_query("INSERT INTO {ec_address} (uid, firstname, lastname, street1, street2, zip, city, state, country) VALUES (%d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s')", $edit->uid, $edit->firstname, $edit->lastname, $edit->street1, $edit->street2, $edit->zip, $edit->city, $edit->state, $edit->country);
-     $aid = paypalpro_address_get_aid($edit);
-   }
-   return $aid;
- }
- 
- ?>
--- 815,827 ----
      <IPAddress>$IPAddress</IPAddress>
      <MerchantSessionId>$MerchantSessionId</MerchantSessionId>
  
+         </DoDirectPaymentRequestDetails>
+       </DoDirectPaymentRequest>
+     </DoDirectPaymentReq>
  
+   </SOAP-ENV:Body>
  </SOAP-ENV:Envelope>
  End_Of_Quote;
  
    return $SOAPrequest;
  }

My patch of the cvs palpalpro module went well.. no errors... patched the module uploaded it, moced the dir into the base ecommerce, created a product... added it to cart, selected pay with cc confirmed address then got a 404 on this page: http://domain.com/cart/review

so can't go further.

Does anyone know the status of this? Should I be testing w/ this patch http://drupal.org/node/64456#comment-100105 ?

Thanks,
Ian

Is anyone against me posting full patched files that I hand patched, so people can test? Will this just cause confusion/problems if my two files aren't quite right? They install and turn on ok, and settings comes up, but no testing yet.

Ian

i thikn it is bad form to post patches that are untested ... would be nice to have paypalpro for 4.7

From time to time I'll test patches, however and whenever you can get them to us. I'm really interested in getting this module working.. please don't have me test something that could drop my DB though.. thanks!

I can test if someone can tell me what to test, since it's gotten a bit confusing. (also, if it might destroy my database please warn me but I don't see any reason why it should.)

I'd like to offer $100 bounty or donation to Drupal to anyone who can finish this off quickly (say within 2 weeks).

I'm testing the authorize.net module
I got the same error as the person above
error while loading ...../cart/review
http://drupal.org/node/64456#comment-110331

Perhaps the problem is in product.module or elsewhere in ecommerce core, not in paypalpro.

Thanks for your work Darren, I'll test tonight.

I had trouble testing, something in the CVS of ecommerce was crashing my install and I ran out of time I'll try to test again tonight.

Looks good Darren, maybe I was not the right person to test this... the transaction when through fine and was processed and completed, it noticed when I entered a bogus cc number and when it went through I got an email telling me about it and my role was changed accordingly... 20 minutes though and I have not seen it refected in my account yet.. but that might be my settings I'm only 90% sure that I have them correct.. it would not show completed if the payment did'nt go through?

2 errors reported in the log seem to be unrealted to your work:

Type php
Date Wednesday, 12 July 2006 - 11:02pm
User anon
Location http://domain.com/admin/logs/event/64161
Referrer http://domain.com/admin
Message Invalid argument supplied for foreach() in /home/path/domain.com/httpdocs/modules/ecommerce/store/store.module on line 44.
Severity error
Hostname ip

========================

Date Wednesday, 12 July 2006 - 10:54pm
User anon
Location http://domain.com/admin/store/transaction/edit/17?section=overview&desti...
Referrer http://domain.com/admin/store/transaction/edit/17?section=overview&desti...
Message Table 'dbname.ec_credit_card' doesn't exist query: DELETE FROM ec_credit_card WHERE txnid = 0 in /home/path/domain.com/httpdocs/includes/database.mysql.inc on line 120.
Severity error
Hostname ip

I don't see ec_credit_card anywhere??

Darren,
thank you very much. Yes, I will pay you the bounty if this all works.

Haven't been able to test it because I had no idea paypal made it so hard to pay by credit card.

(under paypal standard, without pro) apparently buyer is show credit card screen only once. I posted a question at node 73613. can others confirm this is correct?

I wanted to understand how standard functions before I tested pro so I can understand the workflow.

I've installed and enabled paypalpro and paypal express.
I put in the id, password, and path to ssl file. (all in sandbox)

When my user went to pay, she got 2 options: (1) paypal and (2) credit card. (1) clicking paypal leads to the paypal website (looking like paypal standard payments). (2) clicking on credit card leads to "connection to server unexpectedly terminated"

How does buyer get to paypal pro option? I thought maybe there would be a third tab called "pay with credit card via paypal pro" or something.

how is this supposed to work? what is buyer supposed to see as options when she goes to pay?

Darren, Thank you. I went to your test site. I picked credit card. It sent me to the paypal dev sandbox. I thought about logging in under my account but I assume it would not work. Does it mean our credit card option is restricted to only paypal then? (if we have say, authorize.net, would we have to configure ecommerce for either paypal pro or for authorize.net?)

By the way, when I picked user points, it still sent me to the paypal sandbox. I would think that's not the way it's supposed to be.

I was not logged in. I expected to get a message "you must log in" and then "you don't have enough points."

Thank you.

Thank you.

I've been reading about SSL. It seem that:
1) I need to have an SSL certificate installed on my server (shared hosting) to even test out paypal pro in the sandbox
2) To have SSL, I need a dedicated IP so I need to upgrade my account.

Are these 2 things true to even test paypal pro in the sandbox? Did you install SSL on your server?

Above when I said I installed, all I meant was I uploaded into root and gave the path to the paypal pro module. I didn't do the "installation" which is apparently quite complicated. site5 has a button to install, but it does not have any directions and I could not figure it out.

Darren,
this time the user points option said correctly "you don't have enough points" and credit card option correctly asked me for the credit card. I'll have to use the dummy credit card number from your account. I'll send you a private message for it.

when i put in the dummy credit card for my account, i got this 4 times.
There was an error processing your transaction with PayPal. A message has been logged. We are sorry for the inconvenience

i notice i put in my credit card number at http, not https, so can I assume sandbox does not require https?

by the way, I think it's interesting the url is this, so an observant buyer can deduce they are paying via paypal pro
http://test.sidepotsinternational.com/paypalpro/form/71

Darren,
thank you. that was helpful.
Is it possible to put asterisks in the password field when there is data in it?

I put in my Paypal API password, I hit submit. The screen says my options have been saved but the password field is still blank. I certainly don't want to type in the 16 digit password every time.

I realized I put in the wrong path last time. It says absolute path. I tried this today:
/home/mysitename/public_html/addondomainname/cert_key_pem.txt.
That's right, right? I don't need to add or remove any /.

When I try to pay via credit card, it says connection terminated.
When I try to pay via paypal express, it says, sorry there was an error.
Authentication/Authorization Failed Username/Password is incorrect.

(There's no way to change the API password that I saw. It's hard to ensure that you typed a 16 digit password correctly if you can't see the password. If you know a way to change the password or to make it show on the screen as I type it, please let me know.)

When I try to pay via credit card, it says connection terminated.
When I try to pay via paypal express, it says, sorry there was an error.
Authentication/Authorization Failed Username/Password is incorrect.

(There's no way to change the API password that I saw. It's hard to ensure that you typed a 16 digit password correctly if you can't see the password. If you know a way to change the password or to make it show on the screen as I type it, please let me know.)

When I try to pay via credit card, it says connection terminated.
When I try to pay via paypal express, it says, sorry there was an error.
Authentication/Authorization Failed Username/Password is incorrect.

(There's no way to change the API password that I saw. It's hard to ensure that you typed a 16 digit password correctly if you can't see the password. If you know a way to change the password or to make it show on the screen as I type it, please let me know.)

(sorry about the redundant posts. the screen returned an error.)

I also have authorize.net enabled.
I notice now that my payment screen has 4 options:
1. Pay with credit card
2. Paypal
3. Credit card
4. Paypal Express check out.

I think having both 1 and 3 will be very confusing for the buyer.

I used the dummy data you gave me.
1) As an anonymous user, it let me go all the way through and enter the credit card, and then returned an error. (something not found I think.) It would be good for there to be a warning that anonymous cannot purchase, and they must log in (before putting in their credit card)

2) I then logged in and provided my credit card info all over again. This is the message.
Page not found
Transaction approved. Thank you for your order!

I guess it means it worked. The "page not found" is confusing, but I assume that's merely fixing a setting.

which table stores the password for paypalpro? I thought I'd look in mysql for it but I can't find it anywhere. I've looked through every table that starts with ec. I also glanced at all the tables.

Darren,
re: #40
http://drupal.org/node/64456#comment-116130

do I need a dedicated IP address?

http://wiki.civicrm.org/confluence/display/CRM/PayPal+Configuration+Guide
Create or locate a directory which can be used for your API Profile files. During this step, your webserver must have read/write access to the path - but for security it should preferably be a directory that is NOT below your web root. Note down the path to this directory - this will be your TEST_CERT_PATH.

I interpret this to mean the ssl certificate from paypal can be placed below your root, but for security reasons should not be.

I've made a little headway. In settings, I turned off SSL. This time when I clicked on credit card, it gave me the entire paypal credit card form to fill out. When I filled it out, it gave this error six times:
There was an error processing your transaction with PayPal. A message has been logged. We are sorry for the inconvenience

Just to clarify, I am using the first party authentification method

Shopping Cart Resources
Print this Page

Note: This page contains information for shopping cart owners who wish to offer PayPal as a payment option with their product. If you are a merchant searching for a shopping cart for your website or application, please visit our Solutions Directory.

Before integrating PayPal into your shopping cart, you must choose which payment options to support.
With Pro, the customer completes the checkout on your merchant's website. With Standard, the customer completes the checkout on the PayPal website. Although Pro is more technically challenging than Standard, it gives customers an improved buying experience because you retain more control of the checkout experience. The table below compares the two options.
Website Payments Pro Website Payments Standard
Monthly Fee Yes No
Core Technology SOAP Web Services HTML / FORM POSTs
Customer Experience Checkout on merchant site Checkout on PayPal's site

Integrating Website Payments Standard
If you choose to integrate your cart with Website Payments Standard, you provide a PayPal payment button on the checkout page of your cart. This button POSTs an HTML FORM to the PayPal website that redirects the customer to PayPal to complete the payment. This form contains the payment details of the transaction. For more details on how to construct this POST, visit the Standard Payment Option page.
Integrating Website Payments Pro
If you choose to integrate your cart with Website Payments Pro, your next choice is to determine if you will use first-party authentication or third-party authentication when submitting API calls. This depends on the way in which customers use your cart. It is possible that you can use both methods.
First-Party Authentication
First-party authentication should be used if your product is downloaded and runs in your customer's environment. With first-party authentication, your customer uses their own API username and password to submit API calls to PayPal.
Third-Party Authentication
If your shopping cart is offered as a hosted solution, that is, if your customers do not download and install your software onto their servers, but instead interact with your cart that is installed on your servers or another managed service provider's service, then you need third-party API authentication.
With third-party authentication, you submit API calls to PayPal on your merchant's behalf. You need to download an API Certificate for your business account, and use your API username and password for every call. You specify the merchant, the third-party for whom you are making the API call, by populating the Subject field of the request with the email address of your merchant's Verified PayPal Business account.
Third-Party Authentication Using the PayPal SDK
Calling PayPal Web Service APIs is easier if you use one of the PayPal SDKs. To use third-party API authentication with the PayPal SDK, set the value of the Subject field in your API Profile object that is in use by the CallerServices object submitting the API call.
Examples of setting the Subject in an API Profile object are shown below:
ASP.NET/C#
IAPIProfile profile = ProfileFactory.CreateAPIProfile();
profile.APIUsername = "Your PayPal API username";
profile.APIPassword = "Your PayPal API password";
profile.Subject = "Merchant's PayPal email address";
profile.Environment = "live" or "sandbox";

Java
APIProfile profile = ProfileFactory.createAPIProfile();
profile.setAPIUsername("Your PayPal API username");
profile.setAPIPassword("Your PayPal API password");
profile.setSubject("Merchant's PayPal email address");
profile.setCertificateFile("Path to your P12 certificate");
profile.setPrivateKeyPassword("Password for P12 certificate");
profile.setEnvironment("live" or "sandbox");

Presenting the PayPal Solutions to Your Customers
When you present your PayPal solutions to your customers, we suggest something similar to the following. This treatment is intended only as a guide for carts offering both Standard and Pro. You should tailor your sign-up process to the services you offer.
Website Payments Pro Setup Instructions for Your Customers
Give instructions similar to the following to your customers on how to configure their PayPal account to work with your cart when they choose Website Payments Pro.
Set Up a Verified PayPal Business account
Customers who don't have an existing PayPal account:
1. Go to https://www.paypal.com/cgi-bin/webscr?cmd=_registration-run&business_onl....

2. Choose country and click Continue. Website Payments Pro is currently only available for US based merchants.

3. Complete Business account sign-up page.

4. Verify your email address by following the instructions sent to your email account.

5. Confirm your address by adding a credit card to your account.

6. Add a bank account to become a Verified member. This process may take several business days. Follow the instructions on the PayPal site to add a bank account.

Customers who already have a Personal or Premier account:
1. Go to https://www.paypal.com/cgi-bin/webscr?cmd=_registration-run&business_onl....

2. Click on the Upgrade your Account link.

3. Click on the Upgrade Now button.

4. Choose to upgrade to a Business account and follow instructions to complete upgrade.

5. If you haven't already, add a bank account to become a Verified member. This process may take several business days. Follow the instructions on the PayPal site to add a bank account.

Apply for Website Payments Pro
1. Go to https://www.paypal.com/us/cgi-bin/webscr?cmd=_smb_signup_entry&featureID=1.

2. Fill out your information. You must enter your Social Security number for the application.

3. Submit your application. Approval takes between 24 and 48 hours.

4. Accept the Pro billing agreement. Check the Getting Started section on the upper left of your account overview page.

Setup API access
First-party authentication: Download API certificate
1. Log in to your PayPal account and click the Profile subtab.

2. Click the API Access link under the Account Information column.

3. Click the API Certificate Request link under the Request an API Certificate header.

4. Complete the API Certificate Request form. Write down the value listed next to Account Name, this is your API Username. Also write down the value you choose for the Password field, this is your API Password. Click the Continue button when complete.

5. Click the Generate Certificate button on the 'API Certificate Request Review' page.

6. Click the Download button on the API Certificate page. You will be prompted to download a file called cert_key_pem.txt. This file is your API Certificate.

I am not using the
Third-party authentication: Grant your cart the appropriate API authentication permissions
1. Log in to your PayPal account and click the Profile subtab.

2. Click the API Access link in the Account Information column.

3. Click the API Access Authorization link.

4. Click the Add button.

5. In the API Account Name field, enter the cart's API username.

6. Check the boxes next to the following APIs:

AddressVerify
SetExpressCheckout
GetExpressCheckoutDetails
DoExpressCheckoutPayment
DoCapture
DoReauthorization
DoVoid
DoDirectPayment
DoAuthorization
7. Click the Save button.

Is this right?

https://www.sandbox.paypal.com/us/cgi-bin/webscr?cmd=xpt/popup/APIConcep...

method 1
An API certificate is suitable if you have complete control over your own web server.

method 2
An API signature is suitable for use with Microsoft Windows web servers or other shared web server configurations, such as those used by web hosting services.

based on this info, I would think that on a shared host I would need to use method 2, an API signature.

I don't see this option in paypal pro. Am I correct?

Darren, should we patch all of these, starting with the first then patch our way to this one, then test??

Thanks

yeah, I did that. I'm trying to test this but I ran into the negitive amount bug (there is a patch for this) until ecommerce works it's difficult to get to test your paypalpro patch. But I'll keep trying.

I've written some documentation on what you need in terms of settings and hosting in order to test the module at node 74560

I've filed an issue about password being erased at node 69552

I don't have any issues with the negative amount bug. Actually never heard of it.

I applied patch 3. ran through the procedure.
got this error six times. (same result as patch 2)
There was an error processing your transaction with PayPal. A message has been logged. We are sorry for the inconvenience

The first time I tried to patch, it said it's already been patched. was not quite sure whether it's okay to apply patch 3 after doing 1 and 2. So I redownloaded unpatched copies from cvs.

after patching it said,
patching file paypalpro.module
patching file paypalpro_express.module

it didn't say succeeded or failed. is that the normal message if it succeeded? (i have a memory that if only one file is patched there is no message returned.)

I have taken a look, and this the paypalpro express checkout is complete broken.

This is required as it is a part of T&C for Paypal Pro.

The flow should be something like.

Payment Method +--> Address --> Review --> payment page
               +--> Paypalpro express checkout --> E-Commerce Review

Is this a problem only if shipping or tax is enabled?
For membership, shipping is not necessary.
Does anyone know if in the U.S. we have to collect tax on website membership? (I would think state taxes do not apply)

I don't have shipping or tax enabled.

This is really a problem with any module that applies misc charges and the module applies the charges after paypalpro_express redirects.

Paypal also requires that you don't force the user to input an address if they're using the express checkout. This means you can't have the address form before paypalpro redirects and you can't calculate shipping or taxes. Coupons would also be subject to this problem since they are applied on the review screen.

If I remember right paypal treats the amount you send as an *estimate* for exactly this reason. I think it lets you error by a certain amount on the final transaction posted(after the review page for us). I'll review the documentation and confirm if this is correct.

Updated the patch in #53. I've changed back to the redirectioning to a header() function because drupal_goto() is not working in 4.7. Also I've done a few code cleanup and added a theme function to the paypal express image.

/**
 * Theme the PayPal express image and message 
 */
function theme_paypalpro_express_image() {
  $output = '<div class="container-inline">';
  $output .= '<img src="https://www.paypal.com/en_US/i/logo/PayPal_mark_37x23.gif" alt="PayPal Express Checkout" />';
  $output .= '<div class="description">Save time.  Checkout securely.  Pay without sharing your financial information.</div>';
  $output .= '</div>';
  return $output;
}

The checkout is being completed fine but not as PayPal requires (I'll be on this if time permits). How the "Screen order" approach can help us with this? Should we override the screen order if PayPal express is enable and create a new address using the data returned from the express checkout?

i have many mistery problems to apply patch this patch ?

maybe because i'm on a macintosh, maybe because 'diff'npatch' the soft i use cannot use this type of file
(i need to separate , the patch in different file , one per patch, don't know why ?)
then could you send file with the patch apply ??

thanks

Yes it may have upgraded paypalpro to 4.7, but because of the other issues, it will not get commited to the 4.7 branch.

However I will consider commiting to HEAD

Daren,

i have do this , but work with the previous
but not work with the last patch file ??

Patch seems to be working to me. Good idea with the theme function.

Commited with the addition of some comments on the new theme function and a better php function in paypalpro_ec_settings

Im getting the following error in watchdog..

"Invalid Configuration This transaction cannot be processed. The country listed for your business address is not currently supported"

Referrer: https://www.mysite.com/paypalpro/form/48

Any ideas on where the business address is stored?

module_exists() function still being used in the paypalpro.module (in the latest version in CVS) - which is an unknown function in 4.7. Commenting out that if{} block solves the problem for now.

I downloaded 1.15 from CVS - why woudl it be fixed in 1.14 and not in 1.15?

Is there any update/progress on this?