Why is forward_install() in module, not in the .install file?

Here is the install function pealed out of the .module file. I also update a bit of the text. Moving the function to the .install file makes it so that the tables are made during module installation. The 4.7 readme should probably be updated to note that the tables do not need to be installed manually.

Thanks for the cool module, just trying to help in little ways.

-Greg

Arrgh. Attached an old file. Here is the current one. :)

Actually, it works with the install function in the .module file. I'm not sure what the advantage to having a whole extra file for a single function is.

The install file is only loaded on the admin/modules page. Removing it from the main module, reduces the amount of PHP loaded and parsed during normal site usage - i.e. on every page.

As the _install() is short in this case it's probably not a major issue, but it seems to be the "norm" in Drupal modules to include a .install file.

replace create table if not exists
with create table
put CREATE index idx_forward_log_nid on forward_log (nid);
into its own db_query() and add braces around forward_log
no other module does this $success = TRUE;
--> remove it or let it do a real check (if db_query !== false, for example http://api.drupal.org/api/4.7/function/db_query)

remove ?>

The views.module does the $sucess = TRUE

I think I'll trust merlinofchaos's judgment on that one. ;)

I have seen the success = TRUE a few times, but more often I have seen the construct

$query = db_query("...

followed by an

if ($query) {

statement. I have updated the file and reattached. I don't have PostgreSQL, so I haven't tested that portion, but the two references I check say the syntax is correct.

Thanks for letting me help out in small ways. I am hoping to learn the Drupal way quickly and make more substantial contributions as I may. -Greg

thanks gman for your work,

since drupal 4.7 we try to make all databases "engine agnostic"
means we removed all TYPE=MyISAM

and we remove all ?>
at the end of a php files

see this http://drupal.org/node/22218#utf8_sql
please add utf8 support to the sql scheme

if you upload a new file set the status to code needs review

cu tobi

Yes, I noticed I hadn't updated the status until after I hit submit. I have updated the .install file as indicated and also attached a diff patch to the actual module that removes the install function.

Thanks. -Greg

Done in HEAD and DRUPAL-4-7. Thanks.

thank you for commiting this patch
I want to hand you over to http://drupal.org/node/72504
which has update path for the UTF8 db-part
and some other small fixes and corrections (which are a lot in the end)