Remove cosmetic cruft from module's css files

I have no opinion on this. Just moving it to the "drupal.css" queue for people monitoring those issue to decide what to do with.

Moving "drupal.css" component issues to "markup".

Some of this is necessary, some of it isn't and some is just done wrong.

#blocks tr.region-title td {
  font-weight: bold;
}

This should probably just be a <strong>, or even a heading tag.

#blocks tr.region-message {
  font-weight: normal;
  color: #999;
}

This should go.

.block-region {
  background-color: #ff6;
  margin-top: 4px;
  margin-bottom: 4px;
  padding: 3px;
}

Margins should likely go, possibly padding too, but background color should stay as this is meant to show the user where the regions are in the block admin.

Removing as much of this cruft as possible is definitely a good idea, so please go for it :D

Hm. It's a fine line. How much of the 'margins' define the UI, and how much of them are cosmetic?
Yeah, kill the font-weights.

In any case, we really should follow the accessibility guidelines and either NOT override colors, or ensure that we are overriding colors and background colors at the same time.

So many themes used to fail in the admin pages because of white-on-light or dark-on-dark text when theme colors met core css. It would be nice to maintain a policy of killing that wherever we can.

I think we can draw the line at the point where a core theme needs to reset the module styles to make it look good in the particular theme. As that clearly means: the core theme(s) won't be the only theme that needs to do it.

This effectively means that removing the horrible mess in reset.css of Seven theme is a very good starting point.

However, when drawing this line, we also need to take into account that the resulting styling should still look somewhat acceptable in Stark.

> However, when drawing this line, we also need to take into account that the resulting styling should still look somewhat acceptable in Stark.

Yup.

Stark isn't meant to be a production theme, but equally, there is a balance to be found between themes having to muck about with reset.css type stuff, and themes having to waste time providing basic UI styling. It's the job of module CSS to provide reasonably useful layout with a minimum of CSS styling.

Thanks for moving this along @dodazzi! :D

What we should do here is to introduce $file.base.css and $file.theme.css like we did for System module already.

tagging.

.

I'm ready to help out with this effort. Sounds like what is needed is to do the somewhat tedious work of making patches that separate out the css for each of the core modules into properly targetted files. I'm able to help out with that effort. And will try to put some patches together in June for each of the core modules.

It seems that's a good first step as we will likely need to see if removing this css really breaks the use of a module or not.

The initiative page for this task can be found at http://drupal.org/node/1089868 which provides guidelines and links to the individual issues filed for each core css file in need of cleanup.

correcting the tag to the more common one.

This issue has been superseded by the CSS standards. No need to keep it open.