There is no integration with Mollom 1.11 anymore, with Mollom 1.10 the CAPTCHA was working fine!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

Title: Guestbook is not protected by Mollom 1.11 » Mollom support
Version: 6.x-1.1 » 6.x-1.x-dev
Category: task » feature

#302941: Integrate with Guestbook was never officially supported by Mollom module. The changes that have been committed to Guestbook module did not really integrate the module with Mollom.

We can work on a proper integration though.

else’s picture

That should be great!!

Jochen Wendebaum’s picture

oh yes please! Mollom is great, and I don't like to use another spam module just because of my guestbook.
Subscribing.

Jochen Wendebaum’s picture

Can I help out, I am a module contributor...

midmood’s picture

Subscribe

risp’s picture

I'm not sure how to submit a patch and for which version of the guestbook I should make a patch but the following code is working great for me:

function guestbook_mollom_form_info() {
  $forms['guestbook_form_entry_form'] = array(
    'title' => t('Guestbook form'),
    'mode' => MOLLOM_MODE_ANALYSIS,
    'bypass access' => array('bypass mollom protection'),
    'entity' => 'guestbook',
	'elements' => array(
	  'message' => t('Body'),
	),
	'mapping' => array(
	  'author_name' => 'anonname',
	),
  );
  return $forms;
}

I've added this code between the following functions:

function guestbook_form_entry_form($form_state, $uid, $display = '', $entry_id = NULL)

mollom code here

function guestbook_form_entry_form_submit($form, &$form_state)
sahuni’s picture

Hello risp,
I have thousands of spams on guestbook.
Did the function you mentioned above is to be copied like that or there is a part of variable?
We don't have to add a call to this function?
I ask because I added this function in guestbook.module, but I can see still spams arriving in my page guestbook.
I have mollom-6.x-1.12 and guestbook-6.x-1.1

risp’s picture

Sorry I forgot to mention that after you added the above code that you need to edit the Mollom settings and add the guestbook form. Mollom -> add form and then select the guestbook.

sun’s picture

Status: Active » Postponed

Sorry, it's unfortunate, but the hook_mollom_form_info() API will most likely need to be completely changed in Mollom 6.x-1.13. We're trying to resolve some ugly unforeseen scaling issues.

Postponing until it's safe to implement this hook (i.e. when Mollom 1.13 has been released).

sahuni’s picture

Stupid of me!
You are right, it works
thanks for all

sahuni’s picture

Now there is a new version of mollom : mollom-6.x-1.13
Is there now a better integration of guestbook module?
Do we have to upgrade mollom or it will not change anything about attacks every 5mn more or less?
Mollom stop attacks but logs are too numerous.

sun’s picture

Priority: Critical » Normal
Status: Postponed » Active

Yes, we can now work on a patch to integrate with Mollom's latest stable release 1.13.

sahuni’s picture

Sorry, I am not one who understand easily.
What do you mean? A new version of guestbook? a patch of guestbook but if yes where to get it?
Or simply, do I have to try and write myself my hook_mollom_form_list in addition to hook_mollom_form_info?

PROMES’s picture

Since the update frequency are different for guestbook and mollom I think this should be an add-on to the guestbook and/or mollom module. There can be different module owners who can independent of each other update the module.

JordanMagnuson’s picture

Any news on this? Does the solution in #6 work for current versions of Guestbook and Mollom modules?

czoper’s picture

I've got Guestbook 6.x-1.1 and Mollom 6.x-1.13 but solution in #6 doesn't work for me :-/

The only and fastest option I see is to install Captcha "standalone" module:
http://drupal.org/project/captcha

if heaving any problems adding captcha to Guestbook, pls refer to this instruction:
http://drupal.org/node/272050#comment-1409088

good luck ;)

sahuni’s picture

Look at mollom.api.php in mollom library module. Code is a little different in 6.x-1.13 as in 6.x-1.11.

sun’s picture

More details currently in the workings over in #775444: API implementor documentation

I'd be interested whether someone is able to write a proper patch for Guestbook based on that information.

PROMES’s picture

FileSize
1.37 KB

I created a version 1.0-dev of guestbook_mollom module.
I did test it for site-guestbooks only, but since the code for user-guestbooks is the same I expect this to work as well.
I am new to the guestbook module, I don't know who can post a comment on an entry. I did implement a mollom-check but didn't test it.
I couldn't find in the mollom documentation, nor in the mollom module how to get a 'Report as inappropriate' line in the e-mail, send by guestbook. I will ask this in the mollom queue.
I present the module this early, so everyone can benefit.
Please help me to test this module.

sun’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev
Assigned: else » Unassigned
Status: Active » Needs review
FileSize
1.68 KB

Attached patch is against 6.x-2.x-dev.

sun’s picture

FileSize
1.73 KB

Plus 'mail ids'.

PROMES’s picture

Hello Sun,
It turned out we both were searching for the same information to implement mollom. Your patch for 6.x-2.x-dev confirmed my implementation seems right.

I forgot to mention in comment #19 that my guestbook_molom module is for guestbook 6.x-1.1 and mollom 6.x-1.13 and the current 6.x-1.x-dev version. No code change is needed in the guestbook module.

sndo’s picture

Hi

I've installed 6.x-2.x-dev incl. guestbook.mollom.21.patch.

It works. Thanks.

Only the input formula is always above or under the entries while setting separate side is used.

==> http://drupal.org/node/301779

An after deleting an entry, the redirection path is wrong.

http://fw-kleinluetzel.ch/fwkleinl//fwkleinl/guestbook
instead
http://fw-kleinluetzel.ch/fwkleinl/guestbook

==> http://fw-kleinluetzel.ch/fwkleinl/guestbook/delete/6?destination=/fwkle...

==> http://fw-kleinluetzel.ch/fwkleinl/guestbook/delete/6?destination=guestbook
this works

==> http://drupal.org/node/411486

lostcarpark’s picture

The guestbook_mollom module is working perfectly for me. I like this approach since it won't be broken by the next official guestbook relaease. Thanks!

James

chris.chambers’s picture

"Sun" suggested that I move this mollom issue over to guestbook so here its is. I am using PHP4

When trying to apply the latest mollom security update (15th September) this crashes the whole web site with the message.
Parse error: syntax error, unexpected T_ARRAY, expecting ')' in /freeola/users/x/x/xxxxxx/htdocs/elliots_messages/modules/mollom/mollom.module on line 1842

The only way to recover the site is to revert to version 6.x-1.13.
This happens on a number of web sites I have running Drupal in exactly the same way. However that are all on the same hosting service.

Chris

joelstein’s picture

Status: Needs review » Reviewed & tested by the community

The patch in #21 works great for me.

stella’s picture

Yep patch in #21 works for me! :)

sun’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for reporting, reviewing, and testing! Committed to HEAD (2.x).

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

chrisi1002’s picture

delete

JamesMarie’s picture

Category: feature » support

OK - I am guessing I'm doing something wrong... I have tried to use the patch in #21 several times, and every time my site turns into a white screen until I replace the code with the original again. All I am doing is taking the code from #21 and using it to replace the code in guestbook.module - is that the correct way? That is what I have done before with patches, but I thought I might be missing something. :)
Any help is greatly appreciated! Thanks!

Eric_A’s picture

Category: support » task
Priority: Normal » Critical
Status: Closed (fixed) » Reviewed & tested by the community
FileSize
1.77 KB

This code lived for a short time in CVS HEAD, but we've lost this in 6.x-2.x after the Great Git Migration, unintentionally.
Here's a re-roll of the actual committed code, including the changes to CHANGELOG.txt.

sun’s picture

Priority: Critical » Normal
Status: Reviewed & tested by the community » Fixed

Good catch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.