Posted by Boobaa on March 1, 2010 at 8:42am
Jump to:
| Project: | Inline Form Errors |
| Version: | 6.x-1.1-beta1 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Please consider using system_settings_form() to provide more straightforward UI for localization of IFE's "general error message".
When I added ife_general_message to $conf['i18n_variables'], nothing changed at <a href="http://example.com/admin/settings/ife">admin/settings/ife</a>. When I replaced
<?php
return $form;
?><?php
return system_settings_form($form);
?>ife_settings_form(), i18n started to tell me This is a multilingual variable., but I started having two "Save configuration" buttons.
Expected behavior would be having only one "Save configuration" button with i18n support, too.
Comments
#1
I'll look in to this, but the problem with the system_settings_form() is that it takes over control of submission and theming of the form. Since I use my own theme and schema I expect conflicts, I don't want system_settings_form() handeling de form_ids and options. (the system_settings_form() also places it's ow submit button, which is why you get two submit buttons is you change the return).
I also checked the form_alter in the i18n.module and it specifically searches for forms that have the system_settings_form theme attached.
#2
In the meantime you could use the translate interface since the message is run through t() before it is printed.
#3
I added multilingual variable support by letting i18n process the form if the module exists. It's a different approach than what you suggested, but the result is the same.
I'm going to postpone the issue for now and leave it as a reminder to have a closer look at system_settings_form().
#4
i18n support is available, just not with system_settings_form()
#5
Automatically closed -- issue fixed for 2 weeks with no activity.