Closed (fixed)
Project:
Paging
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Mar 2010 at 03:56 UTC
Updated:
20 Jun 2013 at 17:48 UTC
Jump to comment: Most recent file
I would like to ask if the project Paging module has plan for migrating to Drupal 7? I am interested to help migrating Paging module to Drupal 7.
| Comment | File | Size | Author |
|---|---|---|---|
| #27 | paging_7.x-1.x-dev.zip | 9.25 KB | frank ralf |
| #25 | d7_paging.zip | 10.08 KB | frank ralf |
| #15 | paging.zip | 33.64 KB | webankit |
Comments
Comment #1
Gurpartap Singh commentedIt'll definitely be developed for Drupal 7.
Comment #2
arpeggio commentedI see. thank you.
Comment #3
becw commentedI'd like to help update this module for Drupal 7. There are a couple changes in D7 that should influence the update path. Thinking about it, I realize that my ideas might diverge too far from how this module works in Drupal 6. In the interest of building on what already exists, here's a brain-dump of some of the things I've run into with making this module useful on D7:
I'm sure I'll run in to other things, and I'm not sure whether I will pursue a more divergent update or try to stick closely to the D6 implementation, but if you have any input one way or the other please let me know!
Comment #4
anavarreHi,
Any update on this ?
Thank you
Comment #5
superflyman commentedsubscribing
Comment #6
camdarley commentedsubscribing
Comment #7
arnieswap commentedAny update? We can help testing the D7 port.
Comment #8
Dalabad commentedsubscribing
Comment #9
agileware commentedFor a drupal 7 solution you can try the smart paging module.
I upgraded a site from d6 using paging to d7 using smart paging and it worked with no problems.
Comment #10
arnieswap commentedSeems like this module is not going to D7. Smart Paging looks impressive, will give it a try.
Comment #11
lugir commentedsubscribing and try #9
Comment #12
endiku commentedsubscribing
Comment #13
RmrJmrGrl commentedWould like to see a D7 version as well!
Comment #14
webankit commented+1
Comment #15
webankit commentedI ran a simple coder upgrade
(not working)
Comment #16
zamir commentedsubscribing
Comment #17
lsancheztapia commentedsubscribing
Comment #18
basicmagic.net commentedsubscribe
Comment #19
lsancheztapia commentedHello,
I found this: http://drupal.org/project/smart_paging . I will check.
Comment #20
dalinWould be great to see a D7 module of this. I've probably wasted 25hrs with big architectural issues in Smart Paging module.
Comment #21
damiandab commentedsunscribing
Comment #22
jenlamptonI'm going to need this module for Drupal 7 in a few weeks. Has anyone made any progress on a 7.x branch yet?
Comment #23
jenlamptonI'm starrting on this now. The code lives in a sandbox for the time being, but I'd love to get a 7.x branch started here, and I'll provide some patches :)
Here are some thoughts and notes I wanted to jot down while upgrading:
1) should paging have it's own admin permission? It's currently using 'administer site configuration'
2) where should we put the admin settings in the menu? I guessed admin/config/content/paging.
3) Right now paging just works on nodes, but we could expand this to work for any entity type.
4) I left out the vertical tabs on the admin interface, since this is not the correct usage of verticaltabbage.
5) I added a selector on the settings page so you can choose which field the pagebreaks should come from.
6) I'm removing support for different pager styles, only theme_pager will be called.
7) positioning above or below for the pager is now replaced with hook_field_extra_fields()
8) Removed the AJAX page reload feature, but others can add it back if it's missed.
9) some settings are now global rather than per content type (separator string, number of pagers per page)
10) removing the Page names interface part. that will need to be added back in later.
11) removing pager insert widget. that will need to be added back in later if it's missed.
12) adding WYSIWYG support, as per #269039: Provide WYSIWUG API module support for Paging
Okay, I'm calling it a night, but I've got a good start. I added // @TODOs in the comments wherever I changed something that's going to need an upgrade path fro D6 => D7.
As of now, this version is working for me: http://drupal.org/sandbox/jenlampton/1636102
Comment #24
N4R4YAN commentedfollowing this, this module is perfect but it really needs a port to drupal 7 :)
Comment #25
frank ralf commentedThis is for those not familiar with Git. I just pulled the code from http://drupal.org/sandbox/jenlampton/1636102 and zipped it so more people will have the chance to test it ;-)
Comment #26
frank ralf commentedSetting status to "needs review".
Comment #27
frank ralf commentedI ran the above code through Coder and made some minor amendments. The module works as promised. It would be great if this could be made an "official" D7 release soon so more people could review the code.
Comment #28
Maks commentedThis module is perfect but it really needs a port to drupal 7!!!!
Comment #29
VenDG commentedCould someone in charge please make this an official version 7 release. Thanks.
Comment #30
perisdr commentedI installed the module, enabled the paging filter for filtered html and full, enabled the paging for my content types, made sure that the pager was set to visible.
Nevertheless I cannot break my nodes into multiple pages. I can see the
<!--pagebreak-->in my source when editing the node but thats all. I checked again all the configuration steps in case I missed something but couldn't find anything.Then I thought maybe there is a problem since I have the Global redirect enabled which has problem with multipage nodes. I disabled it but still nothing. Has anyone been able to run the 7.x version? I was hoping it could work with global redirect (because smart paging doesn't) but I can't make it to work at all. I' ll try to set it up again in a clean drupal installation just to make sure that it does indeed work. Maybe it has conflict with another module.
Comment #31
jenlamptonI've made some changes to fix a minor PHP notice I was getting: http://drupal.org/sandbox/jenlampton/1636102
@Frank Ralf would you be willing to provide patches there, or commit directly to my sandbox project? I'd love to get some of your improvements included in version control so that your work is not lost :)
@N4R4YAN and @Maks this module has a port to Drupal 7. It's currently in my sandbox (http://drupal.org/sandbox/jenlampton/1636102) and marked needs review. Would you please review it for us? :)
@VenDG I have contacted the module owner to ask if I can help get an official release out or Paging. We'll see what he says.
@perisdr I would check the order of your filters under admin > config > content authoring > text formats. And for the Filtered HTML input format, you also need to make sure that you have allowed HTML comments by adding
<!-->as a tag, in the list of "Allowed tags".(Also un-assigning from myself.)
Comment #32
frank ralf commentedHi Jen,
Thanks for the feedback. If you could make me co-maintainer of your sandbox-project I'll see what I can contribute (as soon as I find the time).
tia
Frank
EDIT:
And have you tried to contact the maintainers of the Paging module to make you (co-) maintainer?
Comment #33
Gurpartap Singh commentedI have added @jenlampton as a maintainer for 7.x version.
Comment #34
frank ralf commentedGreat. Thanks!
@jenlampton
Will you move your sandbox code over here or will you keep it as a separate project?
Comment #35
jenlampton@Frank Ralf I am moving it over here. No need for another project :)
Comment #36
frank ralf commented@jenlampton
Great!
Comment #37
jenlamptonsoon, grasshoppers!
Comment #38
frank ralf commentedHm, the 7 branch is available from Git but still doesn't show up on the project page. As there's still a master branch lying around this might be the culprit and should be moved to a major version branch according to Moving from a master to a major version branch.
(see Release naming conventions)
As soon as the 7 branch is visible to the general public I would suggest closing this issue.
Comment #39
value commentedAny updates on an official D7 release? Looks close. I'm already stuck converting a ton of fields and Image data would be awesome not to have to tackle configuring Smart Paging on top of my headaches :D
Ah I see there is a branch available but not on the Project page.
Comment #40
chegor commentedHi all!
May be someone has an idea how to hide some cck fields on the second, third etc. pages of the pager? (such as main image for a node, which I don't need to display on other than first page)
Thanks in advance
Comment #41
forestmars commentedAfter reading through this thread it's not clear to me what Paging module offers that Smart Paging module doesn't, ie why it needs a D7 version when Smart Pagingg already seems to do this. (I did see #20 which has credence however it's not clear to me what the actual issue is with Smart Paging...?)
Comment #42
jenlamptonThis issue should be about the Drupal 7 port of paging. (updated title)
I think the real question is why the author of smart_paging felt it necessary to create a duplicate module back in 2010, instead of working on Paging. Paging has been around since 2005, and smart_paging was created in 2012. I for one would love to see the two merged in the future, and if Gurpartap Singh agrees, would welcome arpeggio in the issue queue over here :) Can you please open an issue in that queue and point Robert over here?
As to why this module should continue to exist, the one thing I can see being super important is the upgrade path. Does smart_paging provide a path from drupal 6 paging module?
@Frank Ralf the new branch was added for cleaning up the issue queue, there is no code there yet, but that all changes this weekend :) I will close this issue as soon as you can grab a dev tarball.
Comment #43
jenlamptonInitial D7 port is in the git repo now under the 7.x branch.
Closing this issue. :)
Comment #44
frank ralf commentedHi Jen, thanks for your efforts!
However, the problem mentioned at #38 still seems to be unsolved.
Comment #46
frank ralf commented@#42
I hope to get the ball rolling by posting #2023135: Joining forces with Paging module? ;-)
Comment #47
jenlamptonThe problem in 38 is fixed, please see the project page to download the 7.x dev branch.