I've created this issue within Related Links so that I have a place where I can post patches to the module as they become available. This approach was necessary because the code changes I'm making are incremental, and it would be too difficult to separate the new features into individual issues with their own patches.

Please post any feedback that you may have. I'd like some more ideas on how to define these features, and any suggestions for implementing them. Specific things like coding should be discussed here while more general project issues should be discussed on the project page, Best Related Links Project.

CommentFileSizeAuthor
#8 relatedlinks.module.patch_4.txt27.6 KBcolan
#6 relatedlinks.module.patch_3.txt27.34 KBcolan
#5 relatedlinks.module.patch_2.txt27.24 KBcolan
#4 relatedlinks.module.patch_1.txt15.95 KBcolan
#3 relatedlinks.module.patch_0.txt4.8 KBcolan
#2 relatedlinks.module.patch.txt9.49 KBcolan
#1 relatedlinks.module.subheadings.patch_0.txt5.36 KBcolan

Comments

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
StatusFileSize
new relatedlinks.module.subheadings.patch_0.txt5.36 KB

This patch adds subheadings to the "Related links" block. It should make it easier to determine what the link type is for each link.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
StatusFileSize
new relatedlinks.module.patch.txt9.49 KB

Moved the links from the taxonomy block out of their own block. They are now in the "Related Links" block, and the "Related terms" block is gone. Enabling/disabling the taxonomy links is now done from "administer ->
related links". Previously, the block was enabled/disabled from "administer -> blocks".

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
StatusFileSize
new relatedlinks.module.patch_0.txt4.8 KB

Changed the input format for adding manual links. It's now more user-friendly than the classic HTML-formatted style.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
StatusFileSize
new relatedlinks.module.patch_1.txt15.95 KB

I just realized that posting changes between revisions is a silly idea. From now on I'll be posting the complete patch with the differences between CVS (1.11) and where I'm currently at. Here is the first installment of that. It includes all of the patches I've posted so far.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
StatusFileSize
new relatedlinks.module.patch_2.txt27.24 KB

Here's the latest edition.

New Features:

  • Redesign of the configuration UI
  • More help
  • Link type controls for weight, titles, and limits
  • Checkbox controls for activating/deactivating taxonomy vocabularies
  • A sorted result set. Links are now sorted first by weight, then by type, and finally alphanumerically.

A special thanks goes to Tones for fixing some of my previous bugs.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
StatusFileSize
new relatedlinks.module.patch_3.txt27.34 KB

This new patch fixes http://drupal.org/node/72882, the access control problem that allowed users creating a new forum topic to add related links.

TomArah’s picture

TomArah commented

Works very nicely - thanks very much.

Not sure of the etiquette and processes involved but wouldn't it make sense to float this off as a new bestlinks module or to integrate it into related links? I'd never tried patching before and it was not easy - in the end used cygwin (based on these instructions ) and the 4.7 version of relatedlinks as the CVS version has been updated so caused an error - but most users won't make it that far.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
StatusFileSize
new relatedlinks.module.patch_4.txt27.6 KB

I just heard from the maintainer earlier today. He said that he'd try and review some of my stuff this weekend. So, it shouldn't be too long before at least part of it gets into CVS. And before that happens, I may as well submit one more patch fixing this bug, the one in which links for certain link types show up even though they're disabled.

And yeah, this one won't work either, but I'm doing this for his benefit. It should get resolved soon, but if not, I can always post the whole file later.

Zen’s picture

Zen commented
Status: Needs review » Needs work

This is an *excellent* start, Colan. I've had a quick browse through your patch. My comments:

  • When the headers for the three link types are empty, an empty h3 tag is output. Ideally, if a set of links doesn't have a header, it should be added to the previous list.
  • Manual links won't accept links with title 0.. please be wary of using the ! operator to check for existence / emptiness. I'm not sure about this block of code.
  • Please conform to Drupal's coding standards. We also don't use the concatenation operator to wrap strings (this is usually an editor issue). No doublespaces, watch your indentation, etc.
  • Please lose the "function overview" comment block at the top. Any editor worth its salt will provide you with a list. Please also leave in the module overview and make your additions to it.
  • It will also ease integration if this can possibly be broken down into two or three patches.
  • I intend to initially implement this only in HEAD.

All I can think of right now. Please also check my comment here.

Thanks :)
-K

Zen’s picture

Zen commented

N.B: If you can break it up, please open separate issues for each patch - cheers!

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Thanks for the feedback!

I'm breaking it up into three separate issues: Combine "Related Terms" Block with "Related Links" Block, Enter Manual Links in a User-Friendly Way, and More Configuration Options.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Assigned: Unassigned » colan

I just created an issue and patch for Enter Manual Links in a User-Friendly Way.

Zen’s picture

Zen commented
Status: Needs work » Active

First two of your patches are through. Block management is the final one. Please submit a patch when you can, against HEAD.

Cheers,
-K

Zen’s picture

Zen commented

s/block management/advanced configuration

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Okay, I just posted a patch for More Configuration Options. That should be it for this set of issues. Once this last one is finalized & committed we can close this issue. More issues related to this project will be issued individually.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Any project updates will be posted here.

Zen’s picture

Zen commented
Status: Active » Fixed

Marking as fixed. Some of the tasks in this patch will be introduced via http://drupal.org/node/91543

-K

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)