I updated the module from 1.5 to 1.6. When I ran update.php, it produced the following errors:

array_merge() [<a href='function.array-merge'>function.array-merge</a>]: Argument #2 is not an array in /update.php  op regel 174.
Invalid argument supplied for foreach() in /update.php  op regel 338.

And now the module is broken:
Users can only see the "results" after they voted, even if it's set to always show the votes.
If they vote and can see the votes, the max votes it shows for an option is 1
E.g. 1 user votes on option 1, 2 users vote on option 2 and a fourth user doesn't vote.
The fourth user is not able to see any results, even when he clicks on "Results"
The other 3 users do see "results" but it shows: Option 1: 1 vote (50%), Option 2: 1 vote (50%)

The tab "votes" does list all votes correctly.

The module now also puts a "Results" tab on every node.

I tried the dev-version, didn't work. I tried removing the entire module and readding it, doesn't work. I tried running update.php again, didn't work.
I also can't revert to the previous version because the module is not listed in the uninstall list.

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Postponed (maintainer needs more info)

What voting mode are you using?

In the meantime, you can get the previous release at http://drupal.org/node/48244/release .

DruKaz’s picture

DruKaz commented
Status: Postponed (maintainer needs more info) » Active

I'm using selection.

Using the previous release works even less now because the update did make some changes in the db.
It behaves pretty much the same, with the difference that voting is no longer possible.

DruKaz’s picture

DruKaz commented

Ok, when I make a new Poll after i installed the previous version again, I can vote on it. So it behaves exactly the same now:
- Votes are only visible after you have voted (even if setting is different)
- Only 1 vote per option gets counted
- "Results"-tab is visible on every node-type.

It's a bit of a luck that yesterday we postponed our launch, wich was planned for tomorrow :P

DruKaz’s picture

DruKaz commented

Ok, my mistake again. The old one does appear to be working properly.

MartinWalla’s picture

MartinWalla commented

I am affected by the same error specified above. Running a small private web site only.
Will there be a new version of the decisions module that will fix this (so i simply wait for it) or will this take weeks (so i have to revert to previous version) ?

ezra-g’s picture

ezra-g commented

We should be able to address this this week. In the mean time you can use the previous release if necessary.

floater’s picture

floater commented

I also found result I didn't expect and changed the code as follows to get correct results:

// the value is the position chosen in this case, we just want to increment
/// modified lines!!! with the original line only nbr of selected tags is used
/// $votes[$voteval]++;
/// instead add the value for that tag
$votes[$voteval]+=$result['value'];

ezra-g’s picture

ezra-g commented
Title: updating breaks module » Results tab appears for non-decisions nodes
Status: Active » Fixed

I've committed a fix that prevents the results tab from showing up on non-decisions nodes. The conditional in there really needed a cleanup! See http://drupalcode.org/viewvc/drupal/contributions/modules/decisions/deci... for those who are interested.

And the dev version has #743198: Anonymous users can't view results fixed.

People have reported many different problems in the current issue, which makes it hard to identify and address each problem one-by-one. I'm marking this issue as fixed for the tabs fix. Please open a new bug report for each individual bug (or comment on a relevant existing one) so that we can better pursue all of the issues you are reporitng.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.