Posted by venkat-rk on July 27, 2006 at 6:33am
| Project: | Documentation |
| Component: | Correction/Clarification |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | git |
Issue Summary
Under http://drupal.org/node/23409, there are two nearly identical book pages on applying patches in Windows using Cygwin:
http://drupal.org/node/23164
http://drupal.org/node/32875
Can I redo that entire section on applying patches in Windows in the following manner and resubmit them?
1.) Top level page: Applying patches in Windows
2.) Child page 1: Gnuwin32 diff and patch >> http://drupal.org/node/32635
3.) Child page 2: Patching with cygwin >>combining nodes 23164 and 32875; will cover installing cygwin, patching a single file, patching multiple files.
An aside: Shouldn't *applying patches* be in the User or admin guide? Or in them also?
Comments
#1
http://drupal.org/node/60179 would be one more child page.
#2
already fixed
Specific patch instructions for window programs should go as child pages under http://drupal.org/node/60179
http://drupal.org/node/23164 is in moderation, please compare it to http://drupal.org/node/32875 and comment on what should be merged into 32875
The gnuwin pages have been removed in favor of unxutils
#3
-1 patching is not an admin task.
#4
Noted, as also your comment about retaining only visual diff progs. that can save patches. Will do.
#5
I don't know. You have all these people looking to try out new features by applying patches and many of them seem to be administering drupal sites. Definitely not in the user guide.
I suppose admins who want to apply patches can find the handbook pages by searching drupal.org
#6
What do you mean with Top level page?
The Apply patches in Windows goes under:
(two levels) » Patches » HOWTO: Apply patches
Specific instructions for several windows 'patch' programs go under:
Patches » HOWTO: Apply patches » Apply patches on Windows.
To edit the Cygwin doc, just edit Patches » HOWTO: Apply patches » Apply patches on Windows » Cygwin
Creating patches on Windows goes under:
(two levels) » Patches » HOWTO: Create patches » Create patches on Windows.
Gnuwin32 has been removed in favor of unxutils (native port of gnuutils) as gnuwin is/was wrought with problems.
#7
I meant the Apply patches on Windows page.
Noted the other points. Hope I can do the edits within the next 24 hrs? I am a bit tied up with things today and actually bumped into the patch page when I was trying to work on my site.
#8
I think http://drupal.org/node/32875 (in the right location now) is already rather complete. A review is welcome (thanks b!).
#9
Changed the component to reflect the new component categorization. See http://drupal.org/node/301443
-dokumori
#10
Changed the component to reflect the new component categorization. See http://drupal.org/node/301443
-dokumori
#11
By way of review, as suggested in comment 8, I have just been through my first experience of patching a Drupal module under Windows following these instructions and I was amazed how awkward it was and how I had to follow a trail of comments and Google searches to succeed.
In the hope of helping I attach a zip file which contains
To use
#12
This issue is in the wrong queue.
#13
Thanks for your detailed description on patching on windows. I am receiving an error though when click on the patch file.
J:\mydrupalsite\site\sites\all\modules\views>"C:\ProgramFiles\GnuWin32\bin\patch" --verbose 0<"J:\mydrupalsite\site\sites\all\modules\views\views-648484_0.patch"
The system cannot find the path specified.
Thanks for any suggestions
#14
Jim -
We don't upload files like that to handbook pages, but the instructions and links would be a great addition to the page. You can go ahead and add the text to the page yourself, and then mark this issue as status "needs review", and a docs team member will review the formatting and changes.
Thanks!
#15
I get the same error. Anyone have a solution?
#16
Thanks for your patchwin.zip solution Jim.
For others, you might need to edit patch.bat to include necessary arguements. I need to for SimpleTest patch.
For exmaple, if you want to run
patch -p0 < D6-core-simpletest.patchthen add the -p0 argument before --verbose in line 2 of patch.bat#17
I thought I was on to a winner with Jim's nice clear instructions, but have hit the "The system cannot find the path specified" error too.
I've tried adding -p0 before the --verbose but it stil doesn't play ball.
Suggestions anyone?
#18
This issue is about patch _documentation_ and is not for _support_ on patching.
Please ask in the forum.
#19
well done!
#20
J:\mydrupalsite\site\sites\all\modules\views>"C:\ProgramFiles\GnuWin32\bin\patch" --verbose 0<"J:\mydrupalsite\site\sites\all\modules\views\views-648484_0.patch"The system cannot find the path specified.
patch.bat is hardwired to look for both programs in
C:\ProgramFiles\GnuWin32\bin\. I had placed both programs inC:\ProgramFiles\patch, and consequently received the same error message. I edited batch.bat, and no longer get the error message.#21
ancient issue on patching on windows - adding git tag as this probably needs to be reviewed
#22
The duplication has been addressed at some point, and only http://drupal.org/node/32875 remains. I think it's safe to close this. If I'm mistaken, then by all means, reopen.
#23
Automatically closed -- issue fixed for 2 weeks with no activity.