Hey, just wondering what the plans are for upgrading to D7. If you aren't planning on upgrading soon, I might have a crack at creating a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | graphviz-filter-d7-v4.patch | 9.58 KB | anj |
| #13 | graphviz-filter-d7-v3.patch | 9.7 KB | anj |
| #8 | graphviz-filter-d7-v2.patch | 10.81 KB | naught101 |
| #2 | graphviz-filter-d7.patch | 3.1 KB | naught101 |
Comments
Comment #1
infojunkieI've no plans yet. I'd be delighted if you went for it!
Comment #2
naught101 commentedWell that was easy. This works. Haven't tested extensively, but it doesn't throw any errors for me..
Comment #3
infojunkieWoohoo! I'll review it soon and get back to you.
Comment #4
naught101 commentedby the way, this only includes the two core modules.. dunno how to download the others with CVS yet..
Comment #5
infojunkieDownload from DRUPAL-6--1 branch instead of HEAD.
Comment #6
naught101 commentedok, that version is significantly different. I assume the core modules should be fairly easy, but I've hit #613918: file_create_path and file_check_directory vanished with no upgrade notes - code change with no docs..
Comment #7
naught101 commented#517814: File API Stream Wrapper Conversion changes a lot of things in this module, most of which are not documented. I haven't got my head around stream wrappers yet, but I will keep trying. Hopefully some documentation comes along soon though.
Comment #8
naught101 commentedOk, done. This is working pretty well, as far as I can tell, although I haven't tested it thoroughly.
Some changes that need to be checked:
- Graphviz_filter_process() is now graphviz_filter_filterproc(). This is because there's a new hook_process in d7. This took me days to work out, and caused extreme pain. The new name should possibly be something else.
- All path variables are now stored as public:// streams. They should probably all have their names changed to reflect that.
There might be other things that I've missed. I'm happy to update the patch once I get some feedback on the above.
cheers
ned
Comment #9
mccnoc commentedAre there any further plans to update this? Looks like a lot of functions in Drupal core have changed since this last patch was posted, and the module no longer appears to work with the 7.0 release.
Comment #10
Vc Developer commentedsubscribing!.. Anybody?
Comment #11
naught101 commentedPlease review the patch. If there's problems (which there probably will be), report them back to this issue.
#1056784: No D7 Graphviz Filter! marked as a duplicate.
Comment #12
anj commentedThe patch in #8 was not enough - I had to replace every instance of
with
Once that was done, it appeared to work just fine, but I'm only using it to build node reference graphs.
Comment #13
anj commentedHere are the changes I mentioned in #12, combined with the original patch from #8 to make a new patch.
Comment #14
clemens.tolboomAll (?) .info files
whitespace
I'm working on #1209526: Add support for graphviz_filter module. Will come back on this on.
Comment #15
anj commentedOk, tabs swapped for spaces in the module, and newlines appended to all info files. How's that?
Comment #16
clemens.tolboomNotice: Undefined index: PATH in _graphviz_filter_filter_settings() (line 147 of /Users/clemens/Sites/d.o.clone/downloads/graphviz_filter/graphviz_filter.module).
Trying to set the path fails.
Comment #17
anj commentedHum, I'm afraid that's in the part of the code I didn't touch, and I don't know how to fix it. Furthermore, that line is not touched at all by the patch that I submitted, and comes from the original code, so I'm really not sure how to proceed. Sorry.
Comment #18
clemens.tolboomCould use default settings.
http://api.drupal.org/api/drupal/modules--filter--filter.api.php/functio...
$format is not used by graphviz_filter_filterproc
Is that functor really necessary?
I had to replace variable_get by $filter->settings[...]
My PATH is empty so changed the $_ENV
function args changed according to http://api.drupal.org/api/drupal/modules--filter--filter.api.php/functio... states
Hope you could apply these throughout the module ... I'll have code for graphapi :-(
Comment #19
anj commentedAs I've only been making rather superficial code changes and I'm not currently up to speed on the Drupal 7 API, I'm not really competent to answer these questions and make these changes. I'm happy to tweak and test patches, but that's all I can do right now.
Comment #20
TehJott commentedI think in graphviz-filter-d7-v4.patch line 148 should be:
instead of:
Comment #21
jtbayly commentedsubscribe
Comment #22
bakr commentedsubscribe --- SUPER
Comment #23
infojunkieCommitted to new D7 branch. Fixed some of the concerns in #18 and #20. Please keep this issue closed and open new issues as you encounter them.
Thanks to all contributors!