New features

this patch is not working and no modalframes are called anymore...so reverting back to the last dev one

I am interested in ModalFrame and your module gives a nice bridge for people without coding knowledge to work with ModalFrame, however, I will test the #4 Patch again and I would let you know.

I tried the patch in #4 and got this message:

patching file automodal.js
Hunk #1 FAILED at 1.
1 out of 2 hunks FAILED -- saving rejects to file automodal.js.rej
patching file automodal.module

I can post the .rej file's code if anyone is interested

same problem as #8.
contents of automodal.js.rej:

***************
*** 1,18 ****
  (function ($) {
-   Drupal.behaviors.automodal = function () {
-     var selector = Drupal.settings.automodal.selector || '.automodal';
-     
-     var settings = {
-       autoResize: true,
-       autoFit: true,
-       width: 600,
-       height: 400,
-       //onSubmit: function (a, b) {} 
-     }
-     
-     $(selector).click(function () {
        settings.url = $(this).attr('href') || '#';
-       
        if (settings.url.indexOf('?') >= 0) {
          settings.url += '&'
        }
--- 1,13 ----
+ // $Id$
+ 
  (function ($) {
+ 
+ Drupal.behaviors.automodal = function (context) {
+ 
+   $.each(Drupal.settings.automodal, function(selector, settings) {
+     $(selector +':not(.automodal-processed)', context).addClass('automodal-processed').each(function () {
        settings.url = $(this).attr('href') || '#';
+ 
        if (settings.url.indexOf('?') >= 0) {
          settings.url += '&'
        }

For the people who are having trouble applying this patch...
Have you applied the fix at #769426: IE 7 script error ?

That fix would cause this patch to not apply cleanly, and it's the only thing I see in the issue queue that might cause this?
To fix the patch locally, one should only have to apply the same change to the patch itself as applied to automodal.module (remove the trailing comma in settings)

Note: All of the following patches I've posted depend on patch in #4
http://drupal.org/node/767128#comment-2833562

Along the lines of porting features from Popups UI, I've put this together...

This patch adds a hook_automodal() that functions almost identically to hook_popups()
(I copied most of the implementation from Popups UI directly, with a few changes to suit automodal)

If you're considering using these features, you might also want to check #685364: close modal on form submit

The combination of these two patches (and possibly the one below, still not sure if that's going to be applicable for most people) should allow very easy porting of existing Popups UI reliant modules.

EDIT: Using a RegExp in JavaScript just feels dirty... all the rest of the rambling below applies, but don't use this patch!

And I ran into a problem with '/'s in selectors - they weren't getting escaped properly...

I'd be very interested in knowing if other people get errors related to this when trying to add a selector containing a '/' (ex a[href*=path/to])
(FireFox was reporting something along the lines of "Expected selector to end with ] found /")

I would be particularly interested in knowing if anyone else has this problem, however - because I'm very suspicious that this could be a local bug related to jQuery 1.8
(which, of course, is not AT ALL supported in D6... so if it's a local problem only, I'll probably think on other ways to fix this)

Another attempt to fix the selector encoding, this one feels a bit less dirty

Still not sure if this is a jQuery 1.8 related problem or not...

And another patch, this one adds the ability to parse functions from strings in settings.onSubmit

This patch depends on http://drupal.org/node/685364#comment-3129642 - but wouldn't be difficult to reroll...

patch in #14 needs a sanity check - other modules (Autoload, I think) might have already done the work for us.

Try that again:

subscribe. Will look into this soon.

@Vector for the new function piece why aren't you adding the function via js and calling it?

@Vector The more I look at it the more I see to problems with what you posted.

1. Implementing a hook_automodal isn't really needed if there is automodal_add. If someone wants it on every page they can just use hook_init and automodal_add.
2. JavaScript functions shouldn't be written in PHP and passed through the settings. This is just a bad bad bad idea.

The one place I could see a hook is hook_automodal_alter that passes in a selector and settings. Giving other modules an option to alter the settings for the selector. But, that would need to be another issue all together.

Code based on #4 has now landed. http://drupal.org/cvs?commit=408872

For details see the API.txt file and the new function automodal_add().

Also, the default for the autoscan is on. This will preserve backwards compatibility for a number of sites.

There is, also, a hook_automodal_alter.

I would love testers of this.

This seems like a stupid question, but I'm used to testing patches: Is the new code to test to be found in 6.x-1.x-dev (Aug 17 2010)? Or do we pull it from the CVS link in #19?

please somthing about that??

http://drupal.org/node/872352

thanks

@keva This is now in 6.x-1.x-dev. When I'm working on modules I do not tend to use patches as they slow down the process. I only work with patches on other peoples modules and core.

Thanks mfer - I'll test in the next couple of days.

Where do I find the value for this 'selector'? Here's the php code I use to invoke an automodal link on my page:

function Modal_Popup( $URL = '', $Text = '', $Modal_Attributes = null, $Link_Attributes = '' ){
#	Test values:
	$Link_Attributes = 'id="my_selector"';
	$Modal_Attributes = array(
		 'width' => 200,
		 'height' => 580 );
#	End test values.
	if( is_array( $Modal_Attributes )){
		automodal_add( '.my_selector', $Modal_Attributes ); }
	return(
		Wrap_HTML(
			'a',
			'href="'.$URL.'" class="automodal" '.$Link_Attributes,
			$Text )); }

... but the module 'reverts' to the default values. (The Wrap_HTML function just puts < a../a > tags around the values passed to it.)