Closed (fixed)
Project:
Taxonomy Views Integrator
Version:
6.x-1.1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Apr 2010 at 10:13 UTC
Updated:
31 Jan 2013 at 00:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
b-prod commentedThis patch modifies view identifier: instead of using the view id, it uses the view name.
This allows to be able to select some default views, which are defined in contributed modules. Indeed, such views don't have a view id (except when they have been overriden) so without this patch it is impossible to use them.
The patch implements hook_update_N, so you need to run update.php.
Comment #2
derekwebb1 commentedThanks for the patch B-Prod! I will probably be rolling this and a postgres patch into the next release (out this weekend hopefully).
Thanks for the effort!
Cheers, Derek
Comment #3
derekwebb1 commentedI patched the code with these changes however I found that the upgrade path is somewhat incomplete - it does not convert old view_ids to view_names in the db.
I am going to try to have that worked out this weekend or sometime in the not too distant future.
Once that is taken care of we can test a bit and create a new release.
Cheers, Derek
http://collectivecolors.com
Comment #4
b-prod commentedYes, actually I didn't take care about possible existing settings. It could be done through tvi_update_6002() function. If I find some time (for this week it is impossible, but maybe next week) I will work on it.
Comment #5
b-prod commentedComment #6
yuriy.babenko commentedI also ran into this issue today; it would be great to get the patch into a new module release!
Comment #7
sethcohn commented+1 to this, I'd use with this support. Most of my views end up in code..
Comment #8
derekwebb1 commentedUnfortunately there is no upgrade path defined yet. The patch works great but it requires one to manually re-assign all tvi assignments. If I toss that out there as is... I will never hear the end of it. I need to either a). Find someone to write the upgrade path, or b) Do it myself.
I am really a front-end guy so that's uncharted waters for me but I will give it a whack.
Cheers, Derek
Comment #9
derekwebb1 commentedDev release includes this patch and a complete upgrade path. Thank you for your assistance B-Prod!
Comment #10
derekwebb1 commentedI meant to ask you to test dev branch... so setting this to "Needs Review" Thanks!
Comment #11
b-prod commentedThe DEV version works fine for me.
Note that I applied it to the patched version (769858: Doesn't show default Views that are not stored in database (#1)).
Maybe a check by someone who does not have applied the patch above could be useful.
Comment #12
braindrift commentedworks fine for me (tested on 1.1)
Comment #13
b-prod commentedIt seems that the patch is working properly. Set tag to "reviewed".
Comment #14
derekwebb1 commentedThanks for the testing! I will get this rolled out fairly soon.
Comment #15
jenna.tollersonHey there all, great work. I'm looking for this fix. Any chance of this fix getting rolled into official release soon?
Comment #16
Greg Varga commentedsubscribe. Great module, thanks! Would be glad to see a new official release.
Comment #17
traviscarden commentedThanks for this patch, B-Prod! deeporange1, this has been sitting for quite a while. Can we do anything to help get it into a new release?
Comment #18
duaelfrThe patch seems to be included in the last dev version.