Migration to Drupal 7

Hi Paul and others,

I finished the conversion of the base module to Drupal 7. I implemented all new hooks and definitions. The only thing I couldn't convert is the hook_user_update (now called flickr_user_presave). The function db_affected_rows() doesn't exist anymore, so we should implement another way of checking if a user has been deleted. (#509122: RIP db_affected_rows())

That said, all is working correctly. See the attachment.

Now I will start working on the flickr_block module first. Can you provide me with CVS access so I can commit my code?
I'd like to offer to help you with the D6 issue queue too.

V3, now with flickr_block integration. The rest will follow after I got CVS access :)

Hi all,

Here is a new version.

- I corrected a small error in the flickr_block module (theme function attributes, photo instead of p)
- I added the flickr_filter module. Now also works in Drupal 7! :)

I take the module one at a time. Only left now are the flickr_field, flickr_tags and flickr_sets modules. Working on those!

You are welcome! You take a lot and you give back some, isn't that the idea of the community?

By the way, you can see the Block module working on my Drupal blog already. :D

Hi Paul,

I'll include his patch, no problem!
I'm currently working on the Tags and Sets modules.

They are working now in Drupal 7, but they are not doing what I expect them to do.
The problem is that they are not working as expected in the Drupal 6 version as well.

It is not clear to users that the url flickr/% exists. This is not explained in the README.TXT and the menu system doesn't link to it. My expectations were to find the Flickr listed in the user tabs. For instance, on user/1 we could have a tab linked to user/1/flickr. And also user/1/flickr/sets and user/1/flickr/tags.

I'll leave this for now and will port the module as is, with the same functionality.
We'll start another issue for the menu paths.

Flickr_sets and Flickr_tags included. Only left now is the Flickrfield module.
That one is a bit harder because CCK has been replaced by fields, which has caused some functions to be renamed and refactored.

Working on that one!

Started reviewing:

Flickr module
Working fine

Flickr block module
Working fine , with the exception of the warning (see screenshot)

..

Hi Paul,

thanks for testing. I fixed both issues.
The first error you gave was simple: I overlooked the user_load() change.
The other error was a bit more difficult. The problem with the current setup is that we have the following urls:

/flickr/1/tags/list
/flickr/1/tags/cloud
/flickr/1/tags/amsterdam

In the first two examples, the part after /tags/ is the function, but in other cases, this is an argument. Drupal cannot know if 'list' is an argument or a function call. For example: what if the tag is 'cloud'?

Therefore I made a change in the functionality. I used the old urls /flickr/1/tags/list and /flickr/1/tags/cloud for function calls and for the argument calls I use /flickr/1/tag/ARGUMENT (so tag instead of tags).

What would you think of this solution?

Hi Baris

Flickr photoset module
Working fine

Flickr filter module
Working fine

It's looking very good from where i am sitting

So just to recap we need to migrate flickr fields & fix our problems with flickr tags .

After the migration is complete and not earlier than the end of May i'll give you CVS access so that you can upload your
work to HEAD / make a branch for DRUPAL-7--1

Best,
Paul Booker
Appcoast

Hi Paul,

just to make sure: I changed the path to the Flickr tags sets.
Instead of /flickr/1/tags/Amsterdam the link should be /flickr/1/tag/Amsterdam.

We need to use a workaround to make sure Drupal does not see /list and /cloud as tags.

Thanks for the credits on the project page ;)

Paul,

Still working on the Fields migration. I'm almost done, but currently I'm spending most of my time working on my Google Fonts module.

Next weekend I'll try to finish the D7 version of the Flickr module!

Hi BarisW,

I have granted you CVS access to the flickr module.

Later when you have something to commit to CVS would you please first request clearance from me.

Thanks again for all your support.

Best,
Paul Booker
Appcoast

Hi BarisW,

Would you let us know if you have any further work to share and provide a brief summary of what
work needs to be done to complete the migration

Thanks again for all your support.

Best,
Paul Booker
Appcoast

Thanks Baris,

I'll see if i can complete the migration before the end of the month.

Best,
Paul Booker
Appcoast

For those who just need to authenticate with Flickr (login and regsiter using your Flickr account), you should check out the Janrain Engage module (http://drupal.org/project/rpx). There's already been one stable release for Drupal 7 and the development of new features is proceeding very quickly.

The Janrain Engage module supports integration with Facebook, Twitter, Myspace, Google, Yahoo!, and many other identity providers. (Currently, 18 different social networks and service providers are supported.) You can also choose to just use the Flickr integration features if you prefer.

Cheers,
Ben

Rerolled the patch.

Fixed bugs in formatters "Embedded Flickr.com flash slideshow" and "Link to photo set on Flickr.com". They didn't work at all.

Marking this bug as fixed as we now have our development branch for Drupal 7.

// Paul Booker