Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.CVS edit link for Chris Charlton
I have an install profile and some modules that I would like to share and maintain. The following is what I'd like reviewed for my CVS account: an install profile for DrupalCamp sites - http://chrischarlton.us/sites/chrischarlton.us/files/share/drupal/drupal...Here are some details of my other Drupal contributions:
1. Patched the Mibbit IRC module. I use this module for DrupalChat.net and plan to help it grow as a module and my listed contributions to this module are as followed.
* Valid XHTML output of irc chat iframe (patch) - http://drupal.org/node/314432
* Multiple IRC channels (patch) - http://drupal.org/node/314442
* Help text messes with XHTML validation (patch) - http://drupal.org/node/314725
* Additional params for chat window/iframe (patch) - http://drupal.org/node/314417
2. New module: User Registration Trends (Report) - screenshot: http://www.flickr.com/photos/chrischarlton/2808810604/ - This module shows user registration trends in monthly breakdowns, so you can see your good months. The report also displays stats against all registered users showing how many are unregistered, and finally there's stats breaking down email domains that are popular.
3. I manage LA Drupal, organize DrupalCampLA each year, and have been on the Drupal docs team since Feb. 2008. I am the co-author of one Drupal 5 book and the Drupal 6 Themes video course on Lynda.com.
-Chris Charlton
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | drupalcamp-install-profile.zip | 18.36 KB | Chris Charlton |
Comments
Comment #1
Chris CharltonAttached is my early DrupalCamp install profile code (plus a Drush Make file).
Comment #2
apadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.
Comment #3
apadernoThere is already such profile (http://drupal.org/project/drupalcamp); reading then http://groups.drupal.org/node/72373, I take than there is already another profile with similar purpose.
As reported by the CVS application requirements, the proposed module/profile/theme must not duplicate the work done by existing projects.
Comment #4
Chris CharltonChristefano started the project for me while I applied for my commit access. It's a placeholder for me to take over once I'm given access.
I asked him to chime in here.
Comment #5
christefano CreditAttribution: christefano commentedChris is correct about DrupalCamp being the placeholder project for the installation profile being discussed at http://groups.drupal.org/node/72373
Getting Chris a CVS account will help bring this work to Drupal.org.
Comment #6
Boris Mann CreditAttribution: Boris Mann commentedchristefano: just start an issue in the queue of the drupalcamp project saying that you want to have Chris be a co-maintainer, and then his CVS application will be approved. See http://drupal.org/node/59
Comment #7
dman CreditAttribution: dman commented+1 endorsement for Chris Charlton as a good contributor in general from me.
However first visual scan:
Co-maintainer status can push this straight through anyway I guess, but as far as the code review goes for an application, needs a tidy-up.
Comment #8
christefano CreditAttribution: christefano commentedBoris, my understanding was that it was up to Chris Charlton to open an issue to be a co-maintainer once he was granted a CVS account. I've gone ahead and opened an issue: #825586: add http://drupal.org/user/17089 as co-maintainer. Is there anything you can do?
Comment #9
christefano CreditAttribution: christefano commentedThanks for your review, dmain!
Comment #10
apadernoAs the current maintainer of DrupalCamp (a.k.a. christefano) already replied here, and confirmed what reported by Chris Charlton), the separated issue was not necessary.
As reported by dman, the code needs to be re-formatted to follow the coding standards.
Considering that this is a application to become co-maintainer, I am going to approve it. Any debate about the fact DrupalCamp could be rewritten to use the other profile, or merged into the other profile, are not considerations to take for this CVS application, as the project has been already created.
Comment #13
apadernoComment #14
apadernoI am giving credits to the users who participated in this issue.