Views Slideshow: Port to D7

I would like to get 6.x 3.x finished or at least in a more stable state before I move on to 7.x, but my time is so far pretty crazy this summer. I have some specific ideas that I want to accomplish for 3.x so as soon as I can commit those and we work through any bugs we can move to 7.x pretty quickly. Thanks for offering to help I'll get back to this issue as soon as I am finished with the sweeping changes.

Subscribing...

Hey elliottf - have you gotten very far with this? I don't want to duplicate any work you've already done. I used 6.x-1 in the past and LOVED it. Now I have a new project in D7 and just need a basic slideshow - nothing fancy. Let me know if you've been working on this. I'd be happy to help.

Re-rolling the patch in #5.

I've ported the js files in a way that don't change indentation to make the patch more readable.

@elliotttf: can you tell me if you made any changes to js files besides adding the (function($){})(jQuery); wrapper and implementing the 'attach' method?

Patch still needs work, I'm posting here for reference, and I should be working on the in the next few days.

The patch still don't include a port for the views_slideshow_cycle module.

Probably a good idea to not include cycle module. There will be big changes happening there. I'll get back to these patches as soon as I have cycle more stable. Thanks for working on this.

I posted a meta issue on what's needed to get done before we get to 3.0 beta. Once we get to beta I feel the module is really ready to port to d7.

#908848: What's left to get to 3.0 beta1

Alright beta1 is released. Time for the big port.

Port started.

subscribe

Thanks for working on this!

subscribe!

anything we can do to help, test, let us know.

I'm here to help as well :-)

Any progress on this? I have a few D7 projects and will have to proceed with an alternative solution if this isn't ready soon.

Subscribing

Subscribing too

Subscribing and patiently waiting :)

Subscribing..

Sub

Looking forward to have it in Drupal 7 !

Changing title to allow those of us tracking on our dashboard to see project name.

Here is an initial patch. This is a port of views_slideshow and views_slideshow_cycle. I have it up and running but there are issues in the UI with what is shown for certain dependencies. It's not perfect but it's a working start.

Thanks mfer!

I am in the middle of a possible rewrite. So this patch will need to be updated to match that when that lands. It still would be nice if people could test this patch and tell me how it goes. It should be easy to transfer this patch to the rewrite when the time comes.

thanks guy, hope to test the patch in #25 tomorrow.

Subscribing

I tested patch in #25 this morning in a very simple use case and it worked fine. Printed node teasers in a block w/ no controls, worked flawlessly.

I should note that the patch failed on both of the .info files...not sure if this was a mistake I made in patching or something wrong with the patch.

Subscribing

subscribing

subscribing

Subscribing.

Subscribing

Subscribing

I'm too tested the patch, and too have failed on both of the .info files.
More testing let me find that pager field doesn't work. Tumb. and Numb. work, field doesn't.

hmm... seems like that 6.x-3.x-dev not property work with field pager style. This patch solved problem for 6.x core, but I couldn't to merge it with 7.x core...

Here is an new patch there I combine patch from mfer in #25 comment, patch from this Issues of hibersh user. Replace don't exist function views_css_safe in D7 which is now drupal_clean_css_identifier and seems that field pager style now works fine (probably need more testing).
Also I attach working module for who don't like patches.

Subscribing

Can this be committed to a 7 dev release?

don't know, seems like front-end work fine, but performance at the views setup page killing me...

hmm... seems like bad performance in firefox, in google chrome all ok, so i think it's js-code have to optimizing.
but basically i think this can be 7 dev release

@vitok The 6.x-3.x branch is not completely settled on its features / setup. There are still more changes coming there. The plan is for the D7 branch to come when that has settled down.

Ok.

re #38: that diff is wrong, please create patches using the drupal standards: http://drupal.org/patch/create

Also please don't merge issues, it is really difficult to keep track of the Drupal 7 update when you apply changes for other bugs. Those issues should be resolved in their own issue queue first, then applied to the Drupal 7 branch once its created.

Is there any update on a freeze for 6.x-3.x?

@snufkin I am still working on a rewrite. I got sidetracked with family emergencies and my laptop having to go in for service, but I had made good progress previously. I don't have an ETA, but I am working really hard to have it asap. Thanks to everyone for their patience. (If they have any left.)

No worries, I know how it is to do contributed work when you are not payed for it... we would really like to use views slideshow on d7 for a project, so if you could point me where you could use the help then I would be happy to roll patches, test etc.

@mfer: the last commit made to the 6.3 branch was in October, 5. I'm not seeing many changes going on in CVS.

Drupal 7 is in RC1 state now, Views module for Drupal 7 is very stable, and people are using them to build their websites.

For Drupal 6 there's the 6.2 version which works very well, so IMO porting it to Drupal 7 seems more important then having a 6.3 release at all. I see no point in holding this back. But, well, I'm not the module maintainer.

I suggest we open a Drupal 7 branch sooner than later and commit what we have so far to that branch, have people test it and submit issues that would be then applied to the Drupal 7 version and backported to Drupal 6 the same way that occurs with core.

Re-rolling the patch in #25.

I've removed the "kitten killers" parts of the patch, such as removing trailing spaces, etc.

Also I've split the js behavior instantiation into two parts, to avoid changing indentation and making the patch bigger and hard to read.

And here's the patch.

Subscribe Time.

The patch didn't work for me. To get Drupal to 'accept' the module I had to change the version info added by the Drupal packaging script in the main .info file and the .info file in the contrib cycle module folder. After these changes I was able to enable the module, define views using the slideshow style but the slideshow wouldn't slide. :P

Maybe it's just me and I'm missing something here. :)

I have attached an image of the view settings and a zip with the patch results (i.e. the module I'm using)

Please dont post complete zip files, but patches instead, because it is more difficult for developers to work with your contribution. If you don't know how to handle patches please read http://drupal.org/patch.

The patch in #50 does change info files, just not all of them. If you have applied the patch and had to change a few things, please roll a patch so we can review it.

subbin'

@snufkin. I didn't include that zip as a patch. I included it in case the developer wanted to check whether I messed up or the patch from #50 really doesn't work (as I reported).

I didn't mean to fix the .info files... even with those fixes the patch from #50 didn't work for me.

subscribe

subscribe

subscribe - once finals are over, hopefully I will have some time to help test and patch.

Subscribe

I've been playing with this a bit today but like it was said earlier, I can't get it to display more than one image in the slideshow. Can anybody point me in the right direction on this? I would like to contribute but I am not a php guru so it would be nice to know where I need to look...

Well, by looking at the page source it seems that the js is loaded (both jquery.cycle.all.min.js and views_slideshow_cycle.js) and the various images are loaded as well. It just won't rotate so maybe there's an error in one of the js files?

Same here though. PHP nor JS coder. :(

It is easier for developers to review patches, so please read the documentation on patches and re-roll the last posted patch.

The changes in #50 are nice, added some more info file goodness, fixing a syntax error in the JS file.

The slideshows still dont work after this patch though.

More rework, cycle style now works finally, fixed form api stuff, so you can update the views style configuration (was broken because of bad html). Updated links and JS.

Can people please review the last patch added here #991708: Rewrite to make a stronger more generic api This will create a fairly large rewrite and will affect any patches listed here greatly. The sooner we can get the previous issue committed the faster we can move on this issue.

Hmmm, so to clarify, are we to choose between the patches in #62 and #63?
And what version should we be patching? I tried with 6.x-3.x-dev (from Nov 20) and neither patch completely worked (there were a few errors with each).

I appreciate the work that is being done with this. Just want to make sure I'm patching correctly and that a workable slideshow can be achieved in D7 with one of these options.

For now I will patch old pre-rewrite 6.x-3.x with the patch in #62 to get slideshow to work in D7. However, I will see if I can review the rewrite patch #63 on one of my 6.x dev sites so the module can move into ass-kicking-D7 mode. :)

btw... I understand patches are really convenient for devvers but for lowly users like us it would be very convenient if we could download the full rewrite as a module (6.x-3.x-alpha?). You will get a lot more responses/reviews. :)

Subscribing

Subscribing

Subscribing

subscribe

Subscribing and can help testing if needed.

Subscribing. Thanks.

Subscribing

Subscribing

Subscribing

subscribing

FYI I have made some progress on the port. Hopefully will have the patch posted this week.

Great news, thanks!

@redndahead
much thanks for the work on this. hope santa was extra good to you this year :D

we are launching a site hopefully next week and would love to have this in place. this is the one module that stands in the way of full D7 adoption at my company.

subscribing

If you would like to help get the patch out please review this core patch so we can hopefully get it committed. Otherwise the UI will be broken for the settings. #1001172: form field states multivalue patch

I went ahead and committed this patch to a new d7 branch. There are still issues that keep this from working, but I still wanted to get all the work committed so I don't lose it. Thank you to everyone for getting this started. Hopefully we can get this fully ported soon. Please open new issues as you find them.

Thanks so much for moving this forward. Really looking forward to a working D7 version.

For the people who were waiting for this to work. The latest patch I committed provides a working d7 version. Please get to testing and creating issues.

@redndahead - "there are still issues that keep this from working" - I thought that this statement plus the presence of dsm() code meant it wasn't ready for testing yet. I will file a separate issue. tx.

@eft. I committed a patch after the one on this issue. That's what I meant.

@redndahead wow, thanks a lot! :D I'll get right on it.

is there any specific feature you need tested?

happy new year!
- Luciano

well, I performed some tests and here's what I found:

1) using the cycle plugin messes the counter: it counts both during the transition AND when the effect is over.
sometimes the count goes forward then back (eg. blindX counts forward during transition then back when it's done).

2) check out the attachment. now I don't know if wipe is supposed to work like that, but there could be a tweak on it, right? I for one won't use slides with different sizes, but you never know what a client might ask ;]

3) in the image, Leonidas comes before Ying Xiong (both in node order and in title, sorted alphabetically) so you can tell the counter's not there yet.

4) Views Slideshow doesn't work on IE7 (won't cycle) nor Chrome/Safari (doesn't load pics).

that's all I found so far :] if you need details, let me know.

cheers,
Luciano

Can you open up new issues for these please.

4) Views Slideshow doesn't work on ... Chrome/Safari (doesn't load pics).

Might be related, so would be good if you could RTBC #1012416: Image styles don't add width/height attributes

@Network, I applied the patch redndahead provided and it worked for me. thanks.

@redndahead, the counter is working: the numbers come in order and the cycle plugin doesn't mess them. my bad.

but on IE7 it still doesn't cycle pics. it says on line 99 that 'JSON' is undefined. maybe that's an issue for malsup? and the wipe behaviour - should he handle that as well?

luco these need to be opened as new issues. please post your comment that the other patch works on that issue and thank you for testing. That JSON issue is in the views slideshow code.

ok, will do. I needed to clear with you first.