Closed (won't fix)
Project:
Mail Comment
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
18 Jul 2010 at 15:28 UTC
Updated:
13 Aug 2013 at 22:47 UTC
Jump to comment: Most recent file
Comments
Comment #1
socialnicheguru commentedThe email you sent to email-address was rejected because there was a validation error.
In order for emails to be accepted by Organization:
- They must be sent in reply to a valid notification email.
- The reply must be done from the same email address the notification was sent to.
Comment #2
crystaldawn commentedI can confirm this is indeed a problem. I've spent days trying to debug this. Once I set "not pass through mailhandler" I received this message. This told me that the MessageID was probably incorrect. So I checked an email that the "subscribe" functions sent out, and it indeed does NOT have the correct messageID. It contains no Nid,Uid, etc type of lines. Instead it looks like this:
<20100804060753.9529FEF1BA@mydomain.com>
Instead of looking like the function docs say it should look like which is:
* Parse message id into parameters
*
* The message id should have this form:
* uid.nid.cid.time.signature@server string
But I do not know how or where the rest of the message ID is built. This is a critical error and completely stops this module from working at all. Since the msg id is not created properly by the subscribe notification emails, any replies to them will never work and will result in the original poster's error msg being displayed in the watchdog logs. If I were to take a guess, I would say that the mailcomment_message_alter (hook_message_alter) is not even being run because this is the only place I could find that builds a message ID header. I added a return at the top of the function which should have essentially broke everything, but it didnt do a single thing. Nothing broke and I did not see the drupal_set_message() notification that I set either. this tells me that the hook was never even run. How is this even possible? Is this hook obsoleted somehow? Is it unfinished? What is it? I've never even heard of it before and its not documented anywhere. What exactly is this hook for and when does it run and by which module is it defined.
So while I know why replies do not work, I am not able to fix this because I simply do not know exactly how this piece of the puzzle works. The code for it is very unreadable and does not have any comments that really help make things clear as to exactly what they are for, do, etc.
Comment #3
greggles@crystaldawn, are you talking about the outgoing messageid?
That can be overwritten by mail servers downstream, particularly smtp servers seem to like to do that if you are using an smtp module to send mail.
Comment #4
crystaldawn commentedI am not using the SMTP module to do the sending. I am using the php mail function which in in turn does use an smtp server but it does not as far as I know re-write any of the headers as that simply wouldnt make any sense. If these messageid's can be overwritten by things like this, then why would this module use the messageid for such a critical role rather than something else? like say the return address (the one used for bounce msgs) or something similar that would not be overwritten? Dont get me wrong, I am not knockin ya, but doesnt it make sense that if you know something like that would happen thats out of the hands of a potential user that you would come up with a different method? The server that this runs on is a CPanel server, I absolutely hate it, and it runs Exim. Do you know of any problems with this type of setup? Can u also explain why the hook_message_alter function simply does not run? I am stumped as to why I cant even get it to use drupal_set_message let alone do what it's suppose to do.
Comment #5
socialnicheguru commentedOk. I finally got it to work.
I looked in my message header and I was getting the right message ID but no message and no return email saying that it bounced.
I disabled mail2og and voila.
I am not sure why this is happening.
I am using mailhandler and mail2og to post content to specific groups.
I want to use mailcomment to reply to the message.
My initial thinking was that mailcomment would reply to the message regardless of the og it is in. I do not know if comments are checked to see if they belong to a message or are they checked to see if they belong to a message and if the comment can be posted to the group.
@crystaldawn, I would suggest opening up another issue.
Comment #6
Ian Ward commented@SocialNicheGuru you could try http://github.com/ianshward/Mail-Group instead of mail2og. It's actually a spaces feature so requires the use of spaces and has a few other requirements. I'm seeing now that spaces and og are not dependencies in the .info file for mailgroup but they should be. It's ideally used with Open Atrium but should work w/o it. I'll release it soon on drupal.org. The module will let you choose a target address (based off of a catchall) for each group and users all get their own email address to send email to for security purposes. The name to use in the subject line for notifications coming from that group.
I realize this is not how to get mail2og working, but mailgroup may accomplish the same task w/ a different feature set.
Comment #7
socialnicheguru commented@Ian Ward, thanks!
Have you tested against mailcomment?
Edit: just read the read me. mailcomment is needed as part of the config.
And I love spaces and Open Atrium. i will try this out and report back!
Comment #8
socialnicheguru commented@Ian Ward
I am a little confused about the module.
I enabled it
how do I set the email address that I should send messages to? Is this automatic depending on the purl prefix of the group url?
i see on the features, mailgroup, settings that I can say which content type that I want the message to become. Will mailhandler options that I put in the email override this?
Comment #9
gwen1 commentedThis post is really helpful, I had at one question for every suggestion that y'all have addressed and now I don't have any questions because you've been so helpful.
Thanks!
Comment #10
Ian Ward commented@SocialNicheGuru OTOH I think the group settings will override whatever you put in the email body as commands for type: content-type. So right now it's limited to making all incoming content just that one type that the group admin chooses. You should first create a mailhandler mailbox which is a catchall email address so that x@example.com, y@example.com, whatever@example.com all go to that address. W/ 1and1 at least the catchall email address is like *@example.com. Then, configure mailcomment, selecting the catchall address. Then, config the global mailgroup settings /admin/settings/mailgroup, then config each group's mailgroup settings.
Comment #11
socialnicheguru commented@Ian Ward.
Is this what the page should look like?
Mailgroup page doesn't seem to have too much on it.
Comment #12
socialnicheguru commentedThanks Ian.
all I get in the /admin/settings/mailgroup page is
mysite.com as the option. even though i setup catchall@mysite.com as the catchall email.
Comment #13
Ian Ward commented@SocialNicheGuru: that's right. You just need to select that base address.
Comment #14
socialnicheguru commented@Ian Dillon
What is the actual group email address?
If my group url is http://mysite.com/my_new_group will the email to send info to for the group be my_new_group@mysite.com?
Comment #15
Ian Ward commentedWhen you're on /mailgroup there should be a block in the sidebar which shows the logged-in user what email address they should send to - it's different for each user which is possible because of the catchall. It sounds like for some reason the block is not showing up for you?
Comment #16
socialnicheguru commentedno it's not.
I am using Gingko theme
What region is it in?
Comment #17
Ian Ward commentedI just re-read the code for the block. It will not show up unless you've filled out all the settings for mailgroup w/in the group - Mailgroup Prefix, subject name, content type. It's set to show up in the right sidebar region.
Comment #18
socialnicheguru commentedI just put in all the settings and still don't see the boxes.
Comment #19
socialnicheguru commentedCan I suggest that if these items are not filled in:
1. if ADDRESS PREFIX is not filled in, then ADDRESS PREFIX can be the purl prefix for the group
2. if SUBJECT NAME is not filled in, then have it be the purl prefix for the group
3. I would also like to suggest that in addition to the features -> mailgroup ->settings page, that the settings for mailgroup show up on /mailgroup page for people with the right permissions. It was just hard finding the settings for mailgroup
I would also suggest global settings like og_contact.
That way I don't have to go in for every group that I create. (I believe that this might be done via feature overrides).
Comment #20
Ian Ward commentedGreat suggestions. Makes a lot of sense. I'll make a d.o project for mailgroup likely this weekend then push this issue into that issue tracker and break it into two separate issues. I'll try debugging the block issue as well if I've got time over the weekend.
Comment #21
socialnicheguru commentedwhich region is the block in. If I don't have the region enabled, it might not show up.
Comment #22
Ian Ward commentedThe right sidebar
Comment #23
donquixote commentedI don't have mail2og installed, but I still get this error message:
Any idea how I can figure out the message id with gmail?
Comment #24
socialnicheguru commentedFatal error: Call to undefined function spaces_features_map() in Mail-Group/mailgroup.module on line 123
Does mailgroup use spaces 2? will it be upgraded?
Comment #25
jludwig commentedI posted a mailcomment patch here http://drupal.org/node/587688#comment-4368576 that needs review. It's not all that flexible, but it works for me.
Comment #26
danepowell commentedSorry, Mail Comment 6.x-1.x is no longer supported. Please upgrade to 6.x-2.x and re-open if still an issue. Thanks!