Some PHP 5.3 warnings that could reveal underlaying real bug [#872752]

Using you module with PHP 5.3, I got some PHP warnings (when running update.php, at the result screen). I think some of these errors might reveal underlaying errors.

I don't have any bugs myself, but you should do a quick review of these:

# Notice: Undefined variable: context in i18nstrings_remove() (line 1208 of /var/www/drupal-installation-profiles/testing/modules/contrib/i18n/i18nstrings/i18nstrings.module).
# Notice: Trying to get property of non-object in i18nstrings_location() (line 811 of /var/www/drupal-installation-profiles/testing/modules/contrib/i18n/i18nstrings/i18nstrings.module).
# Notice: Trying to get property of non-object in i18nstrings_location() (line 813 of /var/www/drupal-installation-profiles/testing/modules/contrib/i18n/i18nstrings/i18nstrings.module).
# Notice: Trying to get property of non-object in i18nstrings_location() (line 813 of /var/www/drupal-installation-profiles/testing/modules/contrib/i18n/i18nstrings/i18nstrings.module).
# Notice: Trying to get property of non-object in i18nstrings_params() (line 784 of /var/www/drupal-installation-profiles/testing/modules/contrib/i18n/i18nstrings/i18nstrings.module).

I'm going to make a quick and dirty patch to shut up the errors, but doing too much isset() or empty() tests won't make debuging easier.

Comment	File	Size	Author
#8	i18n-i18ncontent-notice-fix.patch	923 bytes	Aleksey Zubko
#5	i18n-i18nstrings-notice-fixes-872752-5-D6.patch	9.5 KB	mikeytown2
#3	context_no_notice.patch	499 bytes	LSU_JBob

Comments

Comment #1

pounard

French

commented 3 August 2010 at 15:45

I see at least one or two of theses which seems to be OK.

i18nstrings.module, line 815 is:

if ($context->property) {

You might want to write, in order to avoid such PHP warnings (for 5.3 only):

if (isset($context->property) && !empty($context->property)) {

This should still give some warnings, because if $context is not an object, then PHP will warn about a property access attempt on a non existing object.

It seems that in the i18ntrings_location() function, you never test if the $context parameter is empty or not, but it seems that in the use case I'm currently dealing with, the method attempt to run with an non object variable (it also might be a wrong usage of this module by another third party module).

Comment #2

LSU_JBob commented 16 August 2010 at 21:30

I'm getting a whole slew of these errors whenever I save modules or run update.php

* Notice: Undefined variable: context in i18nstrings_remove() (line 1208 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_location() (line 811 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_location() (line 813 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_location() (line 813 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_params() (line 784 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Undefined variable: context in i18nstrings_remove() (line 1208 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_location() (line 811 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_location() (line 813 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_location() (line 813 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_params() (line 784 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Undefined variable: context in i18nstrings_remove() (line 1208 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_location() (line 811 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_location() (line 813 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_location() (line 813 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Trying to get property of non-object in i18nstrings_params() (line 784 of /Developer/testproject/docroot/sites/all/modules/i18n/i18nstrings/i18nstrings.module).
* Notice: Undefined index: configurable in actions_synchronize() (line 323 of /Developer/testproject/docroot/includes/actions.inc).

I tried your small fix pounard but to no avail. How can I stop these notices from coming up whenever I save modules or run update.php?