collapseAutoAttach (collapse.js) when called more than once, creates double hyperlinks and arrows in the legend element

Hi agentrickard, here are my answers:

1) How are you loading the collapse.js file?

It gets loaded by form.inc:theme_fieldset() as usual. I don't do anything special with it.

2) Does collapse.js get loaded onto the finished output more than once (check source of the rendered page)?

No, that doesn't happen, and the initial page loads just fine! The problem appears later, see question 3.

3) How are you calling collapseAutoAttach? I don't think this needs to be called directly.

I reload and replace pieces of the HTML with AJAX, and these pieces unfortunately contain collapsible fieldsets.
So, after the replacement i need to call collapseAutoAttach or they simply won't become collapsible.

If there is another way to handle this, i'd be glad to hear of it.

Danny

And some code, to be complete

realestate.js:

// Global killswitch
if (isJsEnabled()) {
  addLoadEvent(realestateAutoAttach);
}

/**
 * Attaches the Realestate behaviour to the Realestate form.
 */
function realestateAutoAttach() {
  var inputs = document.getElementsByTagName('input');
  for (i = 0; input = inputs[i]; i++) {
    if (input && hasClass(input, 'swlocselect')) {
      var uri = input.value;
      // Extract the button ID based on a substring of the input name: edit[foo][bar] -> foo-bar
      var selector = input.name.replace('-swlocselect', '').replace(/\]\[/g,'-').replace('[','-').replace(']','');
      var locwrapper = 'location-wrapper';
      var propwrapper = 'properties-wrapper';
      var switcher = new jsRealestateSwitch(uri, selector, locwrapper, propwrapper);
    }
    else if (input && hasClass(input, 'swlocbutton')) {
      input.style.display = 'none';
    }
  }
}

/**
 * JS Realestate object.
 */
function jsRealestateSwitch(uri, selector, locwrapper, propwrapper) {
  this.selector    = selector;
  this.locwrapper  = locwrapper;
  this.propwrapper = propwrapper;
  redirectFormChange(uri, $(selector), this);
}

/**
 * Handler for the form redirection submission.
 */
jsRealestateSwitch.prototype.onsubmit = function () {
  $(this.selector).form.submit();
}

/**
 * Handler for the form redirection completion.
 */
jsRealestateSwitch.prototype.oncomplete = function (data) {
  // Replace form and re-attach behaviour

  if (data['location']) {
    $(this.locwrapper).innerHTML = data['location'];
  }
  if (data['property']) {
    $(this.propwrapper).innerHTML = data['property'];
  }
  
  realestateAutoAttach();
  collapseAutoAttach();
}

/**
 * Handler for the form redirection error.
 */
jsRealestateSwitch.prototype.onerror = function (error) {
  alert('An error occurred:\n\n'+ error);
}

An alternative could be to call all functions passed to 'addLoadEvent()' with a parameter 'document' object on which to apply modifications.
This requires modification of all these handlers, though, that have to accept the parameter, including the drupal.js:onLoadEvent() function.

@agentrichard:
Yes, it is caused by calling collapseAutoAttach() twice. As i explained, i have to do this to make the fieldsets in the dynamically loaded part expandable.

@greggles:
No, this issue reports the exact oposite, where collapseAutoAttach() doesn't seem to be called at all
I use pathauto too, but i don't have these problems. But then, that issue applies to 5.0 while i'm using 4.7, so i can't really say too much about it.

Danny