Here is a initial untested port based on cvs

CommentFileSizeAuthor
#1 buymeabeer-7.x.patch15.8 KBdawehner
buymeabeer-7.x.patch5.33 KBdawehner

Comments

dawehner’s picture

StatusFileSize
new15.8 KB

Here is a new version

SirFiChi’s picture

Category: task » bug
Status: Needs review » Needs work

There is allways a failure:

admin/content/buymeabeer ==>
Fatal error: Call to undefined function node_get_types() in /sites/all/modules/buymeabeer/buymeabeer.admin.inc on line 59

THX a lot dereine...

dawehner’s picture

Status: Needs work » Needs review

This is already fixed in the latest patch :)

yaph’s picture

@dereine: I cannot successfully apply your 2nd patch to CVS HEAD receiving several errors about failed Hunks.

patching file buymeabeer.admin.inc
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #6 FAILED at 55.
Hunk #7 FAILED at 71.
2 out of 7 hunks FAILED -- saving rejects to file buymeabeer.admin.inc.rej
patching file buymeabeer.info
Hunk #1 succeeded at 1 with fuzz 1.
patching file buymeabeer.module
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #3 FAILED at 34.
Hunk #4 succeeded at 80 (offset 2 lines).
Hunk #5 FAILED at 93.
2 out of 5 hunks FAILED -- saving rejects to file buymeabeer.module.rej
The next patch would create the file js/buymeabeer_admin.js,
which already exists!  Assume -R? [n] y
patching file js/buymeabeer_admin.js
Hunk #1 FAILED at 1.
File js/buymeabeer_admin.js is not empty after patch, as expected
1 out of 1 hunk FAILED -- saving rejects to file js/buymeabeer_admin.js.rej
The next patch would create the file translations/de.po,
which already exists!  Assume -R? [n] y
patching file translations/de.po
Hunk #1 FAILED at 1.
File translations/de.po is not empty after patch, as expected
1 out of 1 hunk FAILED -- saving rejects to file translations/de.po.rej
yaph’s picture

Assigned: Unassigned » yaph
Category: bug » task
yaph’s picture

@dereine: One question about use of t() inside define() (see http://drupal.org/node/448118) in your D7 patch. Is this not an issue anymore in D7?

dawehner’s picture

I will create a patch against cvs. Git does not work as expected from git.drupalcode.org

d34dman’s picture

imho, dereine should assign this issue to himself as it seems he have forgotten to create the patch that he mentioned in #7. I understand dereine might be too busy as he is involved in many modules simultaneously. Good luck dereine.

dawehner’s picture

Something like this is a perfect project for a train ride, but sadly i don't have one in the next weeks. So this might require one month or so.

nick_vh’s picture

Status: Needs review » Closed (duplicate)

Closing this as duplicate, in order to start with a clean slate : #1669224: Some improvements to the Drupal 7 version