Closed (fixed)
Project:
CVS integration
Version:
4.7.x-2.0
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
5 Nov 2006 at 17:27 UTC
Updated:
26 Nov 2006 at 14:31 UTC
Jump to comment: Most recent file
Currently, users with 'administer cvs' permissions are unable to access the CVS edit form in user/uid/edit/cvs to approve/decline applications due to the fact that this form/page is generated via a hook_user call and requires 'administer users' permissions. This is obviously not very flexible and the attached patch should fix it.
The attached patch simply moves the 'form', 'validate' and 'update' blocks from hook_user into separate _form(), _validate and _submit methods. The only point of concern has been noted in hook_menu.
This needs some testing from people familiar with the module.
Cheers,
-K
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | cvslog-4-7.patch | 14.42 KB | Zen |
| cvslog_0.patch | 14.72 KB | Zen |
Comments
Comment #1
Zen commentedRerolled for 4-7-0 as opposed to 4-7-2.
-K
Comment #2
Zen commentedThis patch has been running fine on drupal.org. Committed.
-K
Comment #3
dwwthis (or http://drupal.org/node/97031) broke http://drupal.org/cvs
see http://drupal.org/node/97136
Comment #4
Zen commentedComment #5
(not verified) commented