Currently, users with 'administer cvs' permissions are unable to access the CVS edit form in user/uid/edit/cvs to approve/decline applications due to the fact that this form/page is generated via a hook_user call and requires 'administer users' permissions. This is obviously not very flexible and the attached patch should fix it.

The attached patch simply moves the 'form', 'validate' and 'update' blocks from hook_user into separate _form(), _validate and _submit methods. The only point of concern has been noted in hook_menu.

This needs some testing from people familiar with the module.

Cheers,
-K

CommentFileSizeAuthor
#1 cvslog-4-7.patch14.42 KBZen
cvslog_0.patch14.72 KBZen

Comments

Zen’s picture

StatusFileSize
new14.42 KB

Rerolled for 4-7-0 as opposed to 4-7-2.

-K

Zen’s picture

Version: 4.7.x-1.x-dev » 4.7.x-2.0
Status: Needs review » Fixed

This patch has been running fine on drupal.org. Committed.

-K

dww’s picture

Status: Fixed » Needs work
Zen’s picture

Status: Needs work » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)