1. Add a module_exist() for the project module in hook_settings.
2. Format introductory message and other text on cvs-application screen.
3. Add status message and redirect on the user/edit/cvs page.
4. Fix CVS account management e-mails to originate from the mailing list address rather than the administrator. The mailing list has been tested to ensure that it accepts e-mails from non-subscribers.
5. Fix e-mail text.
6. Reorder the columns in the CVS management table to commits, first commit and last commit rather than last commit, first commit and commits.

That's it I believe.

Cheers.
-K

CommentFileSizeAuthor
#7 cvslog_1.patch24.14 KBZen
cvslog_text.patch10.33 KBZen

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented

looks good.

Zen’s picture

Zen commented
Status: Needs review » Fixed

Committed - thanks.

-K

dww’s picture

dww
we/he/they
commented
Status: Fixed » Needs work

this (or http://drupal.org/node/93089) broke http://drupal.org/cvs
see http://drupal.org/node/97136

Zen’s picture

Zen commented
Status: Needs work » Fixed
dww’s picture

dww
we/he/they
commented
Status: Fixed » Needs work

carefully reviewing the patch, i noticed:

  1. some missing % stuff in the 'CVS_MESSAGE_AUTH' for the account form, so now there are broken links at http://drupal.org/cvs-account (e.g. to the cvs handbook and patch guide).
  2. CVS_APPROVED email text:
    • no t()
    • in the important links, it should give an extra plug to http://drupal.org/handbook/cvs -- even though it's a subpage of http://drupal.org/contributors-guide, there's a lot of stuff there, so we should emphasize they really must read /handbook/cvs if nothing else, and also since webchick and i recently poured so many hours into making those docs nice. ;)
    • i'd prefer if this message was turned into another define() at the top, and there was another setting where it could be customized for non-d.o sites.
  3. description of the motivation field:
    • again, i'd like this a define() and a setting
    • minor wording gripe "possible" features heavily in the first item. ;)

phew (big diff, lots of details to pour over). other than that, it's great. thanks for all your work on this!

please post a new patch relative to the end of DRUPAL-4-7--2 branch and set to review. i'll RTBC and you should commit (again, only to DRUPAL-4-7--2 ... i'm periodically merging into HEAD as appropriate).

thanks,
-derek

dww’s picture

dww
we/he/they
commented
Category: task » bug
Priority: Minor » Normal

or, on second thought... just fix the broken links in #1 right away (commit at will).
you can leave the other stuff for later (and set this back to minor task).... ;)

thanks,
-d

Zen’s picture

Zen commented
Status: Needs work » Needs review
StatusFileSize
new cvslog_1.patch24.14 KB

Attached patch:

  • Moves all application form and e-mail strings to a separate private function.
  • Allows for the configuration of the above strings via hook_settings.
  • Fixes some of the strings' text.
  • Changes cvs_get_status_options to a private function.
  • Add CVS link.
  • Fix word gripe.
  • Adds missing t()s.
  • Fixes some whitespace issues.
  • Moves the user account details in the CVS application form above the motivation fieldset to provide more emphasis to the latter.
  • Threatens the applicant with emasculation if he submits his application without a decent motivation message.

Cheers,
-K

killes@www.drop.org’s picture

killes@www.drop.org commented

this looks good to me.

Zen’s picture

Zen commented
Status: Needs review » Fixed

Committed, thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)